public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Feng, Bob C" <bob.c.feng@intel.com>
To: edk2-devel@lists.01.org
Cc: Bob Feng <bob.c.feng@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: [Patch] BaseTools: Fix a ParseDevPathValue function issue.
Date: Sat, 16 Feb 2019 23:38:26 +0800	[thread overview]
Message-ID: <20190216153826.13884-1-bob.c.feng@intel.com> (raw)

In ParseDevPathValue, the binary data need to convert to string
for python3 and python2 compatiblity.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/Python/Common/Misc.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Python/Common/Misc.py
index 565a5ad40b..c7daf5417c 100644
--- a/BaseTools/Source/Python/Common/Misc.py
+++ b/BaseTools/Source/Python/Common/Misc.py
@@ -1030,10 +1030,11 @@ def ParseFieldValue (Value):
             subprocess._cleanup()
             p.stdout.close()
             p.stderr.close()
         if err:
             raise BadExpression("DevicePath: %s" % str(err))
+        out = out.decode()
         Size = len(out.split())
         out = ','.join(out.split())
         return '{' + out + '}', Size
 
     if "{CODE(" in Value:
-- 
2.18.0.windows.1



             reply	other threads:[~2019-02-16 15:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 15:38 Feng, Bob C [this message]
2019-02-19  9:07 ` [Patch] BaseTools: Fix a ParseDevPathValue function issue Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190216153826.13884-1-bob.c.feng@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox