* [PATCH 1/4] MdeModulePkg: change the function name ResetSystem
2019-02-18 10:57 [PATCH 0/4] Add a new API ResetSystem for ResetSystemLib Zhichao Gao
@ 2019-02-18 10:57 ` Zhichao Gao
2019-02-18 10:57 ` [PATCH 2/4] MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib Zhichao Gao
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Zhichao Gao @ 2019-02-18 10:57 UTC (permalink / raw)
To: edk2-devel; +Cc: Ray Ni, Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Change the function name form ResetSystem to EfiRuntimeResetSystem.
Because ResetSystem and EfiResetSystem would be used in ResetSystemLib
and RuntimeLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++----
MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
index afc35587fc..e16b0cda7b 100644
--- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
+++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
@@ -1,7 +1,7 @@
/** @file
Reset Architectural and Reset Notification protocols implementation.
- Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -187,7 +187,7 @@ InitializeResetSystem (
//
// Hook the runtime service table
//
- gRT->ResetSystem = ResetSystem;
+ gRT->ResetSystem = EfiRuntimeResetSystem;
//
// Now install the Reset RT AP on a new handle
@@ -242,7 +242,7 @@ DoS3 (
**/
VOID
EFIAPI
-ResetSystem (
+EfiRuntimeResetSystem (
IN EFI_RESET_TYPE ResetType,
IN EFI_STATUS ResetStatus,
IN UINTN DataSize,
@@ -256,7 +256,7 @@ ResetSystem (
RESET_NOTIFY_ENTRY *Entry;
//
- // Only do REPORT_STATUS_CODE() on first call to ResetSystem()
+ // Only do REPORT_STATUS_CODE() on first call to EfiRuntimeResetSystem()
//
if (mResetNotifyDepth == 0) {
//
diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h
index 8529de675c..448e30f079 100644
--- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h
+++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h
@@ -1,6 +1,6 @@
/** @file
- Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -97,7 +97,7 @@ InitializeResetSystem (
**/
VOID
EFIAPI
-ResetSystem (
+EfiRuntimeResetSystem (
IN EFI_RESET_TYPE ResetType,
IN EFI_STATUS ResetStatus,
IN UINTN DataSize,
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/4] MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib
2019-02-18 10:57 [PATCH 0/4] Add a new API ResetSystem for ResetSystemLib Zhichao Gao
2019-02-18 10:57 ` [PATCH 1/4] MdeModulePkg: change the function name ResetSystem Zhichao Gao
@ 2019-02-18 10:57 ` Zhichao Gao
2019-02-18 10:57 ` [PATCH 3/4] MdeModulePkg: Add a new API ResetSystem for PEI ResetSystemLib Zhichao Gao
2019-02-18 10:57 ` [PATCH 4/4] MdeModulePkg: Add the new API ResetSystem in the head file Zhichao Gao
3 siblings, 0 replies; 5+ messages in thread
From: Zhichao Gao @ 2019-02-18 10:57 UTC (permalink / raw)
To: edk2-devel; +Cc: Ray Ni, Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem for DXE ResetSystemLib. So the consumer of
ResetSystemLib can use this API to reset system with additional reset
data.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
.../Library/DxeResetSystemLib/DxeResetSystemLib.c | 28 +++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c
index ea4878cab1..f5c7386c9a 100644
--- a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c
+++ b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c
@@ -1,7 +1,7 @@
/** @file
DXE Reset System Library instance that calls gRT->ResetSystem().
- Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -96,3 +96,29 @@ ResetPlatformSpecific (
{
gRT->ResetSystem (EfiResetPlatformSpecific, EFI_SUCCESS, DataSize, ResetData);
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset. ResetData is only valid if ResetStatus is something
+ other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
+ where a minimum amount of ResetData is always required.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ gRT->ResetSystem (ResetType, ResetStatus, DataSize, ResetData);
+}
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/4] MdeModulePkg: Add a new API ResetSystem for PEI ResetSystemLib
2019-02-18 10:57 [PATCH 0/4] Add a new API ResetSystem for ResetSystemLib Zhichao Gao
2019-02-18 10:57 ` [PATCH 1/4] MdeModulePkg: change the function name ResetSystem Zhichao Gao
2019-02-18 10:57 ` [PATCH 2/4] MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib Zhichao Gao
@ 2019-02-18 10:57 ` Zhichao Gao
2019-02-18 10:57 ` [PATCH 4/4] MdeModulePkg: Add the new API ResetSystem in the head file Zhichao Gao
3 siblings, 0 replies; 5+ messages in thread
From: Zhichao Gao @ 2019-02-18 10:57 UTC (permalink / raw)
To: edk2-devel; +Cc: Ray Ni, Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem for PEI ResetSystemLib to be in accord with
DXE instance.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
.../Library/PeiResetSystemLib/PeiResetSystemLib.c | 28 +++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c
index d8219775d1..f35acb3c6e 100644
--- a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c
+++ b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c
@@ -1,7 +1,7 @@
/** @file
PEI Reset System Library instance that calls the ResetSystem2() PEI Service.
- Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -96,3 +96,29 @@ ResetPlatformSpecific (
{
PeiServicesResetSystem2 (EfiResetPlatformSpecific, EFI_SUCCESS, DataSize, ResetData);
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset. ResetData is only valid if ResetStatus is something
+ other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
+ where a minimum amount of ResetData is always required.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ PeiServicesResetSystem2 (ResetType, ResetStatus, DataSize, ResetData);
+}
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 4/4] MdeModulePkg: Add the new API ResetSystem in the head file
2019-02-18 10:57 [PATCH 0/4] Add a new API ResetSystem for ResetSystemLib Zhichao Gao
` (2 preceding siblings ...)
2019-02-18 10:57 ` [PATCH 3/4] MdeModulePkg: Add a new API ResetSystem for PEI ResetSystemLib Zhichao Gao
@ 2019-02-18 10:57 ` Zhichao Gao
3 siblings, 0 replies; 5+ messages in thread
From: Zhichao Gao @ 2019-02-18 10:57 UTC (permalink / raw)
To: edk2-devel; +Cc: Ray Ni, Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add the new API ResetSystem in the related head file so that
the consumer can use it through the combination of library
instance and head file.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
https://bugzilla.tianocore.org/show_bug.cgi?id=1460
---
MdeModulePkg/Include/Library/ResetSystemLib.h | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Include/Library/ResetSystemLib.h b/MdeModulePkg/Include/Library/ResetSystemLib.h
index 55d1923ae1..2f5d15ade8 100644
--- a/MdeModulePkg/Include/Library/ResetSystemLib.h
+++ b/MdeModulePkg/Include/Library/ResetSystemLib.h
@@ -2,7 +2,7 @@
System reset Library Services. This library class defines a set of
methods that reset the whole system.
-Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2005 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed and made available under
the terms and conditions of the BSD License that accompanies this distribution.
The full text of the license may be found at
@@ -83,4 +83,27 @@ ResetPlatformSpecific (
IN VOID *ResetData
);
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset. ResetData is only valid if ResetStatus is something
+ other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
+ where a minimum amount of ResetData is always required.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ );
+
#endif
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread