From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 96F88211CBCE1 for ; Wed, 20 Feb 2019 06:38:29 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id m1so6937930wml.2 for ; Wed, 20 Feb 2019 06:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VxzEnyI0rW1GQGgfATVmoP2qCJ0mrRwlWN9/daHIsYw=; b=vfdIY9MM+ENhzFzEFzcqaseLviqEThlefXQPcsiLYWQZvtaF9Tp0uf944ME30Wpx7V /NxvZ2MrNqbbsoUzDnoF5S7WXHfOfJUrIJgGsKa0GVuvi2BAHRkVo5Ooaibx9BzyLbP1 7FWqT7lHPmeM6dWzj01nHMUTDJLvDyrhNK7t3AvgzqaaRpTpByIv2ZD4aR/gnk+iIuta 1aD8KgwCTtAudBZsBGCU3A1ze4kitf504tNRXrXrw5IH9DB1jkzMgO9XirzIdgAyEWuY TYK33zMWr/0z9wVtsES39/T1uYq6+3nKHC5kl/BjNHyny427y2sTCRcp5GOmdnk7EfkM hHyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VxzEnyI0rW1GQGgfATVmoP2qCJ0mrRwlWN9/daHIsYw=; b=S2B7XOOXBdE6KCTuwbtLUIgXiJL8TV2ACuNaqr9RbZpf0WT/Q7Vwd6C6SwBqEEYtIT +Xd/HlAffEEXuZJeqDysQCp55aJlWWR578vmR9Vh0na6GvAu4BU2zZQjdUpgDse81Kbs xIFJTiLYPTYFaIz6HtuVhsu/OdPvjpjcRo3DNl1rn8oDFWs6s1Hc4p1z+Q6GbKklZspL uVSMyqp3Og7rhqf7n+ro1jcXKD/SuyezmrN/5QTM8wPWgP/6r2iyLd4UbqPcEcD0mUCK h5I8vYc/ByqdG4tmL3wl9GUvLKvcV3PT6Sg1hAxSd7gbC5GDoS3+UvCc51Vac2xrm/d6 /ADg== X-Gm-Message-State: AHQUAuYBRiS0+7fZRG1+a8NvQU5xn5dHCKvuOW5q+PbS0sIg56ZBoKDS K9busxK6vyuzdfeJdvqXJGykZQ== X-Google-Smtp-Source: AHgI3IbMjXIUVT/9HcZcMzrzaqBLbJCf4XaX4Pm2kLpSXv/n3bzgQ28/FYYR/LzhYdwdPbyfSDs5EQ== X-Received: by 2002:a1c:be09:: with SMTP id o9mr6830338wmf.3.1550673507811; Wed, 20 Feb 2019 06:38:27 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h9sm15371957wrv.11.2019.02.20.06.38.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 06:38:26 -0800 (PST) Date: Wed, 20 Feb 2019 14:38:20 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20190220143820.en6bdbi7swbhpsgx@bivouac.eciton.net> References: <20190220142741.28232-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190220142741.28232-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Silicon/AMD/Styx/Drivers/AcpiPlatformDxe: use correct object ref in DBG2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 14:38:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 20, 2019 at 03:27:41PM +0100, Ard Biesheuvel wrote: > The NamespaceString[] field in the DBG2 table should contain a fully > qualified ACPI namespace object reference. This was found by fwts. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc > index 07635aa9dd8e..e55119258bac 100644 > --- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc > +++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc > @@ -25,7 +25,7 @@ > #define EFI_ACPI_DBG2_REVISION 0 > #define DBG2_NUM_DEBUG_PORTS 1 > #define DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS 1 > -#define DBG2_NAMESPACESTRING_FIELD_SIZE 8 > +#define DBG2_NAMESPACESTRING_FIELD_SIZE 9 > #define DBG2_OEM_DATA_FIELD_SIZE 0 > #define DBG2_OEM_DATA_FIELD_OFFSET 0 > > @@ -33,7 +33,7 @@ > #define DBG2_DEBUG_PORT_SUBTYPE_UEFI 0x0007 // Sub type for UEFI Debug Port > #define PL011_UART_LENGTH 0x1000 > > -#define NAME_STR_UART1 {'C', 'O', 'M', '1', '\0', '\0', '\0', '\0'} > +#define NAME_STR_UART1 "\\SB.COM1" > #define NAME_STR_UEFI {'U', 'E', 'F', 'I', '\0', '\0', '\0', '\0'} > > > -- > 2.20.1 >