* [PATCH v2 1/2] Maintainers: add TPM2 reviewers for OvmfPkg
2019-02-21 12:28 [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg Laszlo Ersek
@ 2019-02-21 12:28 ` Laszlo Ersek
2019-02-21 17:16 ` Marc-André Lureau
2019-02-21 12:28 ` [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers Laszlo Ersek
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Laszlo Ersek @ 2019-02-21 12:28 UTC (permalink / raw)
To: edk2-devel
Cc: Andrew Fish, Ard Biesheuvel, Jordan Justen, Leif Lindholm,
Marc-André Lureau, Michael D Kinney, Stefan Berger
OVMF can be built with a significant amount of TPM2 code now; add
Marc-André and Stefan as Reviewers for TPM2-related patches.
Keep the list of "R" entries alphabetically sorted.
Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Jordan Justen <jordan.l.justen@intel.com>
---
Notes:
v2:
- pick up feedback tags
- describe the Reviewership scope, in the format seen under MdeModulePkg
[Marc-André]
Maintainers.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 3b2676bc32ea..e45b77039d67 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -218,6 +218,10 @@ M: Laszlo Ersek <lersek@redhat.com>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
R: Anthony Perard <anthony.perard@citrix.com>
R: Julien Grall <julien.grall@linaro.org>
+R: Marc-André Lureau <marcandre.lureau@redhat.com>
+ (TPM2 modules)
+R: Stefan Berger <stefanb@linux.ibm.com>
+ (TPM2 modules)
S: Maintained
PcAtChipsetPkg
--
2.19.1.3.g30247aa5d201
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 1/2] Maintainers: add TPM2 reviewers for OvmfPkg
2019-02-21 12:28 ` [PATCH v2 1/2] Maintainers: add TPM2 reviewers for OvmfPkg Laszlo Ersek
@ 2019-02-21 17:16 ` Marc-André Lureau
0 siblings, 0 replies; 9+ messages in thread
From: Marc-André Lureau @ 2019-02-21 17:16 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel, Andrew Fish, Ard Biesheuvel, Jordan Justen,
Leif Lindholm, Michael D Kinney, Stefan Berger
Hi
On Thu, Feb 21, 2019 at 1:28 PM Laszlo Ersek <lersek@redhat.com> wrote:
>
> OVMF can be built with a significant amount of TPM2 code now; add
> Marc-André and Stefan as Reviewers for TPM2-related patches.
>
> Keep the list of "R" entries alphabetically sorted.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>
> Notes:
> v2:
> - pick up feedback tags
> - describe the Reviewership scope, in the format seen under MdeModulePkg
> [Marc-André]
>
> Maintainers.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 3b2676bc32ea..e45b77039d67 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -218,6 +218,10 @@ M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> R: Anthony Perard <anthony.perard@citrix.com>
> R: Julien Grall <julien.grall@linaro.org>
> +R: Marc-André Lureau <marcandre.lureau@redhat.com>
> + (TPM2 modules)
> +R: Stefan Berger <stefanb@linux.ibm.com>
> + (TPM2 modules)
> S: Maintained
>
> PcAtChipsetPkg
> --
> 2.19.1.3.g30247aa5d201
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers
2019-02-21 12:28 [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg Laszlo Ersek
2019-02-21 12:28 ` [PATCH v2 1/2] Maintainers: add TPM2 reviewers for OvmfPkg Laszlo Ersek
@ 2019-02-21 12:28 ` Laszlo Ersek
2019-02-21 12:32 ` Anthony PERARD
2019-02-21 16:49 ` Julien Grall
2019-02-21 12:30 ` [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg Ard Biesheuvel
2019-02-21 19:42 ` Laszlo Ersek
3 siblings, 2 replies; 9+ messages in thread
From: Laszlo Ersek @ 2019-02-21 12:28 UTC (permalink / raw)
To: edk2-devel
Cc: Andrew Fish, Anthony Perard, Ard Biesheuvel, Jordan Justen,
Julien Grall, Leif Lindholm, Michael D Kinney
We can use the format introduced under MdeModulePkg to clarify the
reviewership scopes a little. This should decrease the review spam that
Xen reviewers get.
Cc: Andrew Fish <afish@apple.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien.grall@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Notes:
v2:
- new in v2
Maintainers.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index e45b77039d67..86f80b7d38a0 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -81,6 +81,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
M: Laszlo Ersek <lersek@redhat.com>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
R: Julien Grall <julien.grall@linaro.org>
+ (Xen modules)
BaseTools
W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
@@ -217,7 +218,9 @@ M: Jordan Justen <jordan.l.justen@intel.com>
M: Laszlo Ersek <lersek@redhat.com>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
R: Anthony Perard <anthony.perard@citrix.com>
+ (Xen modules)
R: Julien Grall <julien.grall@linaro.org>
+ (Xen modules)
R: Marc-André Lureau <marcandre.lureau@redhat.com>
(TPM2 modules)
R: Stefan Berger <stefanb@linux.ibm.com>
--
2.19.1.3.g30247aa5d201
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers
2019-02-21 12:28 ` [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers Laszlo Ersek
@ 2019-02-21 12:32 ` Anthony PERARD
2019-02-21 16:49 ` Julien Grall
1 sibling, 0 replies; 9+ messages in thread
From: Anthony PERARD @ 2019-02-21 12:32 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel, Andrew Fish, Ard Biesheuvel, Jordan Justen,
Julien Grall, Leif Lindholm, Michael D Kinney
On Thu, Feb 21, 2019 at 01:28:04PM +0100, Laszlo Ersek wrote:
> We can use the format introduced under MdeModulePkg to clarify the
> reviewership scopes a little. This should decrease the review spam that
> Xen reviewers get.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Notes:
> v2:
> - new in v2
>
> Maintainers.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index e45b77039d67..86f80b7d38a0 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -81,6 +81,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
> M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> R: Julien Grall <julien.grall@linaro.org>
> + (Xen modules)
>
> BaseTools
> W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
> @@ -217,7 +218,9 @@ M: Jordan Justen <jordan.l.justen@intel.com>
> M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> R: Anthony Perard <anthony.perard@citrix.com>
> + (Xen modules)
> R: Julien Grall <julien.grall@linaro.org>
> + (Xen modules)
> R: Marc-André Lureau <marcandre.lureau@redhat.com>
> (TPM2 modules)
> R: Stefan Berger <stefanb@linux.ibm.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers
2019-02-21 12:28 ` [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers Laszlo Ersek
2019-02-21 12:32 ` Anthony PERARD
@ 2019-02-21 16:49 ` Julien Grall
2019-02-21 16:56 ` Laszlo Ersek
1 sibling, 1 reply; 9+ messages in thread
From: Julien Grall @ 2019-02-21 16:49 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel
Cc: Andrew Fish, Anthony Perard, Ard Biesheuvel, Jordan Justen,
Leif Lindholm, Michael D Kinney
Hi Laszlo,
On 21/02/2019 12:28, Laszlo Ersek wrote:
> We can use the format introduced under MdeModulePkg to clarify the
> reviewership scopes a little. This should decrease the review spam that
> Xen reviewers get.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Notes:
> v2:
> - new in v2
>
> Maintainers.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index e45b77039d67..86f80b7d38a0 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -81,6 +81,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
> M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> R: Julien Grall <julien.grall@linaro.org>
> + (Xen modules)
>
> BaseTools
> W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
> @@ -217,7 +218,9 @@ M: Jordan Justen <jordan.l.justen@intel.com>
> M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> R: Anthony Perard <anthony.perard@citrix.com>
> + (Xen modules)
> R: Julien Grall <julien.grall@linaro.org>
> + (Xen modules)
> R: Marc-André Lureau <marcandre.lureau@redhat.com>
> (TPM2 modules)
> R: Stefan Berger <stefanb@linux.ibm.com>
>
Acked-by: Julien Grall <julien.grall@arm.com>
Cheers,
--
Julien Grall
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers
2019-02-21 16:49 ` Julien Grall
@ 2019-02-21 16:56 ` Laszlo Ersek
0 siblings, 0 replies; 9+ messages in thread
From: Laszlo Ersek @ 2019-02-21 16:56 UTC (permalink / raw)
To: Julien Grall, edk2-devel
Cc: Andrew Fish, Anthony Perard, Ard Biesheuvel, Jordan Justen,
Leif Lindholm, Michael D Kinney
On 02/21/19 17:49, Julien Grall wrote:
> Hi Laszlo,
>
> On 21/02/2019 12:28, Laszlo Ersek wrote:
>> We can use the format introduced under MdeModulePkg to clarify the
>> reviewership scopes a little. This should decrease the review spam that
>> Xen reviewers get.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Julien Grall <julien.grall@linaro.org>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Notes:
>> v2:
>> - new in v2
>>
>> Maintainers.txt | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index e45b77039d67..86f80b7d38a0 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -81,6 +81,7 @@ W:
>> https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
>> M: Laszlo Ersek <lersek@redhat.com>
>> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> R: Julien Grall <julien.grall@linaro.org>
>> + (Xen modules)
>> BaseTools
>> W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
>> @@ -217,7 +218,9 @@ M: Jordan Justen <jordan.l.justen@intel.com>
>> M: Laszlo Ersek <lersek@redhat.com>
>> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> R: Anthony Perard <anthony.perard@citrix.com>
>> + (Xen modules)
>> R: Julien Grall <julien.grall@linaro.org>
>> + (Xen modules)
>> R: Marc-André Lureau <marcandre.lureau@redhat.com>
>> (TPM2 modules)
>> R: Stefan Berger <stefanb@linux.ibm.com>
>>
>
> Acked-by: Julien Grall <julien.grall@arm.com>
Thanks!
(For readers not following the other thread: by the time I push this,
Maintainers.txt will refer to Julien's @arm.com email address. I'll
resolve the conflict, and there won't be a mismatch between the text
file contents and Julien's ACK.)
Laszlo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg
2019-02-21 12:28 [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg Laszlo Ersek
2019-02-21 12:28 ` [PATCH v2 1/2] Maintainers: add TPM2 reviewers for OvmfPkg Laszlo Ersek
2019-02-21 12:28 ` [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers Laszlo Ersek
@ 2019-02-21 12:30 ` Ard Biesheuvel
2019-02-21 19:42 ` Laszlo Ersek
3 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2019-02-21 12:30 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel@lists.01.org, Andrew Fish, Anthony Perard,
Jordan Justen, Julien Grall, Leif Lindholm,
Marc-André Lureau, Michael D Kinney, Stefan Berger
On Thu, 21 Feb 2019 at 13:28, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Previous version:
> [edk2] [PATCH] Maintainers: add TPM2 reviewers for OvmfPkg
> https://lists.01.org/pipermail/edk2-devel/2019-February/036495.html
>
> Patch #1 in v2 is an iteration of the above. Patch #2 in v2 is new.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (2):
> Maintainers: add TPM2 reviewers for OvmfPkg
> Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module
> reviewers
>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
(for the series)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg
2019-02-21 12:28 [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg Laszlo Ersek
` (2 preceding siblings ...)
2019-02-21 12:30 ` [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg Ard Biesheuvel
@ 2019-02-21 19:42 ` Laszlo Ersek
3 siblings, 0 replies; 9+ messages in thread
From: Laszlo Ersek @ 2019-02-21 19:42 UTC (permalink / raw)
To: edk2-devel; +Cc: Jordan Justen, Michael D Kinney, Anthony Perard
On 02/21/19 13:28, Laszlo Ersek wrote:
> Previous version:
> [edk2] [PATCH] Maintainers: add TPM2 reviewers for OvmfPkg
> https://lists.01.org/pipermail/edk2-devel/2019-February/036495.html
>
> Patch #1 in v2 is an iteration of the above. Patch #2 in v2 is new.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (2):
> Maintainers: add TPM2 reviewers for OvmfPkg
> Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module
> reviewers
>
> Maintainers.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Pushed as commit range 98fc52c44eee..94e0dd1afe53.
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 9+ messages in thread