From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.106.54; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org Received: from cam-smtp0.cambridge.arm.com (unknown [217.140.106.54]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A3E3D211CCD5C for ; Thu, 21 Feb 2019 10:14:23 -0800 (PST) Received: from E107187.Arm.com (E107187.Arm.com [10.1.195.55]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id x1LIEKAh030386; Thu, 21 Feb 2019 18:14:21 GMT From: Sami Mujawar To: edk2-devel@lists.01.org Cc: alexei.fedorov@arm.com, leif.lindholm@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Date: Thu, 21 Feb 2019 18:14:12 +0000 Message-Id: <20190221181414.83136-5-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20190221181414.83136-1-sami.mujawar@arm.com> References: <20190221181414.83136-1-sami.mujawar@arm.com> Subject: [PATCH v1 4/6] DynamicTablesPkg: DGB2: Update DBG2_DEBUG_PORT_DDI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:14:25 -0000 The DBG2_DEBUG_PORT_DDI() macro supports adding only one Generic Base Address Register. Therefore, removed the superfluous parameter NumReg and updated the macro to use DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS which has a value 1. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c index 697cfc46abaedf34d30abf26e7ebb2b4d271822a..90380f48da017b257476ee63bcc1beae5efe1d65 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c @@ -97,14 +97,12 @@ typedef struct { /** A helper macro used for initializing the debug port device information structure. - @param [in] NumReg The number of generic address registers. @param [in] SubType The DBG Port SubType. @param [in] UartBase The UART port base address. @param [in] UartAddrLen The UART port address range length. @param [in] UartNameStr The UART port name string. **/ #define DBG2_DEBUG_PORT_DDI( \ - NumReg, \ SubType, \ UartBase, \ UartAddrLen, \ @@ -116,7 +114,7 @@ typedef struct { /* UINT16 Length */ \ sizeof (DBG2_DEBUG_DEVICE_INFORMATION), \ /* UINT8 NumberofGenericAddressRegisters */ \ - NumReg, \ + DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS, \ /* UINT16 NameSpaceStringLength */ \ DBG2_NAMESPACESTRING_FIELD_SIZE, \ /* UINT16 NameSpaceStringOffset */ \ @@ -164,7 +162,6 @@ DBG2_TABLE AcpiDbg2 = { * Debug port 1 */ DBG2_DEBUG_PORT_DDI ( - DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS, 0, // {Template}: Serial Port Subtype 0, // {Template}: Serial Port Base Address PL011_UART_LENGTH, -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'