* [PATCH edk2-platforms v1 1/4] Platform/ARM: Juno: Configuration Manager depex
2019-02-21 18:15 [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes Sami Mujawar
@ 2019-02-21 18:15 ` Sami Mujawar
2019-02-21 18:15 ` [PATCH edk2-platforms v1 2/4] Platform/ARM: FVP: " Sami Mujawar
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2019-02-21 18:15 UTC (permalink / raw)
To: edk2-devel
Cc: Sami Mujawar, ard.biesheuvel, leif.lindholm, michael.d.kinney,
alexei.fedorov, Matteo.Carlini, Stephanie.Hughes-Fitt, nd
The Configuration Manager needs to be loaded before
other Dynamic Tables Framework Modules.
Fix the DEPEX section for Configuration Manager Dxe to
remove incorrect dependency.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
index 1491653ab8fe4d44ce11bdf9116f187cc3edf817..a8ef27108237d5cdf20166cffe7a348ebb2b2b12 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
@@ -1,7 +1,7 @@
## @file
# Configuration Manager Dxe
#
-# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
+# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -83,4 +83,4 @@ [FixedPcd]
[Pcd]
[Depex]
- gEdkiiDynamicTableFactoryProtocolGuid
+ TRUE
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH edk2-platforms v1 2/4] Platform/ARM: FVP: Configuration Manager depex
2019-02-21 18:15 [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes Sami Mujawar
2019-02-21 18:15 ` [PATCH edk2-platforms v1 1/4] Platform/ARM: Juno: Configuration Manager depex Sami Mujawar
@ 2019-02-21 18:15 ` Sami Mujawar
2019-02-21 18:15 ` [PATCH edk2-platforms v1 3/4] Platform/ARM: FVP: Config Mgr remove GICD ID Sami Mujawar
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2019-02-21 18:15 UTC (permalink / raw)
To: edk2-devel
Cc: Sami Mujawar, ard.biesheuvel, leif.lindholm, michael.d.kinney,
alexei.fedorov, Matteo.Carlini, Stephanie.Hughes-Fitt, nd
The Configuration Manager needs to be loaded before
other Dynamic Tables Framework Modules.
Fix the DEPEX section for Configuration Manager Dxe to
remove incorrect dependency.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
index c4c8f462b8fa8ea718589f2265ae42953ac0a49a..299c61f10f6fe41060d648a6fadcc63c310108a9 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
@@ -1,7 +1,7 @@
## @file
# Configuration Manager Dxe
#
-# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
+# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -76,4 +76,4 @@ [FixedPcd]
[Pcd]
[Depex]
- gEdkiiDynamicTableFactoryProtocolGuid
+ TRUE
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH edk2-platforms v1 3/4] Platform/ARM: FVP: Config Mgr remove GICD ID
2019-02-21 18:15 [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes Sami Mujawar
2019-02-21 18:15 ` [PATCH edk2-platforms v1 1/4] Platform/ARM: Juno: Configuration Manager depex Sami Mujawar
2019-02-21 18:15 ` [PATCH edk2-platforms v1 2/4] Platform/ARM: FVP: " Sami Mujawar
@ 2019-02-21 18:15 ` Sami Mujawar
2019-02-21 18:15 ` [PATCH edk2-platforms v1 4/4] Platform/ARM: Juno: " Sami Mujawar
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2019-02-21 18:15 UTC (permalink / raw)
To: edk2-devel
Cc: Sami Mujawar, ard.biesheuvel, leif.lindholm, michael.d.kinney,
alexei.fedorov, Matteo.Carlini, Stephanie.Hughes-Fitt, nd
According to ACPI 6.2 Specification - Errata A, 'One,
and only one, GIC distributor structure must be present
in the MADT for an ARM based system'. Accordingly the
CM_ARM_GICD_INFO structure has been updated to remove
the GicId field as this value is set to zero by the
MADT generator.
This update reflects the corresponding change required
to the Configuration Manager.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 66ee79341dfeceff1dc70c32b308056d87b99540..cdde32f6b43e876d8869941b4a11b0da8c72224e 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -116,7 +116,6 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
// GIC Distributor Info
{
- 0, // UINT32 GicId
FixedPcdGet64 (PcdGicDistributorBase), // UINT64 PhysicalBaseAddress
0, // UINT32 SystemVectorBase
3 // UINT8 GicVersion
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH edk2-platforms v1 4/4] Platform/ARM: Juno: Config Mgr remove GICD ID
2019-02-21 18:15 [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes Sami Mujawar
` (2 preceding siblings ...)
2019-02-21 18:15 ` [PATCH edk2-platforms v1 3/4] Platform/ARM: FVP: Config Mgr remove GICD ID Sami Mujawar
@ 2019-02-21 18:15 ` Sami Mujawar
2019-02-25 17:18 ` [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes Sami Mujawar
2019-03-26 19:12 ` Leif Lindholm
5 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2019-02-21 18:15 UTC (permalink / raw)
To: edk2-devel
Cc: Sami Mujawar, ard.biesheuvel, leif.lindholm, michael.d.kinney,
alexei.fedorov, Matteo.Carlini, Stephanie.Hughes-Fitt, nd
According to ACPI 6.2 Specification - Errata A, 'One,
and only one, GIC distributor structure must be present
in the MADT for an ARM based system'. Accordingly the
CM_ARM_GICD_INFO structure has been updated to remove
the GicId field as this value is set to zero by the
MADT generator.
This update reflects the corresponding change required
to the Configuration Manager.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 55f0984ee6741f5434dd1ec673281c78e2a576f2..444c1d95af27d938da76e00e41756b800b977589 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -145,7 +145,6 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
// GIC Distributor Info
{
- 0, // UINT32 GicId
FixedPcdGet64 (PcdGicDistributorBase), // UINT64 PhysicalBaseAddress
0, // UINT32 SystemVectorBase
2 // UINT8 GicVersion
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes
2019-02-21 18:15 [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes Sami Mujawar
` (3 preceding siblings ...)
2019-02-21 18:15 ` [PATCH edk2-platforms v1 4/4] Platform/ARM: Juno: " Sami Mujawar
@ 2019-02-25 17:18 ` Sami Mujawar
2019-03-26 19:12 ` Leif Lindholm
5 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2019-02-25 17:18 UTC (permalink / raw)
To: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org
Cc: Sami Mujawar, edk2-devel@lists.01.org, michael.d.kinney@intel.com,
Alexei Fedorov, Matteo Carlini, Stephanie Hughes-Fitt, nd
Hi Leif, Ard,
I have pushed the Dynamic Tables Framework changes to tianocore\edk2.
You should now be able to build the edk2-platform patches for dynamic tables with latest edk2 master.
Regards,
Sami Mujawar
-----Original Message-----
From: Sami Mujawar <sami.mujawar@arm.com>
Sent: 21 February 2019 06:15 PM
To: edk2-devel@lists.01.org
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; michael.d.kinney@intel.com; Alexei Fedorov <Alexei.Fedorov@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
Subject: [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes
The Dynamic tables framework has been updated to incorporated a series of updates namely:
* Resolving DEPEX order for modules.
* Removing GIC Distributor ID
This patch series implement the corresponding changes required in the platform Configuration Manager.
Note: This patch series is dependent on the patch series:
https://lists.01.org/pipermail/edk2-devel/2019-January/035611.html
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/473_dynamic_tables_framework_v1
The corresponding edk2 code changes can be seen at:
https://github.com/samimujawar/edk2/tree/473_dynamic_tables_framework_v1
Sami Mujawar (4):
Platform/ARM: Juno: Configuration Manager depex
Platform/ARM: FVP: Configuration Manager depex
Platform/ARM: FVP: Config Mgr remove GICD ID
Platform/ARM: Juno: Config Mgr remove GICD ID
Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 1 -
Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 4 ++--
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 1 -
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 4 ++--
4 files changed, 4 insertions(+), 6 deletions(-)
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes
2019-02-21 18:15 [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes Sami Mujawar
` (4 preceding siblings ...)
2019-02-25 17:18 ` [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes Sami Mujawar
@ 2019-03-26 19:12 ` Leif Lindholm
5 siblings, 0 replies; 7+ messages in thread
From: Leif Lindholm @ 2019-03-26 19:12 UTC (permalink / raw)
To: Sami Mujawar
Cc: edk2-devel, ard.biesheuvel, michael.d.kinney, alexei.fedorov,
Matteo.Carlini, Stephanie.Hughes-Fitt, nd
On Thu, Feb 21, 2019 at 06:15:21PM +0000, Sami Mujawar wrote:
> The Dynamic tables framework has been updated to incorporated a series of
> updates namely:
> * Resolving DEPEX order for modules.
> * Removing GIC Distributor ID
>
> This patch series implement the corresponding changes required in the platform
> Configuration Manager.
>
> Note: This patch series is dependent on the patch series:
> https://lists.01.org/pipermail/edk2-devel/2019-January/035611.html
Ah, right, so these changes will have to be pushed simultaneously with
the edk2 ones. In that case:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
And feel free to push the changes to edk2-platforms for this set yourself.
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/473_dynamic_tables_framework_v1
>
> The corresponding edk2 code changes can be seen at:
> https://github.com/samimujawar/edk2/tree/473_dynamic_tables_framework_v1
>
> Sami Mujawar (4):
> Platform/ARM: Juno: Configuration Manager depex
> Platform/ARM: FVP: Configuration Manager depex
> Platform/ARM: FVP: Config Mgr remove GICD ID
> Platform/ARM: Juno: Config Mgr remove GICD ID
>
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 1 -
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 4 ++--
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 1 -
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 4 ++--
> 4 files changed, 4 insertions(+), 6 deletions(-)
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread