From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.106.55; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org Received: from cam-smtp0.cambridge.arm.com (unknown [217.140.106.55]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 64C262194EB70 for ; Thu, 21 Feb 2019 10:15:41 -0800 (PST) Received: from E107187.Arm.com (E107187.Arm.com [10.1.195.55]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id x1LIFUGL030711; Thu, 21 Feb 2019 18:15:32 GMT From: Sami Mujawar To: edk2-devel@lists.01.org Cc: Sami Mujawar , ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, michael.d.kinney@intel.com, alexei.fedorov@arm.com, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Date: Thu, 21 Feb 2019 18:15:25 +0000 Message-Id: <20190221181525.49624-5-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20190221181525.49624-1-sami.mujawar@arm.com> References: <20190221181525.49624-1-sami.mujawar@arm.com> Subject: [PATCH edk2-platforms v1 4/4] Platform/ARM: Juno: Config Mgr remove GICD ID X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 X-List-Received-Date: Thu, 21 Feb 2019 18:15:41 -0000 According to ACPI 6.2 Specification - Errata A, 'One, and only one, GIC distributor structure must be present in the MADT for an ARM based system'. Accordingly the CM_ARM_GICD_INFO structure has been updated to remove the GicId field as this value is set to zero by the MADT generator. This update reflects the corresponding change required to the Configuration Manager. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar --- Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c index 55f0984ee6741f5434dd1ec673281c78e2a576f2..444c1d95af27d938da76e00e41756b800b977589 100644 --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c @@ -145,7 +145,6 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = { // GIC Distributor Info { - 0, // UINT32 GicId FixedPcdGet64 (PcdGicDistributorBase), // UINT64 PhysicalBaseAddress 0, // UINT32 SystemVectorBase 2 // UINT8 GicVersion -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'