* [Patch V2] BaseTools: Add parameter check for the AsciiStringToUint64
@ 2019-02-23 9:41 Feng, Bob C
2019-02-23 14:20 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Feng, Bob C @ 2019-02-23 9:41 UTC (permalink / raw)
To: edk2-devel; +Cc: Bob Feng, Liming Gao
If the input parameter AsciiString length is greater
than 255, the GenFv will hang.
This patch is to fix this issue.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
BaseTools/Source/C/Common/ParseInf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/C/Common/ParseInf.c b/BaseTools/Source/C/Common/ParseInf.c
index 3907f44331..c5d79c89fa 100644
--- a/BaseTools/Source/C/Common/ParseInf.c
+++ b/BaseTools/Source/C/Common/ParseInf.c
@@ -506,11 +506,11 @@ Returns:
Index = 0;
//
// Check input parameter
//
- if (AsciiString == NULL || ReturnValue == NULL) {
+ if (AsciiString == NULL || ReturnValue == NULL || strlen(AsciiString) > 0xFF) {
return EFI_INVALID_PARAMETER;
}
while (AsciiString[Index] == ' ') {
Index ++;
}
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Patch V2] BaseTools: Add parameter check for the AsciiStringToUint64
2019-02-23 9:41 [Patch V2] BaseTools: Add parameter check for the AsciiStringToUint64 Feng, Bob C
@ 2019-02-23 14:20 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2019-02-23 14:20 UTC (permalink / raw)
To: Feng, Bob C, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Feng, Bob C
> Sent: Saturday, February 23, 2019 5:42 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch V2] BaseTools: Add parameter check for the AsciiStringToUint64
>
> If the input parameter AsciiString length is greater
> than 255, the GenFv will hang.
>
> This patch is to fix this issue.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/C/Common/ParseInf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/C/Common/ParseInf.c b/BaseTools/Source/C/Common/ParseInf.c
> index 3907f44331..c5d79c89fa 100644
> --- a/BaseTools/Source/C/Common/ParseInf.c
> +++ b/BaseTools/Source/C/Common/ParseInf.c
> @@ -506,11 +506,11 @@ Returns:
> Index = 0;
>
> //
> // Check input parameter
> //
> - if (AsciiString == NULL || ReturnValue == NULL) {
> + if (AsciiString == NULL || ReturnValue == NULL || strlen(AsciiString) > 0xFF) {
> return EFI_INVALID_PARAMETER;
> }
> while (AsciiString[Index] == ' ') {
> Index ++;
> }
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-23 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-23 9:41 [Patch V2] BaseTools: Add parameter check for the AsciiStringToUint64 Feng, Bob C
2019-02-23 14:20 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox