From: Sami Mujawar <sami.mujawar@arm.com>
To: edk2-devel@lists.01.org
Cc: lersek@redhat.com, alexei.fedorov@arm.com,
leif.lindholm@linaro.org, Matteo.Carlini@arm.com,
Stephanie.Hughes-Fitt@arm.com, nd@arm.com
Subject: [PATCH v1 2/6] Revert "DynamicTablesPkg: Remove GIC Distributor Id field"
Date: Tue, 26 Feb 2019 08:44:19 +0000 [thread overview]
Message-ID: <20190226084423.14024-3-sami.mujawar@arm.com> (raw)
In-Reply-To: <20190226084423.14024-1-sami.mujawar@arm.com>
This reverts commit d3a15f435f9716aa2f2ea5e9b35fcda04f267ab4.
Reverting this patch as Soft Feature Freeze for
edk2-stable201903 started on 22 Feb 2019.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Alexei Fedorov <alexei.fedorov@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 5 ++++-
DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 4 +---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
index 73139eb3273e89205ef9e6bee67b1b842f7f516b..2adaa788083e4e15d049f5f6b6312f77f3c02488 100644
--- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
+++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
@@ -1,6 +1,6 @@
/** @file
- Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
+ Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -166,6 +166,9 @@ typedef struct CmArmGicCInfo {
GIC Distributor information for the Platform.
*/
typedef struct CmArmGicDInfo {
+ /// The GIC Distributor ID.
+ UINT32 GicId;
+
/// The Physical Base address for the GIC Distributor.
UINT64 PhysicalBaseAddress;
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c
index 6b89c3f65d36ff35fcfc81cdffdeae8e4306c976..1ee0b9e006bfa00ea5bbf6aa64209dac244c90a0 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c
@@ -192,9 +192,7 @@ AddGICD (
// UINT16 Reserved
Gicd->Reserved1 = EFI_ACPI_RESERVED_WORD;
// UINT32 Identifier
- // One, and only one, GIC distributor structure must be present
- // in the MADT for an ARM based system
- Gicd->GicId = 0;
+ Gicd->GicId = GicDInfo->GicId;
// UINT64 PhysicalBaseAddress
Gicd->PhysicalBaseAddress = GicDInfo->PhysicalBaseAddress;
// UINT32 VectorBase
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2019-02-26 8:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 8:44 [PATCH v1 0/6] Revert DynamicTablesPkg: Framework updates and fixes Sami Mujawar
2019-02-26 8:44 ` [PATCH v1 1/6] Revert "DynamicTablesPkg: Minor updates and fix typos" Sami Mujawar
2019-02-26 8:44 ` Sami Mujawar [this message]
2019-02-26 8:44 ` [PATCH v1 3/6] Revert "DynamicTablesPkg: DGB2: Update DBG2_DEBUG_PORT_DDI" Sami Mujawar
2019-02-26 8:44 ` [PATCH v1 4/6] Revert "DynamicTablesPkg: Add OEM Info" Sami Mujawar
2019-02-26 8:44 ` [PATCH v1 5/6] Revert "DynamicTablesPkg: Rename enum used for ID Mapping" Sami Mujawar
2019-02-26 8:44 ` [PATCH v1 6/6] Revert "DynamicTablesPkg: Fix protocol section" Sami Mujawar
2019-02-26 10:26 ` [PATCH v1 0/6] Revert DynamicTablesPkg: Framework updates and fixes Alexei Fedorov
2019-02-26 11:01 ` Laszlo Ersek
2019-02-26 11:05 ` Laszlo Ersek
2019-02-27 13:44 ` Sami Mujawar
2019-02-27 19:55 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226084423.14024-3-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox