From: Sami Mujawar <sami.mujawar@arm.com>
To: edk2-devel@lists.01.org
Cc: lersek@redhat.com, alexei.fedorov@arm.com,
leif.lindholm@linaro.org, Matteo.Carlini@arm.com,
Stephanie.Hughes-Fitt@arm.com, nd@arm.com
Subject: [PATCH v1 3/6] Revert "DynamicTablesPkg: DGB2: Update DBG2_DEBUG_PORT_DDI"
Date: Tue, 26 Feb 2019 08:44:20 +0000 [thread overview]
Message-ID: <20190226084423.14024-4-sami.mujawar@arm.com> (raw)
In-Reply-To: <20190226084423.14024-1-sami.mujawar@arm.com>
This reverts commit 6814256083a90ef218e7ae240e51922045175df1.
Reverting this patch as Soft Feature Freeze for
edk2-stable201903 started on 22 Feb 2019.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Alexei Fedorov <alexei.fedorov@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
index 90380f48da017b257476ee63bcc1beae5efe1d65..697cfc46abaedf34d30abf26e7ebb2b4d271822a 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
@@ -97,12 +97,14 @@ typedef struct {
/** A helper macro used for initializing the debug port device
information structure.
+ @param [in] NumReg The number of generic address registers.
@param [in] SubType The DBG Port SubType.
@param [in] UartBase The UART port base address.
@param [in] UartAddrLen The UART port address range length.
@param [in] UartNameStr The UART port name string.
**/
#define DBG2_DEBUG_PORT_DDI( \
+ NumReg, \
SubType, \
UartBase, \
UartAddrLen, \
@@ -114,7 +116,7 @@ typedef struct {
/* UINT16 Length */ \
sizeof (DBG2_DEBUG_DEVICE_INFORMATION), \
/* UINT8 NumberofGenericAddressRegisters */ \
- DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS, \
+ NumReg, \
/* UINT16 NameSpaceStringLength */ \
DBG2_NAMESPACESTRING_FIELD_SIZE, \
/* UINT16 NameSpaceStringOffset */ \
@@ -162,6 +164,7 @@ DBG2_TABLE AcpiDbg2 = {
* Debug port 1
*/
DBG2_DEBUG_PORT_DDI (
+ DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS,
0, // {Template}: Serial Port Subtype
0, // {Template}: Serial Port Base Address
PL011_UART_LENGTH,
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2019-02-26 8:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 8:44 [PATCH v1 0/6] Revert DynamicTablesPkg: Framework updates and fixes Sami Mujawar
2019-02-26 8:44 ` [PATCH v1 1/6] Revert "DynamicTablesPkg: Minor updates and fix typos" Sami Mujawar
2019-02-26 8:44 ` [PATCH v1 2/6] Revert "DynamicTablesPkg: Remove GIC Distributor Id field" Sami Mujawar
2019-02-26 8:44 ` Sami Mujawar [this message]
2019-02-26 8:44 ` [PATCH v1 4/6] Revert "DynamicTablesPkg: Add OEM Info" Sami Mujawar
2019-02-26 8:44 ` [PATCH v1 5/6] Revert "DynamicTablesPkg: Rename enum used for ID Mapping" Sami Mujawar
2019-02-26 8:44 ` [PATCH v1 6/6] Revert "DynamicTablesPkg: Fix protocol section" Sami Mujawar
2019-02-26 10:26 ` [PATCH v1 0/6] Revert DynamicTablesPkg: Framework updates and fixes Alexei Fedorov
2019-02-26 11:01 ` Laszlo Ersek
2019-02-26 11:05 ` Laszlo Ersek
2019-02-27 13:44 ` Sami Mujawar
2019-02-27 19:55 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226084423.14024-4-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox