From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::333; helo=mail-wm1-x333.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82858211CD9D9 for ; Wed, 27 Feb 2019 00:59:14 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id y15so4779819wma.0 for ; Wed, 27 Feb 2019 00:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vMkwoiCjBijcl9xgVmii0VUqEGdWHo69vu0NulaORJg=; b=D3jjCD1AGn9jfHJnmHXEXAGP/bsihIdvhPvPsGCU3FPWNUle1VmU1cPl7nCI+Sr4ml /prLbZHRhYJt6egUL+/zXTJkKhBXypy3/vPU7W/V4bN2hxyhU0pU4XJRYoDJhu/eWDgh R2sctnhZUIpRCTSWcrRS0B6+Rt3KFhq/as0lRs/Swdx8LF89IQBS6d6TYA69vg2HUCtM 7QFAVqBNEWNGNne9AKaLjqT5NMs2r5epLZxIe+e9Ngcf3mCLpgebYEjp1eF/7AR7Kehl 3O9k4enxxq0PG0oowPw/rXkxdgULhI+VX53zOER1B6aCFmRqehP0AgyXy+seLfUDxyhp JX8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vMkwoiCjBijcl9xgVmii0VUqEGdWHo69vu0NulaORJg=; b=W+Lwpgjdz+ckuTX9EXTlzH2p14ExbnqTHhHcY/CuQoI5yXMohzGG9N24quR5nTrc9Q u8JCQyVyBVqt2U+2a07Vu8c8DDUfH3YUcUPwNjcyaNLej5ePNeaBdEI1O5Od//3UkgmP ADNQlNmOA1hsAgR9AUWw5sj8WG3mBC3ZWsI2WkZjcKyX6OAkBf5HEAI6GtFQnEviJdWB XO4oDUNGnZP4ZPGEfmqoQCMIzplhYE/Q/s7z6dev2SOOxlgDu7lSSetydqTRdrIo7lyH df78ZuJ7rlGQ2mHs/hSxtJWU+d4fF2y4GklTN4jjQUhQSBj3hatNxo6b6x2T6Ym7sMWr 3ocw== X-Gm-Message-State: APjAAAWRb92ppAmBGDnS3MvAyJEtkjVBpj4lQ34KadnVHRhk4zMOBQ8H ptmmKIXnLkGiuH7tF/nFrTjbww== X-Google-Smtp-Source: APXvYqxi87Z7XrSJb/Dxhmo7sFutiC/54NLxRKjOG8Me2DqiyQvhLBb427JHuMUYfS6Ca8yi0NS+kg== X-Received: by 2002:a7b:cc93:: with SMTP id p19mr1501902wma.113.1551257952567; Wed, 27 Feb 2019 00:59:12 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a22sm1035553wmj.35.2019.02.27.00.59.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 00:59:11 -0800 (PST) Date: Wed, 27 Feb 2019 08:59:10 +0000 From: Leif Lindholm To: "Feng, Bob C" Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , "Gao, Liming" Message-ID: <20190227085910.jr4hqzku2hkrrqwf@bivouac.eciton.net> References: <20190226010519.17740-1-bob.c.feng@intel.com> <20190227082600.7g6m6a6uwmp4sfuj@bivouac.eciton.net> <08650203BA1BD64D8AD9B6D5D74A85D1600901EC@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D1600901EC@SHSMSX101.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [Patch] BaseTools: Add python3-distutils Ubuntu package checking X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 08:59:14 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 27, 2019 at 08:52:08AM +0000, Feng, Bob C wrote: > Thanks for comments. I think the print message is not good. It's based on Ubutun OS. It's not right. > > I think the import error need to be caught and then print some > messages, otherwise the build tool will break and print the call > stack which is not friendly to user. I agree printing the call stack is not useful for import errors. Is there no way to suppress that for basic environment issues? Surely a "failed to import..." message would also be printed? Regards, Leif > Thanks, > Bob > > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Wednesday, February 27, 2019 4:26 PM > To: Feng, Bob C > Cc: Ard Biesheuvel ; edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking > > On Wed, Feb 27, 2019 at 09:07:49AM +0100, Ard Biesheuvel wrote: > > On Tue, 26 Feb 2019 at 02:05, Feng, Bob C wrote: > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > > > > > > Add python3-distutils Ubuntu package checking. > > > > > > > Hi Bob, > > > > This assumes that all Linux systems are Ubuntu based, which is not > > true. The apt tool is specific to Debian/Ubuntu, Fedora/Redhat and > > Suse all use something else. > > > > In general, I don't think we should validate the Python environment to > > this extent, since we cannot fix the problem for the user anyway, only > > flag it, and since python explodes rather loudly in this case, I think > > we should be able to leave it up to developers that are savvy enough > > to build EDK2 to also find the python distutils package for their > > platform. > > > > Note that that doesn't mean we shouldn't document this, and not just > > for Ubuntu. But I think putting it in the script is overkill. > > Yes, I agree > > It is also worth noting that python3-distutils is the current debian/ubuntu package name. So if we *do* print a message... > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Bob Feng > > > Cc: Liming Gao > > > --- > > > BaseTools/Tests/RunTests.py | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/BaseTools/Tests/RunTests.py > > > b/BaseTools/Tests/RunTests.py index 0dd65632d0..64778db981 100644 > > > --- a/BaseTools/Tests/RunTests.py > > > +++ b/BaseTools/Tests/RunTests.py > > > @@ -17,10 +17,24 @@ > > > # > > > import os > > > import sys > > > import unittest > > > > > > +distutils_exist = True > > > +try: > > > + import distutils.util > > > +except: > > > + distutils_exist = False > > > + > > > +if not distutils_exist: > > > + print(""" > > > +python3-distutil packages is missing. Please install it with the following command: > > ... printing "missing python distutils package" and possibly python version would be more reliable. > > But as Ard points out - this is effectively what python itself will say. > > / > Leif > > > > + > > > +bash$ sudo apt-get install python3-distutil > > > +""") > > > + sys.exit(-1) > > > + > > > import TestTools > > > > > > def GetCTestSuite(): > > > import CToolsTests > > > return CToolsTests.TheTestSuite() > > > -- > > > 2.20.1.windows.1 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel