public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Feng, Bob C" <bob.c.feng@intel.com>
To: edk2-devel@lists.01.org
Cc: Bob Feng <bob.c.feng@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: [Patch] Document: Update Dsc spec to all empty value for HIIPcd
Date: Thu, 28 Feb 2019 10:11:17 +0800	[thread overview]
Message-ID: <20190228021117.21740-1-bob.c.feng@intel.com> (raw)

https://bugzilla.tianocore.org/show_bug.cgi?id=1466

Update Dsc spec to all empty value for HIIPcd.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 2_dsc_overview/29_pcd_sections.md            | 4 ++--
 3_edk_ii_dsc_file_format/310_pcd_sections.md | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/2_dsc_overview/29_pcd_sections.md b/2_dsc_overview/29_pcd_sections.md
index 791125f..d84d2f4 100644
--- a/2_dsc_overview/29_pcd_sections.md
+++ b/2_dsc_overview/29_pcd_sections.md
@@ -230,11 +230,11 @@ example:
 `[PcdsDynamicHii.common.Sku1]`
 
 While the format for content of this section is as follows, note that the
 backslash character is used here to indicate the continuation of the line:
 
-`PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffset[|HiiDefaultValue[|HiiAttrubte]]`
+`PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffset[|[HiiDefaultValue][|HiiAttrubte]]`
 
 For VOID* PCDs, the HiiDefaultValue will be a pointer; specifying the optional
 HiiDefaultValue has no meaning.
 
 The optional HII Attribute entry is a comma separated list of attributes as
@@ -340,11 +340,11 @@ Specifying a `SKUID` for an HII PCD selection is optional, for example:
 `[PcdsDynamicExHii.common.Sku1]`
 
 While the format for content of this section is as follows, note that the
 backslash character is used here to indicate the continuation of the line:
 
-`PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffset[|HiiDefaultValue]`
+`PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffset[|[HiiDefaultValue]]`
 
 The optional HII Attribute entry is a comma separated list of attributes as
 described in Table 9 HII Attributes.
 
 **Note:** The VariableName field in the HII format PCD entry must not be an empty string.
diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md b/3_edk_ii_dsc_file_format/310_pcd_sections.md
index f9f1359..f982d60 100644
--- a/3_edk_ii_dsc_file_format/310_pcd_sections.md
+++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md
@@ -503,11 +503,11 @@ sections of the DSC file.
 <VpdMaxSize>     ::= {<IntNum>} {<UINT16>} [<FS> <StringValue>]
 <HiiEntry>       ::= <PcdName> <FS> <HiiString> <Field2> <EOL>
 <HiiString>      ::= {<CArray>} {<UnicodeString>}
 <Field2>         ::= <FS> <VariableGuid> <FS> <VariableOffset> [<ValueField>]
 <VariableGuid>   ::= <CName>
-<ValueField>     ::= <FS> <DefaultValue> [<FS> <HiiAttrs>]
+<ValueField>     ::= <FS> [<DefaultValue>] [<FS> <HiiAttrs>]
 <VariableOffset> ::= <Number>
 <DefaultValue>   ::= if (pcddatumtype == "BOOLEAN"):
                        {<BoolType>} {<Expression>}
                      elif (pcddatumtype == "UINT8"):
                        {<NumValUint8>} {<Expression>}
@@ -721,11 +721,11 @@ sections of the DSC file.
 <VpdMaxSize>     ::= {<LongNum>} {<UINT32>} [<FS> <StringValue>]
 <HiiEntry>       ::= <PcdName> <FS> <HiiString> <Field2> <EOL>
 <HiiString>      ::= {<CArray>} {<UnicodeString>}
 <Field2>         ::= <FS> <VariableGuid> <FS> <VariableOffset> [<ValueField>]
 <VariableGuid>   ::= <CName>
-<ValueField>     ::= <FS> <DefaultValue> [<FS> <HiiAttrs>]
+<ValueField>     ::= <FS> [<DefaultValue>] [<FS> <HiiAttrs>]
 <VariableOffset> ::= <Number>
 <DefaultValue>   ::= if (pcddatumtype == "BOOLEAN"):
                        {<BoolType>} {<Expression>}
                      elif (pcddatumtype == "UINT8"):
                        {<NumValUint8>} {<Expression>}
-- 
2.20.1.windows.1



             reply	other threads:[~2019-02-28  2:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28  2:11 Feng, Bob C [this message]
2019-02-28 15:45 ` [Patch] Document: Update Dsc spec to all empty value for HIIPcd Carsey, Jaben
2019-03-01  2:58 ` Feng, Bob C
2019-03-01  3:00 ` Feng, Bob C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190228021117.21740-1-bob.c.feng@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox