* [Patch] Document: Update the INF spec about [Depex] section
@ 2019-02-28 2:11 Feng, Bob C
2019-02-28 15:39 ` Felix Polyudov
2019-02-28 15:45 ` Carsey, Jaben
0 siblings, 2 replies; 3+ messages in thread
From: Feng, Bob C @ 2019-02-28 2:11 UTC (permalink / raw)
To: edk2-devel; +Cc: Bob Feng, Liming Gao
<GuidOrPcdStmt> ::= {"BEFORE"} {"AFTER"} <GuidOrPcdName> should be
<GuidOrPcdStmt> ::= [{"BEFORE"} {"AFTER"}]<GuidOrPcdName>
The "BEFORE" or "AFTER" is optional key words in current implementation.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
3_edk_ii_inf_file_format/314_[depex]_sections.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/3_edk_ii_inf_file_format/314_[depex]_sections.md b/3_edk_ii_inf_file_format/314_[depex]_sections.md
index 942bcf9..3c0820a 100644
--- a/3_edk_ii_inf_file_format/314_[depex]_sections.md
+++ b/3_edk_ii_inf_file_format/314_[depex]_sections.md
@@ -179,11 +179,11 @@ and VOID* datum type, and the size of the PCD must be 16 bytes.
<DxeDepexStatements> ::= {<SorStmt>} {<GuidOrPcdStmt>} {<BoolStmt>}
<PeiDepex> ::= <PeiDepexStatements>*
["END" <EOL>]
<PeiDepexStatements> ::= {<BoolStmt>} {<DepInstruct>}
<SmmDepex> ::= <DxeDepex>
-<GuidOrPcdStmt> ::= {"BEFORE"} {"AFTER"} <GuidOrPcdName> [<EOL>]
+<GuidOrPcdStmt> ::= [{"BEFORE"} {"AFTER"}] <GuidOrPcdName> [<EOL>]
<GuidOrPcdName> ::= {<GuidCName>} {<PcdName>}
<DepInstruct> ::= "PUSH" <CFormatGUID> [<EOL>]
<SorStmt> ::= "SOR" <BoolStmt> [<EOL>]
<BoolStmt> ::= {<Bool>} {<BoolExpress>}
<Bool> ::= {"TRUE"} {"FALSE"} {<GuidCName>} {<PcdName>} [<EOL>]
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch] Document: Update the INF spec about [Depex] section
2019-02-28 2:11 [Patch] Document: Update the INF spec about [Depex] section Feng, Bob C
@ 2019-02-28 15:39 ` Felix Polyudov
2019-02-28 15:45 ` Carsey, Jaben
1 sibling, 0 replies; 3+ messages in thread
From: Felix Polyudov @ 2019-02-28 15:39 UTC (permalink / raw)
To: 'Feng, Bob C', edk2-devel@lists.01.org; +Cc: Liming Gao
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Feng, Bob C
> Sent: Wednesday, February 27, 2019 9:12 PM
> To: edk2-devel@lists.01.org
> Cc: Liming Gao
> Subject: [edk2] [Patch] Document: Update the INF spec about [Depex] section
>
> <GuidOrPcdStmt> ::= {"BEFORE"} {"AFTER"} <GuidOrPcdName> should be
> <GuidOrPcdStmt> ::= [{"BEFORE"} {"AFTER"}]<GuidOrPcdName>
>
> The "BEFORE" or "AFTER" is optional key words in current implementation.
The proposed definition implies that BEFORE and AFTER can be used at the same time, which is incorrect.
I think it should be
<GuidOrPcdStmt> ::= [{"BEFORE"} |{"AFTER"}]<GuidOrPcdName>
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> 3_edk_ii_inf_file_format/314_[depex]_sections.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/3_edk_ii_inf_file_format/314_[depex]_sections.md b/3_edk_ii_inf_file_format/314_[depex]_sections.md
> index 942bcf9..3c0820a 100644
> --- a/3_edk_ii_inf_file_format/314_[depex]_sections.md
> +++ b/3_edk_ii_inf_file_format/314_[depex]_sections.md
> @@ -179,11 +179,11 @@ and VOID* datum type, and the size of the PCD must be 16 bytes.
> <DxeDepexStatements> ::= {<SorStmt>} {<GuidOrPcdStmt>} {<BoolStmt>}
> <PeiDepex> ::= <PeiDepexStatements>*
> ["END" <EOL>]
> <PeiDepexStatements> ::= {<BoolStmt>} {<DepInstruct>}
> <SmmDepex> ::= <DxeDepex>
> -<GuidOrPcdStmt> ::= {"BEFORE"} {"AFTER"} <GuidOrPcdName> [<EOL>]
> +<GuidOrPcdStmt> ::= [{"BEFORE"} {"AFTER"}] <GuidOrPcdName> [<EOL>]
> <GuidOrPcdName> ::= {<GuidCName>} {<PcdName>}
> <DepInstruct> ::= "PUSH" <CFormatGUID> [<EOL>]
> <SorStmt> ::= "SOR" <BoolStmt> [<EOL>]
> <BoolStmt> ::= {<Bool>} {<BoolExpress>}
> <Bool> ::= {"TRUE"} {"FALSE"} {<GuidCName>} {<PcdName>} [<EOL>]
> --
> 2.20.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends, Inc. This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Patch] Document: Update the INF spec about [Depex] section
2019-02-28 2:11 [Patch] Document: Update the INF spec about [Depex] section Feng, Bob C
2019-02-28 15:39 ` Felix Polyudov
@ 2019-02-28 15:45 ` Carsey, Jaben
1 sibling, 0 replies; 3+ messages in thread
From: Carsey, Jaben @ 2019-02-28 15:45 UTC (permalink / raw)
To: Feng, Bob C, edk2-devel@lists.01.org; +Cc: Gao, Liming
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Wednesday, February 27, 2019 6:12 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] Document: Update the INF spec about [Depex]
> section
>
> <GuidOrPcdStmt> ::= {"BEFORE"} {"AFTER"} <GuidOrPcdName> should be
> <GuidOrPcdStmt> ::= [{"BEFORE"} {"AFTER"}]<GuidOrPcdName>
>
> The "BEFORE" or "AFTER" is optional key words in current implementation.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> 3_edk_ii_inf_file_format/314_[depex]_sections.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/3_edk_ii_inf_file_format/314_[depex]_sections.md
> b/3_edk_ii_inf_file_format/314_[depex]_sections.md
> index 942bcf9..3c0820a 100644
> --- a/3_edk_ii_inf_file_format/314_[depex]_sections.md
> +++ b/3_edk_ii_inf_file_format/314_[depex]_sections.md
> @@ -179,11 +179,11 @@ and VOID* datum type, and the size of the PCD
> must be 16 bytes.
> <DxeDepexStatements> ::= {<SorStmt>} {<GuidOrPcdStmt>} {<BoolStmt>}
> <PeiDepex> ::= <PeiDepexStatements>*
> ["END" <EOL>]
> <PeiDepexStatements> ::= {<BoolStmt>} {<DepInstruct>}
> <SmmDepex> ::= <DxeDepex>
> -<GuidOrPcdStmt> ::= {"BEFORE"} {"AFTER"} <GuidOrPcdName> [<EOL>]
> +<GuidOrPcdStmt> ::= [{"BEFORE"} {"AFTER"}] <GuidOrPcdName>
> [<EOL>]
> <GuidOrPcdName> ::= {<GuidCName>} {<PcdName>}
> <DepInstruct> ::= "PUSH" <CFormatGUID> [<EOL>]
> <SorStmt> ::= "SOR" <BoolStmt> [<EOL>]
> <BoolStmt> ::= {<Bool>} {<BoolExpress>}
> <Bool> ::= {"TRUE"} {"FALSE"} {<GuidCName>} {<PcdName>} [<EOL>]
> --
> 2.20.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-28 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-28 2:11 [Patch] Document: Update the INF spec about [Depex] section Feng, Bob C
2019-02-28 15:39 ` Felix Polyudov
2019-02-28 15:45 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox