[PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

[PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

[Hao Wu]

V2 changes:

On behalf of Eugene, V2 patch does not have functional changes compared
with V1, only the reference Bugzilla tracker link is added in the commit
log message.

I added the previous 'Ack' tag from Ard and Ashish, I added my
'Reviewed-by' as well.

Cc: Eugene Cohen <eugene@hp.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Ashish Singhal <ashishsingha@nvidia.com>

Cohen, Eugene (1):
  MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.12.0.windows.1

[PATCH v2 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

[Hao Wu]

From: "Cohen, Eugene" <eugene@hp.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1583

The SdMmcPciHcDriverBindingStart function was checking two different
capability bits in determining whether 64-bit DMA modes were supported,
one mode is defined in the SDHC version 3 specification (using 96-bit
descriptors) and another is defined in the SDHC version 4 specification
(using 128-bit descriptors).

Since the currently implementation of 64-bit ADMA2 only supports the SDHC
version 4 implementation, it is incorrect to check the V3 64-bit
capability bit since this will activate V4 ADMA2 on V3 controllers which
then causes buffers to be allocated that cannot be DMAed.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Ashish Singhal <ashishsingha@nvidia.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eugene Cohen <eugene@hp.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Ashish Singhal <ashishsingha@nvidia.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
---
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
index b474f8decd..5bc91c5337 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
@@ -666,8 +666,7 @@ SdMmcPciHcDriverBindingStart (
     // If any of the slots does not support 64b system bus
     // do not enable 64b DMA in the PCI layer.
     //
-    if (Private->Capability[Slot].SysBus64V3 == 0 &&
-        Private->Capability[Slot].SysBus64V4 == 0) {
+    if (Private->Capability[Slot].SysBus64V4 == 0) {
       Support64BitDma = FALSE;
     }
 
-- 
2.12.0.windows.1

Re: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

[Wu, Hao A]

> -----Original Message-----
> From: Wu, Hao A
> Sent: Tuesday, March 05, 2019 9:14 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Eugene Cohen; Ard Biesheuvel; Ashish Singhal
> Subject: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC
> v3 64-bit systems

Since Ashish already posted a patch to add the 64-bit System Address
support for V3 mode SDHC:
https://www.mail-archive.com/edk2-devel@lists.01.org/msg52057.html

I think this patch can be dropped.

But since Ashish's patch above is considered as a new feature addition, it
will be pushed (if passes the review process) after the 19`Q1 release tag.

So Eugene, Ard and Ashish, do you have concern on this?

Best Regards,
Hao Wu

> 
> V2 changes:
> 
> On behalf of Eugene, V2 patch does not have functional changes compared
> with V1, only the reference Bugzilla tracker link is added in the commit
> log message.
> 
> I added the previous 'Ack' tag from Ard and Ashish, I added my
> 'Reviewed-by' as well.
> 
> Cc: Eugene Cohen <eugene@hp.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Ashish Singhal <ashishsingha@nvidia.com>
> 
> Cohen, Eugene (1):
>   MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems
> 
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --
> 2.12.0.windows.1

Re: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

[Ard Biesheuvel]

On Tue, 5 Mar 2019 at 03:18, Wu, Hao A <hao.a.wu@intel.com> wrote:
>
> > -----Original Message-----
> > From: Wu, Hao A
> > Sent: Tuesday, March 05, 2019 9:14 AM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A; Eugene Cohen; Ard Biesheuvel; Ashish Singhal
> > Subject: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC
> > v3 64-bit systems
>
> Since Ashish already posted a patch to add the 64-bit System Address
> support for V3 mode SDHC:
> https://www.mail-archive.com/edk2-devel@lists.01.org/msg52057.html
>
> I think this patch can be dropped.
>
> But since Ashish's patch above is considered as a new feature addition, it
> will be pushed (if passes the review process) after the 19`Q1 release tag.
>
> So Eugene, Ard and Ashish, do you have concern on this?
>

That works for me.

Re: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

[Ashish Singhal]

Ok with me.

Get Outlook for iOS<https://aka.ms/o0ukef>

________________________________
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Sent: Tuesday, March 5, 2019 6:39 AM
To: Wu, Hao A
Cc: edk2-devel@lists.01.org; Eugene Cohen; Ashish Singhal
Subject: Re: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

On Tue, 5 Mar 2019 at 03:18, Wu, Hao A <hao.a.wu@intel.com> wrote:
>
> > -----Original Message-----
> > From: Wu, Hao A
> > Sent: Tuesday, March 05, 2019 9:14 AM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A; Eugene Cohen; Ard Biesheuvel; Ashish Singhal
> > Subject: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC
> > v3 64-bit systems
>
> Since Ashish already posted a patch to add the 64-bit System Address
> support for V3 mode SDHC:
> https://www.mail-archive.com/edk2-devel@lists.01.org/msg52057.html
>
> I think this patch can be dropped.
>
> But since Ashish's patch above is considered as a new feature addition, it
> will be pushed (if passes the review process) after the 19`Q1 release tag.
>
> So Eugene, Ard and Ashish, do you have concern on this?
>

That works for me.

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------