From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E657F2194EB7A for ; Tue, 5 Mar 2019 05:33:03 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id n2so9471116wrw.8 for ; Tue, 05 Mar 2019 05:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=An6SiMbMOvpxV10pC1uX4PVQ5FOWVxmS1PbizIqkmao=; b=RbIP4R3+r/j45PaRkiYJ0aczks3a8STNzCgIpi3vj649a5ktKoiLZME0tCfXtaqQ42 Z/HDMBCff1A+TT9dmnP6o1xdZPTPsPWLa/7qdyrhv7m5L9Pc+30c4EikKB76413JjAFy eDRycC8rBXhFwNA5FJCEyhsd73VeauIBd8KQTcXGE7d4YAQjKLmUjh+nN4SWtSS7PsAN tMc0og5JLt4Uuvfpi29tEb0rfOwUc+v0/cwEkuv2qbNEC+/M3ki6fJ2Z8n6Drk5LRGIu bCS9TULUkpMu1cr6pCCOvLhSxo4yDdIu0oOOdEytvKgoNqM43NV4fXe/Ty2cvJDXI5XA bwQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=An6SiMbMOvpxV10pC1uX4PVQ5FOWVxmS1PbizIqkmao=; b=QtFiUFhfmVs1R8lncqRNtlT5v8En1mc2ygrMn3M5D5SwvtP0OhGBaFULd5u44EhiPX JcyIG8EnEpCdk449iM2J7y7eCL6u+095bLuSyMrwdNfkHwNEvau+KEWwTCWxR1D7Z/oH QUFC6v9NbQE1+XiKTkJprg1TP3dgIGCh+R2O3FSF4GJA77KspfZfAwSsRgj0e3CRo9QS bioFLUwhCqnax1CocqCzNwzpv0jdwh7cBvHLR99rsIZ5166pMq7C51lRGQ5nWtZlgynu fvDJBBc94YZFn0PmBpiqUqs4+w9eKlBPhoo1dBvKMzRTZ4dL+GFvW92cxXvrL8KuwfOt XR3w== X-Gm-Message-State: APjAAAXSf8iD+E673hlxHyG0oibNsz2rlgM2LWbsbRd3b83ZHt22gMtD 3btkX2XMXwnwI85skCG6uRfkEp0DhNE= X-Google-Smtp-Source: APXvYqzu4ih2Z4Fu16rkmmycvW6T4gdkbypAqTivZQpi7IVXeMJjR6XjCkqvwyv9lc5sGH/RyddW+w== X-Received: by 2002:adf:eb84:: with SMTP id t4mr17398441wrn.100.1551792782160; Tue, 05 Mar 2019 05:33:02 -0800 (PST) Received: from localhost.localdomain (aputeaux-684-1-18-114.w90-86.abo.wanadoo.fr. [90.86.221.114]) by smtp.gmail.com with ESMTPSA id i4sm8370097wrw.19.2019.03.05.05.33.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 05:33:01 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Cc: Ard Biesheuvel , Achin Gupta , Supreeth Venkatesh , Jiewen Yao , Leif Lindholm , Jagadeesh Ujja Date: Tue, 5 Mar 2019 14:32:43 +0100 Message-Id: <20190305133248.4828-6-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190305133248.4828-1-ard.biesheuvel@linaro.org> References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 13:33:04 -0000 Content-Transfer-Encoding: 8bit Sending DEBUG output to the serial port should only be done via DebugLib calls, which is in charge of initializing the serial port when appropriate. So drop the explicit SerialPortInitialize () invocation, and rely on normal constructor ordering to get the serial port into the appropriate state at the right time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c index 5cca532456fd..c8e11a253d24 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c @@ -232,9 +232,6 @@ _ModuleEntryPoint ( VOID *TeData; UINTN TeDataSize; - Status = SerialPortInitialize (); - ASSERT_EFI_ERROR (Status); - // Get Secure Partition Manager Version Information Status = GetSpmVersion (); if (EFI_ERROR (Status)) { -- 2.20.1