public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Zhichao Gao <zhichao.gao@intel.com>
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>,
	Jaben Carsey <jaben.carsey@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni
Date: Wed,  6 Mar 2019 15:05:14 +0800	[thread overview]
Message-ID: <20190306070514.19220-1-zhichao.gao@intel.com> (raw)

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146

Add DSDT and SSDT description in the help information. Depend
on the implement of UefiShellAcpiViewCommandLib, the "acpiview"
command support to show all present type in the system not only
support the listed type in the help information. So change the
help information of this command.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni   | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
index 0762eeba53..f2a2400b91 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
@@ -74,10 +74,15 @@
 "  1. The AcpiTable parameter can match any installed table type.\r\n"
 "     Tables without specific handling will be displayed as a raw hex dump (or\r\n"
 "     dumped to a file if -d is used).\r\n"
-"  2. Formatted display and checking is provided for these signature types:\r\n"
+"  2. -s option supports to display the specified AcpiTable type that is present\r\n"
+"     in the system. For normal type AcpiTable, it would display the data of the\r\n"
+"     AcpiTable and AcpiTable header. The following type may contain header type\r\n"
+"     other than AcpiTable header. The acual header can refer to the ACPI spec 6.2\r\n"
+"     Extra A. Particual types:\r\n"
 "       APIC  - Multiple APIC Description Table (MADT)\r\n"
 "       BGRT  - Boot Graphics Resource Table\r\n"
 "       DBG2  - Debug Port Table 2\r\n"
+"       DSDT  - Differentiated System Description Table\r\n"
 "       FACP  - Fixed ACPI Description Table (FADT)\r\n"
 "       GTDT  - Generic Timer Description Table\r\n"
 "       IORT  - IO Remapping Table\r\n"
@@ -87,6 +92,7 @@
 "       SLIT  - System Locality Information Table\r\n"
 "       SPCR  - Serial Port Console Redirection Table\r\n"
 "       SRAT  - System Resource Affinity Table\r\n"
+"       SSDT  - Secondary SystemDescription Table\r\n"
 "       XSDT  - Extended System Description Table\r\n"
 " \r\n"
 ".SH STANDARDS\r\n"
-- 
2.16.2.windows.1



             reply	other threads:[~2019-03-06  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06  7:05 Zhichao Gao [this message]
2019-03-06 15:41 ` [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni Carsey, Jaben
2019-03-06 16:01   ` Nariman Poushin
2019-03-06 16:47     ` Carsey, Jaben
2019-03-07  0:44       ` Gao, Zhichao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190306070514.19220-1-zhichao.gao@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox