* [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni
@ 2019-03-06 7:05 Zhichao Gao
2019-03-06 15:41 ` Carsey, Jaben
0 siblings, 1 reply; 5+ messages in thread
From: Zhichao Gao @ 2019-03-06 7:05 UTC (permalink / raw)
To: edk2-devel; +Cc: Ruiyu Ni, Jaben Carsey, Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146
Add DSDT and SSDT description in the help information. Depend
on the implement of UefiShellAcpiViewCommandLib, the "acpiview"
command support to show all present type in the system not only
support the listed type in the help information. So change the
help information of this command.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
.../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
index 0762eeba53..f2a2400b91 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
@@ -74,10 +74,15 @@
" 1. The AcpiTable parameter can match any installed table type.\r\n"
" Tables without specific handling will be displayed as a raw hex dump (or\r\n"
" dumped to a file if -d is used).\r\n"
-" 2. Formatted display and checking is provided for these signature types:\r\n"
+" 2. -s option supports to display the specified AcpiTable type that is present\r\n"
+" in the system. For normal type AcpiTable, it would display the data of the\r\n"
+" AcpiTable and AcpiTable header. The following type may contain header type\r\n"
+" other than AcpiTable header. The acual header can refer to the ACPI spec 6.2\r\n"
+" Extra A. Particual types:\r\n"
" APIC - Multiple APIC Description Table (MADT)\r\n"
" BGRT - Boot Graphics Resource Table\r\n"
" DBG2 - Debug Port Table 2\r\n"
+" DSDT - Differentiated System Description Table\r\n"
" FACP - Fixed ACPI Description Table (FADT)\r\n"
" GTDT - Generic Timer Description Table\r\n"
" IORT - IO Remapping Table\r\n"
@@ -87,6 +92,7 @@
" SLIT - System Locality Information Table\r\n"
" SPCR - Serial Port Console Redirection Table\r\n"
" SRAT - System Resource Affinity Table\r\n"
+" SSDT - Secondary SystemDescription Table\r\n"
" XSDT - Extended System Description Table\r\n"
" \r\n"
".SH STANDARDS\r\n"
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni
2019-03-06 7:05 [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni Zhichao Gao
@ 2019-03-06 15:41 ` Carsey, Jaben
2019-03-06 16:01 ` Nariman Poushin
0 siblings, 1 reply; 5+ messages in thread
From: Carsey, Jaben @ 2019-03-06 15:41 UTC (permalink / raw)
To: Gao, Zhichao, edk2-devel@lists.01.org; +Cc: Ni, Ray, Gao, Liming
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Tuesday, March 05, 2019 11:05 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray <ray.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>;
> Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note
> in uni
> Importance: High
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146
>
> Add DSDT and SSDT description in the help information. Depend
> on the implement of UefiShellAcpiViewCommandLib, the "acpiview"
> command support to show all present type in the system not only
> support the listed type in the help information. So change the
> help information of this command.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 8
> +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> index 0762eeba53..f2a2400b91 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> @@ -74,10 +74,15 @@
> " 1. The AcpiTable parameter can match any installed table type.\r\n"
> " Tables without specific handling will be displayed as a raw hex dump
> (or\r\n"
> " dumped to a file if -d is used).\r\n"
> -" 2. Formatted display and checking is provided for these signature
> types:\r\n"
> +" 2. -s option supports to display the specified AcpiTable type that is
> present\r\n"
> +" in the system. For normal type AcpiTable, it would display the data of
> the\r\n"
> +" AcpiTable and AcpiTable header. The following type may contain header
> type\r\n"
> +" other than AcpiTable header. The acual header can refer to the ACPI
> spec 6.2\r\n"
> +" Extra A. Particual types:\r\n"
> " APIC - Multiple APIC Description Table (MADT)\r\n"
> " BGRT - Boot Graphics Resource Table\r\n"
> " DBG2 - Debug Port Table 2\r\n"
> +" DSDT - Differentiated System Description Table\r\n"
> " FACP - Fixed ACPI Description Table (FADT)\r\n"
> " GTDT - Generic Timer Description Table\r\n"
> " IORT - IO Remapping Table\r\n"
> @@ -87,6 +92,7 @@
> " SLIT - System Locality Information Table\r\n"
> " SPCR - Serial Port Console Redirection Table\r\n"
> " SRAT - System Resource Affinity Table\r\n"
> +" SSDT - Secondary SystemDescription Table\r\n"
> " XSDT - Extended System Description Table\r\n"
> " \r\n"
> ".SH STANDARDS\r\n"
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni
2019-03-06 15:41 ` Carsey, Jaben
@ 2019-03-06 16:01 ` Nariman Poushin
2019-03-06 16:47 ` Carsey, Jaben
0 siblings, 1 reply; 5+ messages in thread
From: Nariman Poushin @ 2019-03-06 16:01 UTC (permalink / raw)
To: Carsey, Jaben; +Cc: Gao, Zhichao, edk2-devel@lists.01.org, Gao, Liming
On Wed, 6 Mar 2019 at 15:54, Carsey, Jaben <jaben.carsey@intel.com> wrote:
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Tuesday, March 05, 2019 11:05 PM
> > To: edk2-devel@lists.01.org
> > Cc: Ni, Ray <ray.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>;
> > Gao, Liming <liming.gao@intel.com>
> > Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note
> > in uni
> > Importance: High
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146
> >
> > Add DSDT and SSDT description in the help information. Depend
> > on the implement of UefiShellAcpiViewCommandLib, the "acpiview"
> > command support to show all present type in the system not only
> > support the listed type in the help information. So change the
> > help information of this command.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > ---
> > .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 8
> > +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.uni
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.uni
> > index 0762eeba53..f2a2400b91 100644
> > ---
> > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.uni
> > +++
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.uni
> > @@ -74,10 +74,15 @@
> > " 1. The AcpiTable parameter can match any installed table type.\r\n"
> > " Tables without specific handling will be displayed as a raw hex
> dump
> > (or\r\n"
> > " dumped to a file if -d is used).\r\n"
> > -" 2. Formatted display and checking is provided for these signature
> > types:\r\n"
> > +" 2. -s option supports to display the specified AcpiTable type that is
> > present\r\n"
> > +" in the system. For normal type AcpiTable, it would display the
> data of
> > the\r\n"
> > +" AcpiTable and AcpiTable header. The following type may contain
> header
> > type\r\n"
> > +" other than AcpiTable header. The acual header can refer to the
> ACPI
> > spec 6.2\r\n"
> > +" Extra A. Particual types:\r\n"
>
Should this be "Particular"?
> > " APIC - Multiple APIC Description Table (MADT)\r\n"
> > " BGRT - Boot Graphics Resource Table\r\n"
> > " DBG2 - Debug Port Table 2\r\n"
> > +" DSDT - Differentiated System Description Table\r\n"
> > " FACP - Fixed ACPI Description Table (FADT)\r\n"
> > " GTDT - Generic Timer Description Table\r\n"
> > " IORT - IO Remapping Table\r\n"
> > @@ -87,6 +92,7 @@
> > " SLIT - System Locality Information Table\r\n"
> > " SPCR - Serial Port Console Redirection Table\r\n"
> > " SRAT - System Resource Affinity Table\r\n"
> > +" SSDT - Secondary SystemDescription Table\r\n"
> > " XSDT - Extended System Description Table\r\n"
> > " \r\n"
> > ".SH STANDARDS\r\n"
> > --
> > 2.16.2.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni
2019-03-06 16:01 ` Nariman Poushin
@ 2019-03-06 16:47 ` Carsey, Jaben
2019-03-07 0:44 ` Gao, Zhichao
0 siblings, 1 reply; 5+ messages in thread
From: Carsey, Jaben @ 2019-03-06 16:47 UTC (permalink / raw)
To: Nariman Poushin; +Cc: Gao, Zhichao, edk2-devel@lists.01.org, Gao, Liming
Good catch. After fixing this typo, my RB stands.
On Mar 6, 2019, at 7:59 AM, Nariman Poushin <nariman.poushin@linaro.org<mailto:nariman.poushin@linaro.org>> wrote:
On Wed, 6 Mar 2019 at 15:54, Carsey, Jaben <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>> wrote:
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Tuesday, March 05, 2019 11:05 PM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Carsey, Jaben <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>;
> Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>
> Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note
> in uni
> Importance: High
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146
>
> Add DSDT and SSDT description in the help information. Depend
> on the implement of UefiShellAcpiViewCommandLib, the "acpiview"
> command support to show all present type in the system not only
> support the listed type in the help information. So change the
> help information of this command.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com<mailto:ruiyu.ni@intel.com>>
> Cc: Jaben Carsey <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>
> Cc: Liming Gao <liming.gao@intel.com<mailto:liming.gao@intel.com>>
> ---
> .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 8
> +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> index 0762eeba53..f2a2400b91 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> @@ -74,10 +74,15 @@
> " 1. The AcpiTable parameter can match any installed table type.\r\n"
> " Tables without specific handling will be displayed as a raw hex dump
> (or\r\n"
> " dumped to a file if -d is used).\r\n"
> -" 2. Formatted display and checking is provided for these signature
> types:\r\n"
> +" 2. -s option supports to display the specified AcpiTable type that is
> present\r\n"
> +" in the system. For normal type AcpiTable, it would display the data of
> the\r\n"
> +" AcpiTable and AcpiTable header. The following type may contain header
> type\r\n"
> +" other than AcpiTable header. The acual header can refer to the ACPI
> spec 6.2\r\n"
> +" Extra A. Particual types:\r\n"
Should this be "Particular"?
> " APIC - Multiple APIC Description Table (MADT)\r\n"
> " BGRT - Boot Graphics Resource Table\r\n"
> " DBG2 - Debug Port Table 2\r\n"
> +" DSDT - Differentiated System Description Table\r\n"
> " FACP - Fixed ACPI Description Table (FADT)\r\n"
> " GTDT - Generic Timer Description Table\r\n"
> " IORT - IO Remapping Table\r\n"
> @@ -87,6 +92,7 @@
> " SLIT - System Locality Information Table\r\n"
> " SPCR - Serial Port Console Redirection Table\r\n"
> " SRAT - System Resource Affinity Table\r\n"
> +" SSDT - Secondary SystemDescription Table\r\n"
> " XSDT - Extended System Description Table\r\n"
> " \r\n"
> ".SH STANDARDS\r\n"
> --
> 2.16.2.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni
2019-03-06 16:47 ` Carsey, Jaben
@ 2019-03-07 0:44 ` Gao, Zhichao
0 siblings, 0 replies; 5+ messages in thread
From: Gao, Zhichao @ 2019-03-07 0:44 UTC (permalink / raw)
To: Carsey, Jaben, Nariman Poushin; +Cc: edk2-devel@lists.01.org, Gao, Liming
Thanks for your careful check.
I would update it.
Thanks,
Zhichao
From: Carsey, Jaben
Sent: Thursday, March 7, 2019 12:47 AM
To: Nariman Poushin <nariman.poushin@linaro.org>
Cc: Gao, Zhichao <zhichao.gao@intel.com>; edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni
Good catch. After fixing this typo, my RB stands.
On Mar 6, 2019, at 7:59 AM, Nariman Poushin <nariman.poushin@linaro.org<mailto:nariman.poushin@linaro.org>> wrote:
On Wed, 6 Mar 2019 at 15:54, Carsey, Jaben <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>> wrote:
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Tuesday, March 05, 2019 11:05 PM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Carsey, Jaben <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>;
> Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>
> Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note
> in uni
> Importance: High
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146
>
> Add DSDT and SSDT description in the help information. Depend
> on the implement of UefiShellAcpiViewCommandLib, the "acpiview"
> command support to show all present type in the system not only
> support the listed type in the help information. So change the
> help information of this command.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com<mailto:ruiyu.ni@intel.com>>
> Cc: Jaben Carsey <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>
> Cc: Liming Gao <liming.gao@intel.com<mailto:liming.gao@intel.com>>
> ---
> .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 8
> +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> index 0762eeba53..f2a2400b91 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> @@ -74,10 +74,15 @@
> " 1. The AcpiTable parameter can match any installed table type.\r\n"
> " Tables without specific handling will be displayed as a raw hex dump
> (or\r\n"
> " dumped to a file if -d is used).\r\n"
> -" 2. Formatted display and checking is provided for these signature
> types:\r\n"
> +" 2. -s option supports to display the specified AcpiTable type that is
> present\r\n"
> +" in the system. For normal type AcpiTable, it would display the data of
> the\r\n"
> +" AcpiTable and AcpiTable header. The following type may contain header
> type\r\n"
> +" other than AcpiTable header. The acual header can refer to the ACPI
> spec 6.2\r\n"
> +" Extra A. Particual types:\r\n"
Should this be "Particular"?
> " APIC - Multiple APIC Description Table (MADT)\r\n"
> " BGRT - Boot Graphics Resource Table\r\n"
> " DBG2 - Debug Port Table 2\r\n"
> +" DSDT - Differentiated System Description Table\r\n"
> " FACP - Fixed ACPI Description Table (FADT)\r\n"
> " GTDT - Generic Timer Description Table\r\n"
> " IORT - IO Remapping Table\r\n"
> @@ -87,6 +92,7 @@
> " SLIT - System Locality Information Table\r\n"
> " SPCR - Serial Port Console Redirection Table\r\n"
> " SRAT - System Resource Affinity Table\r\n"
> +" SSDT - Secondary SystemDescription Table\r\n"
> " XSDT - Extended System Description Table\r\n"
> " \r\n"
> ".SH STANDARDS\r\n"
> --
> 2.16.2.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-07 0:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-06 7:05 [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni Zhichao Gao
2019-03-06 15:41 ` Carsey, Jaben
2019-03-06 16:01 ` Nariman Poushin
2019-03-06 16:47 ` Carsey, Jaben
2019-03-07 0:44 ` Gao, Zhichao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox