From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.0.47; helo=eur02-am5-obe.outbound.protection.outlook.com; envelope-from=achin.gupta@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B5679211CFBF5 for ; Wed, 6 Mar 2019 07:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IaYlsGv5R8ev0+CQzDghgL68u/QNDZRSX4poahG5qhw=; b=i+BiNqHTaFEMG/dsjFKxAWyg7QMJ35aRFIW/q9DqMO3sq9RxBwIUUgRe0e04NNgIV80XADFqniKEROaRT3wLP4dZmHmt6yLspNk50zQyHGWSdXd7A2ZLUQRZ0a21Ryz/vT62B9TeoTnuGH3G3A9rs89tOteQ2fPpkgseClCoSzA= Received: from AM0PR08MB2980.eurprd08.prod.outlook.com (52.134.92.153) by AM0PR08MB3380.eurprd08.prod.outlook.com (20.177.111.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.18; Wed, 6 Mar 2019 15:16:46 +0000 Received: from AM0PR08MB2980.eurprd08.prod.outlook.com ([fe80::a133:50fa:bbbe:81a6]) by AM0PR08MB2980.eurprd08.prod.outlook.com ([fe80::a133:50fa:bbbe:81a6%5]) with mapi id 15.20.1665.020; Wed, 6 Mar 2019 15:16:46 +0000 From: Achin Gupta To: Ard Biesheuvel CC: "edk2-devel@lists.01.org" , Supreeth Venkatesh , Jiewen Yao , Leif Lindholm , Jagadeesh Ujja , nd Thread-Topic: [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable Thread-Index: AQHU01fzj+c/e8/JTkitGQl5gpodQqX+uIGA Date: Wed, 6 Mar 2019 15:16:46 +0000 Message-ID: <20190306151639.GN21602@mac-ubuntu-vm> References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> <20190305133248.4828-3-ard.biesheuvel@linaro.org> In-Reply-To: <20190305133248.4828-3-ard.biesheuvel@linaro.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mutt/1.9.4 (2018-02-28) x-originating-ip: [95.146.138.15] x-clientproxiedby: LO2P265CA0207.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::27) To AM0PR08MB2980.eurprd08.prod.outlook.com (2603:10a6:208:5b::25) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc2d7d79-19ca-4a7b-b4c5-08d6a246bf56 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR08MB3380; x-ms-traffictypediagnostic: AM0PR08MB3380: x-ms-exchange-purlcount: 1 nodisclaimer: True x-microsoft-exchange-diagnostics: 1; AM0PR08MB3380; 20:w0qtdFwndwOZKoYVECIWVnWZ7hrYuYX8S13uolTTRTUghnxDKhNcXBg17b55axFhQ0degOEybx+b3uU5PfW3Rdcet4gmECMljekJqsCsibH7mTc/XA16zpW10P92IzXLPkvFfzDOT68a2Gd5KD+y388GJcxNPDUOHMwq9XONLH8= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6029001)(7916004)(346002)(376002)(396003)(136003)(39860400002)(366004)(189003)(199004)(316002)(97736004)(4326008)(58126008)(66066001)(6916009)(2906002)(11346002)(33656002)(486006)(476003)(446003)(54906003)(25786009)(186003)(44832011)(68736007)(3846002)(6116002)(76176011)(6486002)(71190400001)(71200400001)(229853002)(14454004)(6306002)(52116002)(478600001)(53936002)(72206003)(5660300002)(26005)(102836004)(966005)(6506007)(386003)(1076003)(6436002)(6346003)(6512007)(9686003)(8676002)(81166006)(81156014)(8936002)(305945005)(106356001)(33716001)(256004)(7736002)(105586002)(6246003)(99286004)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3380; H:AM0PR08MB2980.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Achin.Gupta@arm.com; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: eMSgZ2vDt7q9jYHaIikI3KeX6w/rfQrksbr/1QImU9w6gXLEny72MEb03XXKo3rEBuV1rLD6N0PQ/5wT4KRskVLGj1SRbvjbXQKc7HQAEsJMt3dPEMoXghROhPHYOZq9wW0NawUpg3DG+Fuub3HpzKFiK4rIkt0ZYs7O7KR8dyiAR0y/vSAKP6vZBCz4Ym5SRBYLAWzY7c2SSGel6eZx3/P/yRM+dv9f6Rymn9U6D+SN8UN02MB+5J85DKDCKOrajdVS3T57m93AEsjIqK6U+589E3KQ/9DhSzA5kG2xWC4u/4bvkXGJpq7DqpYbbsPmT4pRRPUeCCCcc2eid3g8TerWfSQ4ZoNg/0Qg9KPatRk/kEwoSlbP5VFbTfrDRitrTidKZJCp5/zfMJgH18d6vga+k4mtw5E0G6C6uOecPSk= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc2d7d79-19ca-4a7b-b4c5-08d6a246bf56 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 15:16:46.5157 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3380 Subject: Re: [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 15:16:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <167DCE538746714F824001B64784112D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable Hi Ard, On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > first place since the value is implied by the context (it is never > valid to set it to FALSE for standalone MM or TRUE for traditional > MM). So drop it. This is being used to determine if the ArmVExpressPkg should include suppor= t for StMM comm. buffer or not [1] but it does look redundant now. cheers, Achin [1] https://lists.01.org/pipermail/edk2-devel/2018-December/034432.html > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > StandaloneMmPkg/StandaloneMmPkg.dec = | 3 --- > StandaloneMmPkg/StandaloneMmPkg.dsc = | 3 --- > StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeC= offExtraActionLib.inf | 3 --- > 3 files changed, 9 deletions(-) > > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dec b/StandaloneMmPkg/Standa= loneMmPkg.dec > index 0b5fbf9e1767..2d178c5e20a6 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dec > +++ b/StandaloneMmPkg/StandaloneMmPkg.dec > @@ -39,6 +39,3 @@ [Guids] > gEfiStandaloneMmNonSecureBufferGuid =3D { 0xf00497e3, 0xbfa2, 0x4= 1a1, { 0x9d, 0x29, 0x54, 0xc2, 0xe9, 0x37, 0x21, 0xc5 }} > gEfiArmTfCpuDriverEpDescriptorGuid =3D { 0x6ecbd5a1, 0xc0f8, 0x4= 702, { 0x83, 0x01, 0x4f, 0xc2, 0xc5, 0x47, 0x0a, 0x51 }} > > -[PcdsFeatureFlag] > - gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable|FALSE|BOOLEAN|0x0= 0000001 > - > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/Standa= loneMmPkg.dsc > index e8d71ad56f52..f279d9e7e5c7 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > @@ -78,9 +78,6 @@ [LibraryClasses.AARCH64] > # Pcd Section - list of all EDK II PCD Entries defined by this Platform > # > ########################################################################= ######## > -[PcdsFeatureFlag] > - gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable|TRUE > - > [PcdsFixedAtBuild] > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x800000CF > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xff > diff --git a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/Sta= ndaloneMmPeCoffExtraActionLib.inf b/StandaloneMmPkg/Library/StandaloneMmPeC= offExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf > index eef3d7c6e253..181c15b9345a 100644 > --- a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/Standalone= MmPeCoffExtraActionLib.inf > +++ b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/Standalone= MmPeCoffExtraActionLib.inf > @@ -37,9 +37,6 @@ [Packages] > MdePkg/MdePkg.dec > StandaloneMmPkg/StandaloneMmPkg.dec > > -[FeaturePcd] > - gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable > - > [LibraryClasses] > StandaloneMmMmuLib > PcdLib > -- > 2.20.1 >