From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.3.75; helo=eur03-am5-obe.outbound.protection.outlook.com; envelope-from=achin.gupta@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30075.outbound.protection.outlook.com [40.107.3.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 503022194EB70 for ; Wed, 6 Mar 2019 07:37:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/SRvdEMedOwW3AqDGlpcsyEpFEogMjhuLF87Kqhqh38=; b=YYQmLZ66xUh4TZ17mOR7hzB7mtSzt8TMRfXZYVfV/Jr03UUSoJzFA40YER0Q0gGvWM1HOTIBY8mfHb58ApRzAGlqqFlyl77osWyibcuAfhhC32P8ACW8mQkGc/GUR+Fc2/6zI2BEWbcnvEFovuJHSYjPpQE3Sb+dL3sYnvmqJSg= Received: from AM0PR08MB2980.eurprd08.prod.outlook.com (52.134.92.153) by AM0PR08MB3730.eurprd08.prod.outlook.com (20.178.21.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.17; Wed, 6 Mar 2019 15:37:09 +0000 Received: from AM0PR08MB2980.eurprd08.prod.outlook.com ([fe80::a133:50fa:bbbe:81a6]) by AM0PR08MB2980.eurprd08.prod.outlook.com ([fe80::a133:50fa:bbbe:81a6%5]) with mapi id 15.20.1665.020; Wed, 6 Mar 2019 15:37:09 +0000 From: Achin Gupta To: Ard Biesheuvel CC: "edk2-devel@lists.01.org" , Supreeth Venkatesh , Jiewen Yao , Leif Lindholm , Jagadeesh Ujja , nd Thread-Topic: [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable Thread-Index: AQHU01fzj+c/e8/JTkitGQl5gpodQqX+uIGAgAAAVoCAAAVZAA== Date: Wed, 6 Mar 2019 15:37:08 +0000 Message-ID: <20190306153700.GO21602@mac-ubuntu-vm> References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> <20190305133248.4828-3-ard.biesheuvel@linaro.org> <20190306151639.GN21602@mac-ubuntu-vm> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mutt/1.9.4 (2018-02-28) x-originating-ip: [95.146.138.15] x-clientproxiedby: LNXP123CA0015.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::27) To AM0PR08MB2980.eurprd08.prod.outlook.com (2603:10a6:208:5b::25) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Achin.Gupta@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0754ceec-cc7b-4707-04b6-08d6a2499814 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR08MB3730; x-ms-traffictypediagnostic: AM0PR08MB3730: nodisclaimer: True x-microsoft-exchange-diagnostics: 1; AM0PR08MB3730; 20:BPf47M6SqAlnLs1mIgoIYIHsPtuOQ3PZMgVYEXxyUpFTfhKKXOaEp7RF50gAY6qHJOFcPH+7C073KmQX15yBsx/VX4+zUc+xU3PUHyOuPYbHmDfBSBcfMnYoZTNZ3M9x/YFmMDB03lC2coFGkOejZxheNiJ85i9DK7mFtJFFNw4= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6029001)(7916004)(136003)(346002)(39860400002)(376002)(396003)(366004)(189003)(199004)(54906003)(305945005)(446003)(6116002)(486006)(102836004)(97736004)(3846002)(476003)(25786009)(8676002)(81156014)(81166006)(58126008)(7736002)(316002)(256004)(26005)(71200400001)(71190400001)(72206003)(11346002)(4326008)(99286004)(66066001)(44832011)(52116002)(86362001)(6506007)(386003)(93886005)(76176011)(478600001)(6246003)(6512007)(9686003)(33716001)(53936002)(2906002)(33656002)(6916009)(4744005)(229853002)(106356001)(14454004)(105586002)(68736007)(186003)(8936002)(6486002)(5660300002)(6436002)(1076003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3730; H:AM0PR08MB2980.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dml6ypgqY37fFxWTgl/z0Np6k6k6cbuWWEOooppTq6/AzI1fpR5ATZTnSOEE5RRlL846EFaDChdizguoo6MsQ2uKMZznLAOxDoRegOcX6B6lrKRGjz8vdGYuHNHJn5hp4FlYlhgk6TE47uhVtQO+n4Fc/NubU2CkGhtvpNn0ZnH7xN2JhRRhoSvNxg5eIvmihrKb1KMIkZrfAqdk7oTDfvp99vf/9yArbZCvaLdi47ucVh8BB4lagEPkr+bfxs76MTfSO/wwOZzZ4yTtu2DeKX6kpiiejh9g6bH7YGfzh3Zl9Bc2Xv7QoHcHYf2Q2gTr7+3WCsxxxiRpWk1KP9WICGiJEQT6k9klHrgd1vGMsEbqt5km3l6Y2jQTZwb7Sjzc6FyPbm7YQ0a3rvWNeUx1zA0ZB2OPLm/oFIHEUV4qIK8= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0754ceec-cc7b-4707-04b6-08d6a2499814 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 15:37:09.1587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3730 Subject: Re: [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 X-List-Received-Date: Wed, 06 Mar 2019 15:37:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > > > Hi Ard, > > > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > > > first place since the value is implied by the context (it is never > > > valid to set it to FALSE for standalone MM or TRUE for traditional > > > MM). So drop it. > > > > This is being used to determine if the ArmVExpressPkg should include su= pport for > > StMM comm. buffer or not [1] but it does look redundant now. > > > > If that is the case, the PCD should be defined in that package. The Arm FVP port for StMM needs a rewrite on the lines of other platforms. = This change is fine. Reviewed-by: achin.gupta@arm.com