From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Achin.Gupta@arm.com> Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.1.57; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=achin.gupta@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10057.outbound.protection.outlook.com [40.107.1.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 21158211D6166 for <edk2-devel@lists.01.org>; Thu, 7 Mar 2019 03:14:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dM8Altmb0nncs2Xv5NuWnghc+LTJZp0IOQeIH6DCGt0=; b=Va+F5VC6Q9kfzEmEaTYGgc/Ur21NNfpyQPlteil1rbuVpKqPBHiqHW3TaToRvq848G8oJArMRsi6V2jFKIx4OWP5yiCnVq71ksbhBkOPgniApVhzyw7sJIKyiC+JyqxXlh7BvwrIhD3lFnQHMsdcyDulI0AClz2Sa5IrWEOCaHM= Received: from AM0PR08MB2980.eurprd08.prod.outlook.com (52.134.92.153) by AM0PR08MB4145.eurprd08.prod.outlook.com (20.178.203.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Thu, 7 Mar 2019 11:14:17 +0000 Received: from AM0PR08MB2980.eurprd08.prod.outlook.com ([fe80::a133:50fa:bbbe:81a6]) by AM0PR08MB2980.eurprd08.prod.outlook.com ([fe80::a133:50fa:bbbe:81a6%5]) with mapi id 15.20.1686.018; Thu, 7 Mar 2019 11:14:17 +0000 From: Achin Gupta <Achin.Gupta@arm.com> To: Ard Biesheuvel <ard.biesheuvel@linaro.org> CC: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>, Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>, Jiewen Yao <jiewen.yao@intel.com>, Leif Lindholm <leif.lindholm@linaro.org>, Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>, nd <nd@arm.com> Thread-Topic: [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable Thread-Index: AQHU01fzj+c/e8/JTkitGQl5gpodQqX+uIGAgAAAVoCAAAVZAIABNtuAgAAR8oA= Date: Thu, 7 Mar 2019 11:14:17 +0000 Message-ID: <20190307111349.GX21602@mac-ubuntu-vm> References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> <20190305133248.4828-3-ard.biesheuvel@linaro.org> <20190306151639.GN21602@mac-ubuntu-vm> <CAKv+Gu8iLi3dUZ1qFE7_jAez-Eo1H4gHHsWXDERSoC8-XbQyDg@mail.gmail.com> <20190306153700.GO21602@mac-ubuntu-vm> <CAKv+Gu8qY9z0ux1smwHvCyqCOY8kFn=4mua6VL+fDd_7m+MLWA@mail.gmail.com> In-Reply-To: <CAKv+Gu8qY9z0ux1smwHvCyqCOY8kFn=4mua6VL+fDd_7m+MLWA@mail.gmail.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mutt/1.9.4 (2018-02-28) x-originating-ip: [217.140.96.140] x-clientproxiedby: LO2P123CA0022.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::34) To AM0PR08MB2980.eurprd08.prod.outlook.com (2603:10a6:208:5b::25) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Achin.Gupta@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d7b10f0c-3cef-45b1-ada0-08d6a2ee09ae x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR08MB4145; x-ms-traffictypediagnostic: AM0PR08MB4145: nodisclaimer: True x-microsoft-exchange-diagnostics: 1; AM0PR08MB4145; 20:oOEcBESnX5QGWBySBu3t/CuIrt513If5DIchinIREqWVVANA2tMRx3t7b8d9jCB/pfb0SQlQoK+Q8DF/za406Lo2cyH0qtjzK6QlK9WS/OECD4fjHZfz5DyOBl0PyXLzAg+xjmJvLp+oMkPUj1QHnieMKLU4pJAgvSWee8s2egU= x-microsoft-antispam-prvs: <AM0PR08MB4145812AC89FF9CD067E5D61FF4C0@AM0PR08MB4145.eurprd08.prod.outlook.com> x-forefront-prvs: 096943F07A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6029001)(7916004)(136003)(39860400002)(376002)(346002)(366004)(396003)(199004)(189003)(8676002)(81156014)(11346002)(81166006)(44832011)(256004)(5660300002)(6486002)(446003)(486006)(476003)(8936002)(229853002)(54906003)(33716001)(97736004)(71200400001)(305945005)(7736002)(53936002)(6506007)(386003)(6512007)(102836004)(99286004)(52116002)(71190400001)(33656002)(76176011)(86362001)(6436002)(9686003)(72206003)(14454004)(93886005)(1076003)(25786009)(66066001)(68736007)(6916009)(4326008)(6246003)(3846002)(6116002)(26005)(186003)(105586002)(58126008)(316002)(2906002)(106356001)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4145; H:AM0PR08MB2980.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: P28pEePODvBO2sL5p1tkFjONz4cG0zBrS1cARedSs8KeoXOhY6hiH28Rc7oPUWtPugZSun/Yt0zUvUgq9NZNAke2IxeXcAulr1+mdX/v3n7yKGZnDj7IPc3NXDEQ3fIeIPD2PVJCQsrq85cr0mSVg4WhZwe/wctAckzhTz+uUKmfKXg+wFg+UIWnnlAdWmPk2ij6LfW5dtc2+5S0+528iTqY7V2FDY7QM9cxkhHwV9vd8/wO9I9HKtfW6m2m+AqMOVQCmc2VAQMGRLYJ79wdIjW1oXII9ZCKkuli6hYFj1E1GIFw4vKeLtXl/HbwEUGicH11S0ouzEIjGtFBlD1lEvmQunHrOnv3MfyDIZksPXdyowhx9KI8D2uYEFnTklvr+e9BhuLDpitlSwVai6bWPFVqVBdgmsFDo4HBUOPhhqU= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7b10f0c-3cef-45b1-ada0-08d6a2ee09ae X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2019 11:14:17.2165 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4145 Subject: Re: [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development <edk2-devel.lists.01.org> List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>, <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe> List-Archive: <http://lists.01.org/pipermail/edk2-devel/> List-Post: <mailto:edk2-devel@lists.01.org> List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help> List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>, <mailto:edk2-devel-request@lists.01.org?subject=subscribe> X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 X-List-Received-Date: Thu, 07 Mar 2019 11:14:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <4A1BD0CEB2D3E34093CD50B1AF86BBDF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Thu, Mar 07, 2019 at 11:09:35AM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 16:37, Achin Gupta <Achin.Gupta@arm.com> wrote: > > > > On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > > > On Wed, 6 Mar 2019 at 16:16, Achin Gupta <Achin.Gupta@arm.com> wrote: > > > > > > > > Hi Ard, > > > > > > > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > > > > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in t= he > > > > > first place since the value is implied by the context (it is neve= r > > > > > valid to set it to FALSE for standalone MM or TRUE for traditiona= l > > > > > MM). So drop it. > > > > > > > > This is being used to determine if the ArmVExpressPkg should includ= e support for > > > > StMM comm. buffer or not [1] but it does look redundant now. > > > > > > > > > > If that is the case, the PCD should be defined in that package. > > > > The Arm FVP port for StMM needs a rewrite on the lines of other platfor= ms. This > > change is fine. > > > > Yes, you are right. SynQuacer also needs some tweaks to align with > these changes, but I will post those separately. > > So with those changes merged, the only thing preventing us from > building the SynQuacer + MM platform from upstream sources is the > MmCommunicate VA vs PA issue. Is there any progress on that front? I am looking at this now after my holiday. I have some questions that I wil= l post separately. cheers, Achin > > Thanks, > Ard.