* [Patch] BaseTools: Fixed the issue of BaseTools Make cleanall failed.
@ 2019-03-14 14:47 Feng, Bob C
2019-03-14 14:57 ` Carsey, Jaben
0 siblings, 1 reply; 2+ messages in thread
From: Feng, Bob C @ 2019-03-14 14:47 UTC (permalink / raw)
To: edk2-devel; +Cc: Bob Feng, Liming Gao
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1622
There is duplicated $(PYTHON_COMMAND) in the
command of cleanall
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
BaseTools/Source/C/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/Makefile b/BaseTools/Source/C/Makefile
index 08f0081212..ca71bd1178 100644
--- a/BaseTools/Source/C/Makefile
+++ b/BaseTools/Source/C/Makefile
@@ -65,10 +65,10 @@ clean:
@if defined PYTHON_COMMAND $(PYTHON_COMMAND) Makefiles\NmakeSubdirs.py clean $(LIBRARIES) $(APPLICATIONS)
@if not defined PYTHON_COMMAND $(PYTHON_HOME)\python.exe Makefiles\NmakeSubdirs.py clean $(LIBRARIES) $(APPLICATIONS)
.PHONY: cleanall
cleanall:
- @if defined PYTHON_COMMAND $(PYTHON_COMMAND) $(PYTHON_COMMAND) Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES) $(APPLICATIONS)
- @if not defined PYTHON_COMMAND $(PYTHON_HOME)\python.exe $(PYTHON_COMMAND) Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES) $(APPLICATIONS)
+ @if defined PYTHON_COMMAND $(PYTHON_COMMAND) Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES) $(APPLICATIONS)
+ @if not defined PYTHON_COMMAND $(PYTHON_HOME)\python.exe Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES) $(APPLICATIONS)
!INCLUDE Makefiles\ms.rule
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] BaseTools: Fixed the issue of BaseTools Make cleanall failed.
2019-03-14 14:47 [Patch] BaseTools: Fixed the issue of BaseTools Make cleanall failed Feng, Bob C
@ 2019-03-14 14:57 ` Carsey, Jaben
0 siblings, 0 replies; 2+ messages in thread
From: Carsey, Jaben @ 2019-03-14 14:57 UTC (permalink / raw)
To: Feng, Bob C, edk2-devel@lists.01.org; +Cc: Gao, Liming
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Thursday, March 14, 2019 7:48 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] BaseTools: Fixed the issue of BaseTools Make cleanall
> failed.
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1622
> There is duplicated $(PYTHON_COMMAND) in the
> command of cleanall
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/C/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/C/Makefile b/BaseTools/Source/C/Makefile
> index 08f0081212..ca71bd1178 100644
> --- a/BaseTools/Source/C/Makefile
> +++ b/BaseTools/Source/C/Makefile
> @@ -65,10 +65,10 @@ clean:
> @if defined PYTHON_COMMAND $(PYTHON_COMMAND)
> Makefiles\NmakeSubdirs.py clean $(LIBRARIES) $(APPLICATIONS)
> @if not defined PYTHON_COMMAND $(PYTHON_HOME)\python.exe
> Makefiles\NmakeSubdirs.py clean $(LIBRARIES) $(APPLICATIONS)
>
> .PHONY: cleanall
> cleanall:
> - @if defined PYTHON_COMMAND $(PYTHON_COMMAND)
> $(PYTHON_COMMAND) Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES)
> $(APPLICATIONS)
> - @if not defined PYTHON_COMMAND $(PYTHON_HOME)\python.exe
> $(PYTHON_COMMAND) Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES)
> $(APPLICATIONS)
> + @if defined PYTHON_COMMAND $(PYTHON_COMMAND)
> Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES) $(APPLICATIONS)
> + @if not defined PYTHON_COMMAND $(PYTHON_HOME)\python.exe
> Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES) $(APPLICATIONS)
>
> !INCLUDE Makefiles\ms.rule
>
> --
> 2.18.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-14 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-14 14:47 [Patch] BaseTools: Fixed the issue of BaseTools Make cleanall failed Feng, Bob C
2019-03-14 14:57 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox