From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=162.221.156.55; helo=smtp03.citrix.com; envelope-from=prvs=969ce9b1e=anthony.perard@citrix.com; receiver=edk2-devel@lists.01.org Received: from SMTP03.CITRIX.COM (smtp03.citrix.com [162.221.156.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D5922194EB76 for ; Thu, 14 Mar 2019 10:44:26 -0700 (PDT) X-IronPort-AV: E=Sophos;i="5.58,478,1544486400"; d="scan'208";a="80600190" Date: Thu, 14 Mar 2019 17:44:24 +0000 From: Anthony PERARD To: Igor Druzhinin CC: , , , , , Message-ID: <20190314174424.GC11621@perard.uk.xensource.com> References: <1551876056-28223-1-git-send-email-igor.druzhinin@citrix.com> <1551876056-28223-3-git-send-email-igor.druzhinin@citrix.com> MIME-Version: 1.0 In-Reply-To: <1551876056-28223-3-git-send-email-igor.druzhinin@citrix.com> User-Agent: Mutt/1.11.3 (2019-02-01) Subject: Re: [PATCH RESEND 2/3] OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 X-List-Received-Date: Thu, 14 Mar 2019 17:44:27 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Mar 06, 2019 at 12:40:55PM +0000, Igor Druzhinin wrote: > In case BAR64 is placed below 4G choose the correct aperture. > This fixes a failed assertion down the code path. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Igor Druzhinin > --- > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > index c23c46d..408fb24 100644 > --- a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > +++ b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > @@ -145,7 +145,11 @@ PcatPciRootBridgeParseBars ( > Length = Length | LShiftU64 ((UINT64) UpperValue, 32); > Length = (~Length) + 1; > > - MemAperture = MemAbove4G; > + if (Base < 0x100000000) { You could use the macro BASE_4GB to replace this 1 followed by a looong list of 0. And with that changed: Acked-by: Anthony PERARD Thanks, -- Anthony PERARD