From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7C5A621A07A80 for ; Tue, 19 Mar 2019 10:59:01 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id f8so2808439wmh.0 for ; Tue, 19 Mar 2019 10:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jrCU+u7/b9O1djMc3NyYJKAoGlySLQSKzaGA7cXJdgg=; b=ts8Vn8a+JGhfGxs+udie1wdQaLWKsUW/N0siZj037bABWQDXsa4JATsXhWyFNy2Nwl Hoprwg5DqiKuEdxmbmI+kvWKgAhxNT6xqnFUaHPzMvlJai4MMzjxvJZymdHuTB4Z5RMU l+1/8n9aGvbwizkCxQFiZ1gGnPZBUMYaKghoF2GO2ptqps63GVDA8cXykCKpJx2g+Oib IppHmXLIxDYWnbHfGj6va46LSLoyi50g3jbCEktLfY5cYJwAxHBtucck8ZQ8F4QliLHo ASNcFu5rxcL9RWeUxjkLUUGGqpYI5z9bMf6es4M8/MB9h2h9Z9898JdC47g8v43pNuI0 gUvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jrCU+u7/b9O1djMc3NyYJKAoGlySLQSKzaGA7cXJdgg=; b=G65mUNJUCG8f0LqMiUL306oYLI6QrpNXX/cg8CiIOYhRrWdq15wlqKUxOPYJJc1rfw wnQG7ebsf3MbbLoWXeH2QKBcNAuAbrCeTMCV/YDLHCzcUXVkZMnAFXgljP4YXpiE9mN5 Niapd/IPUWOx+Kb51fUgnAZfhonURsb7euVZtRJ4u9c7fvlPa4DANxFJvb5qLscsboYj Wyb/ki7DniJq0Gi35+0+rjF8Mmw3I0pdZMkHJLVFZXqOQZSlPQIHgrQj8Ap2nj+EIot0 4TsDT8VWpxpMweRCorWvPLBnvTXq43MFp9WDHTK5sJ8Ilc12BdmIVtz5Peq5ZnGzc/J/ Qqzw== X-Gm-Message-State: APjAAAWa9iJtqEswkiY8hebnMKXp9JIPgy5sowSzfC7Gn/ecVkb9epx1 OgBn+1bhU7WzkQy58sUN9W9fhQ== X-Google-Smtp-Source: APXvYqw8pNWBxHAGdlnd90FxUs6Sq8i33+k5BeQ691UINtdOU2Bt4mNaTJCiEKm28f9qJukmnrUYvQ== X-Received: by 2002:a1c:5546:: with SMTP id j67mr4479939wmb.95.1553018339735; Tue, 19 Mar 2019 10:58:59 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p10sm13957391wrs.5.2019.03.19.10.58.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 10:58:58 -0700 (PDT) Date: Tue, 19 Mar 2019 17:58:56 +0000 From: Leif Lindholm To: "Kinney, Michael D" Cc: "Justen, Jordan L" , "edk2-devel@lists.01.org" Message-ID: <20190319175856.g2sao3bdsyseaxa2@bivouac.eciton.net> References: <155258662331.20276.3714209093894340086@jljusten-skl> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: PATCH] Change EDK II to BSD+Patent License X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 17:59:01 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Mike, I see where Jordan is coming from here. It isn't just about losing the comment in Contriutions.txt - there are bits in the actual TianoCore Contribution Agreement that cover the same things as https://developercertificate.org/ (that are not explicitly called out elsewhere in the existing Contributions.txt). Like Jordan says, we wouldn't be the first project that use Signed-off-by without specifying exactly what it means, but I think we're one of the ones that actually care quite a bit. I could live with us not resolving this at the same time as the license change, but I would prefer if we did... Best Regards, Leif On Mon, Mar 18, 2019 at 06:25:54PM +0000, Kinney, Michael D wrote: > Hi Jordan, > > No proposed changes to the Signed-off-by tags. If you have > a proposal, please provide an RFC or bring to the monthly > EDK II community meeting. > > This series is focused on the license change, the use of SPDX > identifiers, and removing the Contributed-under tag from > commit messages. > > I will update the V2 version of the patch series in to make > sure the content from Contributions.txt that is not part of > the TianoCore Contribution Agreement is added to Readme.md. > > The RFC mentioned the need to update documentation. I will > send that out as a separate Wiki patch series for review. > > Best regards, > > Mike > > > -----Original Message----- > > From: Justen, Jordan L > > Sent: Thursday, March 14, 2019 11:04 AM > > To: Kinney, Michael D ; > > edk2-devel@lists.01.org > > Subject: Re: [edk2] PATCH] Change EDK II to BSD+Patent > > License > > > > On 2019-03-13 10:54:22, Kinney, Michael D wrote: > > > > > > 84141eacac edk2: Remove Contributions.txt and update > > Readme.md > > > > I guess this removes the requirement for the > > 'Contributed-under' tag > > in commit messages? > > > > But, what about Signed-off-by? Is it desirable to > > remove that > > requirement? > > > > Relatedly, some open source projects have standardized > > on tying the > > Signed-off-by to this text: > > > > https://developercertificate.org/ > > > > So, the contributor doesn't have to agree to give the > > project the > > contribution under the Contributed-under terms, but > > they still > > indicate that they believe that the project can use the > > code under the > > project's indicated license. > > > > There is also other information in Contributions.txt > > that appears to > > have been deleted, rather than moved. I guess it is > > mostly duplicated > > on the wiki. That doesn't mean it's not a good idea to > > duplicate it in > > the source tree, or at least provide a web-link. It > > seems like the > > first place devs might look for such information is > > either the readme, > > or Contributions.txt. > > > > Regarding the wiki, I guess it has to be updated after > > this change is > > made. It might be good to add that to the bug so it > > can't be closed > > until that is fixed. > > > > How about updating BaseTools/Scripts/PatchCheck.py? > > > > -Jordan > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel