From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EEE8211D67E4 for ; Thu, 21 Mar 2019 10:52:23 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id g12so7628998wrm.5 for ; Thu, 21 Mar 2019 10:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=u7GmoBFaIBZJ3wSgkXhxjWwoh7P9i/iuWbIyxLNXPls=; b=W5liTXcJtBRllm8SgHZEFmd8zDYsYmfkzh2T0tlIScb85FA6xLtcS4Ibwu8lftcR+j ZYAwFd4Qw5qVaXrYi+HCt2PV8w9luThk++HtnUK/luddLUDS3k4q20G4+nMlDQn3K3TK fyGcVkXjFP7lW+IvjsOmu7dCgu9EE7dtzTV4yQNHVEoWbbPCyK7f65ssWQ8fQfMvqQvH NSCGiAm3sifBDIvAmbk4YFcO7L0vHY9VUWRkuN32SD4gUFqEohrO36OSxYR5brFw/5LS Bmk+rBCYmQ0I4QSMfgXLn2pvca2U5uNE09YPBZrR6lbhgBZW7tRxnaBIsqpYU+YSCT9x jEEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=u7GmoBFaIBZJ3wSgkXhxjWwoh7P9i/iuWbIyxLNXPls=; b=Yx+DXFEHtpQ3/SgpZkNRVZglzndfrsToxUa6/eBUjNof9mV2YEWuhyVLAE+2kHlPH6 kOZ3AzVdyYXmGerPi+FZLACioKP/2ZbYYC3L/BVozHha8utXanzLyFGJhoUACtJ75N+E BegtkoIBl1/zMhWZ/PCSs6veEwfu1P4cdiyQvp17HEumaTUh3zS/zMKlvrDp1arWuN8o hG2lB+hRYA/zZVn2124ZTKl/eWUs2YOGqLL+IY/J5kEW6IBozXTTbzq+z4+lnYVVeAne y/6sopfcUd8RZNxIL6THCr6JF6MvpgK/S/2ekTraCxlLm7WM5/sKyNIQ2xcigpz7Oxt0 q8fw== X-Gm-Message-State: APjAAAXkoqiztvpvTUuIhi6MMw5mnwmu6yKgXgWg0XOqMuZbnYXEx+62 MiBXtY3IGsz0mhKVutQ9yNjWow== X-Google-Smtp-Source: APXvYqyvEMARhOxBG3Hk+pvG+cpslAVl5SPNPbQeZSMnmbPgS9IkZHmCEXB/+P6SXxe522TOrCs3xQ== X-Received: by 2002:a5d:458f:: with SMTP id p15mr3654193wrq.188.1553190741762; Thu, 21 Mar 2019 10:52:21 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x11sm5499188wmh.2.2019.03.21.10.52.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 10:52:20 -0700 (PDT) Date: Thu, 21 Mar 2019 17:52:18 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, zhangfeng56@huawei.com, xiaojun2@hisilicon.com Message-ID: <20190321175217.wwkpqdmcanlytyzl@bivouac.eciton.net> References: <20190320080829.52003-1-ming.huang@linaro.org> <20190320080829.52003-6-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190320080829.52003-6-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v3 05/18] Hisilicon/D06: Fix access variable fail issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 17:52:23 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I will update the subject line to reflect what is actually being changed. Other than that, Reviewed-by: Leif Lindholm On Wed, Mar 20, 2019 at 04:08:16PM +0800, Ming Huang wrote: > From: Jason Zhang > > BmcWdtEnable is a field of OemConfigData structure, need have > runtime service attribution if use it during exit boot service > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr | 2 +- > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr > index 470e9ace3dcf..08236704fbfe 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr > @@ -23,7 +23,7 @@ formset > help = STRING_TOKEN(STR_OEM_CONFIG), > classguid = gEfiIfrFrontPageGuid, // for MdeModule Bds. > efivarstore OEM_CONFIG_DATA, > - attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE, > + attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS, > name = OemConfig, > guid = gOemConfigGuid; > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > index 012d45bc0214..6668103af027 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > @@ -316,7 +316,7 @@ OemConfigUiLibConstructor ( > Status = gRT->SetVariable ( > OEM_CONFIG_NAME, > &gOemConfigGuid, > - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS, > + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, > sizeof (OEM_CONFIG_DATA), > &Configuration > ); > -- > 2.9.5 >