From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE8E2211E2EE9 for ; Thu, 21 Mar 2019 10:56:36 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id d17so7614007wre.10 for ; Thu, 21 Mar 2019 10:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Oz1aeK6TAZGYYm2IkAIptivZxltiuCYxzkLDG3mC8BE=; b=R0ADU7GjYlh9zBXPadMrTQcl3Ehu3Eodu/7kHWKoSJnKyUcFTfP5HtZVoNmV9QmoTX 4cFimmeqDhfEH4Mw0qG10wNpeP7Z2plt9NBbBFZsoX4L06lY1UED+DZ7lMAjIPRcjAKj eXOGGRPuv/kwBqVrYWreHMJhpZ3ZVQ7hOnzWONpAIAzDDfex8GmH2FZbT7Vy2TN/nbPv oe2p43vRIwq6bDRi+ZWg8DV4cB7TQJN3DuLxnIYmtxpfHWwSguSAv+K+zx2GWIp+IlAU pkFo1AClA0ZpxpeL5trUNm/aSiRBTPmZQcnLNdPVklXV/QxV9y19j5Lw0BfqKFA8MOTk 0E+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Oz1aeK6TAZGYYm2IkAIptivZxltiuCYxzkLDG3mC8BE=; b=DAvi282J1FksLeYGRZ14n2XO3+hG8vdEJ8S16uwS8yWPQBCjffJ6WMY4gwIyqTknF5 0pPB9UNuDWTfV4mFF0n6LwjHEaC7jEmSdPwHlJ5YD6LJeKPxmvE1nKBrclEK3GW9x+2l vhd4oN1pIa4YhTvext7G8y/Z07rYe0tw9Mm3hmYO/d5UDSr8mOloSGvP71rK+Wo5z34q rrFK0UuGt4tJLdJXLmfVA69YUMlpib7WOxEzeDNHRQ9RYIaac+87APgGz/VheFMyk6XI YReKjXrD77j+8lxhHPO9qZrCPYz9pu9RPPKAfnl7qbxpFC4aD19VNLt3j5Qd8vMHD7ON Vwog== X-Gm-Message-State: APjAAAX5FRKjIJK11rl5Rkuhg98zu8QdpXRcgJvJeTnR7nn7t+So20Mw Q1/Jh5R4Fs1Q39RfoJTyqgXJ4AtzAv0= X-Google-Smtp-Source: APXvYqwHvJyZEAb5RbGaxKJAVlMDi984imM26O7IzhPwzdP4wDhqf/VJ2EumQ8Q4SjMctTzLe53Haw== X-Received: by 2002:adf:91c7:: with SMTP id 65mr3531354wri.191.1553190995279; Thu, 21 Mar 2019 10:56:35 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b10sm5421019wru.92.2019.03.21.10.56.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 10:56:34 -0700 (PDT) Date: Thu, 21 Mar 2019 17:56:32 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, zhangfeng56@huawei.com, xiaojun2@hisilicon.com Message-ID: <20190321175632.okf7ix3dcnojajhl@bivouac.eciton.net> References: <20190320080829.52003-1-ming.huang@linaro.org> <20190320080829.52003-6-ming.huang@linaro.org> <20190321175217.wwkpqdmcanlytyzl@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: <20190321175217.wwkpqdmcanlytyzl@bivouac.eciton.net> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v3 05/18] Hisilicon/D06: Fix access variable fail issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 17:56:37 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Urgh, this was an unfortunate off-by-one post: I am deferring this patch until after Linaro's 2019.03 firmware release and cherry-picking it into that. There must be a better way to solve this. My comment referred to "Hisilicon/D06: Drop the leading 0 (0x0 -> 0x)", which will be pushed with an improved subject. / Leif On Thu, Mar 21, 2019 at 05:52:18PM +0000, Leif Lindholm wrote: > I will update the subject line to reflect what is actually being > changed. > > Other than that, > Reviewed-by: Leif Lindholm > > > On Wed, Mar 20, 2019 at 04:08:16PM +0800, Ming Huang wrote: > > From: Jason Zhang > > > > BmcWdtEnable is a field of OemConfigData structure, need have > > runtime service attribution if use it during exit boot service > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ming Huang > > --- > > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr | 2 +- > > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr > > index 470e9ace3dcf..08236704fbfe 100644 > > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr > > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr > > @@ -23,7 +23,7 @@ formset > > help = STRING_TOKEN(STR_OEM_CONFIG), > > classguid = gEfiIfrFrontPageGuid, // for MdeModule Bds. > > efivarstore OEM_CONFIG_DATA, > > - attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE, > > + attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS, > > name = OemConfig, > > guid = gOemConfigGuid; > > > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > > index 012d45bc0214..6668103af027 100644 > > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > > @@ -316,7 +316,7 @@ OemConfigUiLibConstructor ( > > Status = gRT->SetVariable ( > > OEM_CONFIG_NAME, > > &gOemConfigGuid, > > - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS, > > + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, > > sizeof (OEM_CONFIG_DATA), > > &Configuration > > ); > > -- > > 2.9.5 > >