public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Zhichao Gao <zhichao.gao@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: [PATCH 1/2] FmpDevicePkg/FmpDevucePkg.dec: Add a pcd
Date: Fri, 22 Mar 2019 10:22:35 +0800	[thread overview]
Message-ID: <20190322022236.544-2-zhichao.gao@intel.com> (raw)
In-Reply-To: <20190322022236.544-1-zhichao.gao@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1638

Add a pcd named PcdFmpDeviceImageDefaultTypeIdGuid. This is used
to provide a default Image Type Id for FmpDxe driver instead of
the gEfiCallerIdGuid.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 FmpDevicePkg/FmpDevicePkg.dec | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/FmpDevicePkg/FmpDevicePkg.dec b/FmpDevicePkg/FmpDevicePkg.dec
index ad0730a532..e9261b7e7f 100644
--- a/FmpDevicePkg/FmpDevicePkg.dec
+++ b/FmpDevicePkg/FmpDevicePkg.dec
@@ -7,7 +7,7 @@
 # customized using libraries and PCDs.
 #
 # Copyright (c) 2016, Microsoft Corporation. All rights reserved.<BR>
-# Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -121,5 +121,11 @@
   # @Prompt Firmware Device Lock Event GUID.
   gFmpDevicePkgTokenSpaceGuid.PcdFmpDeviceLockEventGuid|{0}|VOID*|0x4000000F
 
+  ## The default Image Type ID to use if none is specified by the FmpDeviceLib.
+  #  If this PCD is not a valid GUID value, the the FmpDxe driver will ASSERT
+  #  and fall back to the gEfiCallerIdGuid (FILE_GUID for the specific driver).
+  # @Prompt Firmware Device Default Image Type ID
+  gFmpDevicePkgTokenSpaceGuid.PcdFmpDeviceImageDefaultTypeIdGuid|{0}|VOID*|0x40000010
+
 [UserExtensions.TianoCore."ExtraFiles"]
   FmpDevicePkgExtra.uni
-- 
2.16.2.windows.1



  reply	other threads:[~2019-03-22  2:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22  2:22 [PATCH 0/2] FmpDevicePkg/FmpDxe: Change the default Image Type ID Zhichao Gao
2019-03-22  2:22 ` Zhichao Gao [this message]
2019-03-22  2:22 ` [PATCH 2/2] " Zhichao Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322022236.544-2-zhichao.gao@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox