From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6DC6E2194EB7C for ; Fri, 22 Mar 2019 11:56:29 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id y197so3194292wmd.0 for ; Fri, 22 Mar 2019 11:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pAKpek8OQI3rpAZ7MiypawH6P0zXNS0YHqStcnMZWeg=; b=jCaOqPhPB/X6qXC4Fnt1iRhmhiAo2J+gToAo9Ux1h9SdqoAPVXHPYgSEUZHHqVvf/n mqarB6Q0fMimNcspkpK3IZ/83IGdpQ85XBJhvkKOSHgCQ9BZZqm477Jylx5zPNiOvMCm fqiWXXy0NL5nRrbGlkhVHvYYNMoX4WMRV8Mgd3FB2TjJeu5NvMAK2QRiLXA8WBflyXQr Nx4dW4u0rjFw9zfopcQJfZNFvV0Ht0jvStq/AmnmGYQQj5l9XQF0kDhzRGnAXw9U7kUe pii7snBfz4A9ITo0xB4wNN/rk2sfHk6Kv5pCMAh5QlKAvhqa/hb2Fw376hCQql++nFW3 A9Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pAKpek8OQI3rpAZ7MiypawH6P0zXNS0YHqStcnMZWeg=; b=SAbM3FwSmNs5KtgtoyWBYpm5fPkEIpvSpIM6ym7koI8fD6dAHgW8TNJQlnh4tsjRZx 2T86u5SAY88PcNzINhvMh9TyPaw6As+RFwv85yHW97ZplYppqHmg/x455qhQvYar13OR f9qFQetZQF0/oOTbOjhSVizZH1WEVfcDM74I9jqzDZdbrjvdS7BjvmA0p+1PMWnoa3GW TwlSFMLViCtH5oRAd23HQXkX5pnXtOE4zKkup3FLeq4rMzbE1uqN6YemT/Mt+enI0e9X ixZ46rcYJrdm2aHrxt1Jy9u5wvtbHRyZivLSIAxugf9cFNixDS/hZZsblD1jqZugSkd7 1d4w== X-Gm-Message-State: APjAAAUPWpjQ6Ad0UAU4wNdme8e68eY7rIKMFyaVl+isR8Myep+/zvgW zT0gBt9whsfsxE+zJTCpsunv5A== X-Google-Smtp-Source: APXvYqxh+T5r7TJ1BuFSTgWCnYK5OrRZBpFLoJaAkRLbkwoXl8RT5hN9hdlyHFxDmoj9YgJ6js4P3A== X-Received: by 2002:a7b:c94c:: with SMTP id i12mr3992358wml.115.1553280986713; Fri, 22 Mar 2019 11:56:26 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t81sm5272601wmb.5.2019.03.22.11.56.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 11:56:25 -0700 (PDT) Date: Fri, 22 Mar 2019 18:56:24 +0000 From: Leif Lindholm To: Sami Mujawar Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, alexei.fedorov@arm.com, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Message-ID: <20190322185624.nbnhsmda7npth4vk@bivouac.eciton.net> References: <20190124154656.47016-1-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20190124154656.47016-1-sami.mujawar@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v3 0/4] Platform/ARM: Platform support for Dynamic Tables Framework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 18:56:29 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Sami, On the whole, this set looks fine - but: - could you go through and sort the #include files alphabetically in .c/.h (within each grouping)? - similarly, could you go through and ensure that .inf files contain alphabetically sorted [Sources], [Packages] and [LibraryClasses] sections? (The [*Pcd] sections are fine the way they are.) - Up to you, but if you would prefer to squash the set of minor updates into a v2 of this, I'd be OK with that. Best Regards, Leif On Thu, Jan 24, 2019 at 03:46:52PM +0000, Sami Mujawar wrote: > Dynamic Tables Framework aims to reduce the amount of effort > required for porting firmware to new platforms by simplifying > the generation of firmware tables based on hardware description > provided by a platform specific component. > > The Dynamic Tables Framework core queries the platform specific > component to retrieve the required hardware information for > generating standardised firmware tables at run-time. > > The platform specific component responsible for collating the > hardware information is called the Configuration Manager. > > This patch series introduce the Configuration Manager that > provides the hardware description to Dynamic Tables Framework. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > > The changes can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/365_dynamic_tables_framework_v3 > > This v3 patch series incorporates: > * updates corresponding to the dynamic tables framework's change > to support the newer versions of specifications. > * support for describing the platform GT Block timers on Juno. > * minor code improvements. > > The corresponding edk2 code changes can be seen at: > https://github.com/samimujawar/edk2/tree/365_dynamic_tables_framework_v2 > > Sami Mujawar (4): > Platform/ARM: Configuration Manager for Juno > Platform/ARM: Dynamic Tables support for Juno > Platform/ARM: Configuration Manager for FVP > Platform/ARM: Dynamic Tables support for FVP > > Platform/ARM/JunoPkg/ArmJuno.dsc | 12 +- > Platform/ARM/JunoPkg/ArmJuno.fdf | 12 + > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc | 29 + > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 752 ++++++++++++++++++++ > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 179 +++++ > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 86 +++ > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Platform.h | 99 +++ > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl | 276 +++++++ > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf | 45 ++ > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtJunoUsb.asl | 123 ++++ > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtPci.asl | 201 ++++++ > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtUart.asl | 48 ++ > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 9 +- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 15 + > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 16 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc | 31 + > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 684 ++++++++++++++++++ > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 181 +++++ > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 79 ++ > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Platform.h | 99 +++ > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl | 73 ++ > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf | 35 + > 22 files changed, 3079 insertions(+), 5 deletions(-) > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Platform.h > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtJunoUsb.asl > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtPci.asl > create mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtUart.asl > create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc > create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Platform.h > create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >