public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Sami Mujawar <sami.mujawar@arm.com>
Cc: edk2-devel@lists.01.org, alexei.fedorov@arm.com,
	Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com,
	nd@arm.com
Subject: Re: [PATCH v1 1/2] DynamicTablesPkg: Fix line endings in dsc file
Date: Tue, 26 Mar 2019 19:02:00 +0000	[thread overview]
Message-ID: <20190326190200.jqoqsrnzdznj2fo6@bivouac.eciton.net> (raw)
In-Reply-To: <20190326184439.31436-2-sami.mujawar@arm.com>

On Tue, Mar 26, 2019 at 06:44:38PM +0000, Sami Mujawar wrote:
> Changed the line endings to DOS line endings for
> DynamicTablesPkg/DynamicTablesPkg.dsc

Ah, yes, good old SMTP stripping CR.

I have a stupid script in my uefi-tools repo that I use to
line-convert patches from mailing lists.
https://git.linaro.org/uefi/uefi-tools.git/tree/edk2-to-git-am.sh

I'll remember to put any future sets to you on a branch, as you
helpfully do for me.

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> Cc: Alexei Fedorov <alexei.fedorov@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>  DynamicTablesPkg/DynamicTablesPkg.dsc | 88 ++++++++++----------
>  1 file changed, 44 insertions(+), 44 deletions(-)
> 
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc
> index f71120c2d359d715b8046b170025fe530387b6a8..a66bba976ccdf5ced9213eb464f3ac8f6fd52da4 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.dsc
> +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc
> @@ -1,44 +1,44 @@
> -## @file
> -#  Dsc file for Dynamic Tables Framework.
> -#
> -#  Copyright (c) 2019, Linaro Limited. All rights reserved.<BR>
> -#
> -#  This program and the accompanying materials are licensed and made available
> -#  under the terms and conditions of the BSD License which accompanies this
> -#  distribution.  The full text of the license may be found at
> -#  http://opensource.org/licenses/bsd-license.php
> -#
> -#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> -#  IMPLIED.
> -#
> -##
> -
> -[Defines]
> -  PLATFORM_NAME                  = DynamicTables
> -  PLATFORM_GUID                  = f39096a0-7a0a-442a-9413-cf584ef80cbb
> -  PLATFORM_VERSION               = 0.1
> -  DSC_SPECIFICATION              = 0x0001001a
> -  OUTPUT_DIRECTORY               = Build/DynamicTables
> -  SUPPORTED_ARCHITECTURES        = ARM|AARCH64
> -  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
> -  SKUID_IDENTIFIER               = DEFAULT
> -
> -!include DynamicTables.dsc.inc
> -
> -[LibraryClasses]
> -  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> -  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> -  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> -  IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
> -  MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> -  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> -  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> -  UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
> -  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> -
> -[LibraryClasses.ARM, LibraryClasses.AARCH64]
> -  PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
> -
> -[Components.common]
> -  DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf
> +## @file
> +#  Dsc file for Dynamic Tables Framework.
> +#
> +#  Copyright (c) 2019, Linaro Limited. All rights reserved.<BR>
> +#
> +#  This program and the accompanying materials are licensed and made available
> +#  under the terms and conditions of the BSD License which accompanies this
> +#  distribution.  The full text of the license may be found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> +#  IMPLIED.
> +#
> +##
> +
> +[Defines]
> +  PLATFORM_NAME                  = DynamicTables
> +  PLATFORM_GUID                  = f39096a0-7a0a-442a-9413-cf584ef80cbb
> +  PLATFORM_VERSION               = 0.1
> +  DSC_SPECIFICATION              = 0x0001001a
> +  OUTPUT_DIRECTORY               = Build/DynamicTables
> +  SUPPORTED_ARCHITECTURES        = ARM|AARCH64
> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
> +  SKUID_IDENTIFIER               = DEFAULT
> +
> +!include DynamicTables.dsc.inc
> +
> +[LibraryClasses]
> +  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> +  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> +  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> +  IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
> +  MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> +  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> +  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> +  UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
> +  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> +
> +[LibraryClasses.ARM, LibraryClasses.AARCH64]
> +  PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
> +
> +[Components.common]
> +  DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 


  reply	other threads:[~2019-03-26 19:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 18:44 [PATCH v1 0/2] DynamicTablesPkg: Fix line endings and disable deprecated APIs Sami Mujawar
2019-03-26 18:44 ` [PATCH v1 1/2] DynamicTablesPkg: Fix line endings in dsc file Sami Mujawar
2019-03-26 19:02   ` Leif Lindholm [this message]
2019-03-26 18:44 ` [PATCH v1 2/2] DynamicTablesPkg: Disable deprecated APIs Sami Mujawar
2019-06-11  8:48 ` [edk2-devel] [PATCH v1 0/2] DynamicTablesPkg: Fix line endings and disable " Alexei Fedorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190326190200.jqoqsrnzdznj2fo6@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox