public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Shenglei Zhang <shenglei.zhang@intel.com>
To: edk2-devel@lists.01.org
Cc: Jaben Carsey <jaben.carsey@intel.com>, Ray Ni <ray.ni@intel.com>
Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib
Date: Fri, 29 Mar 2019 09:41:24 +0800	[thread overview]
Message-ID: <20190329014126.20208-3-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20190329014126.20208-1-shenglei.zhang@intel.com>

With Itanium architecture unsupported, gEfiSalSystemTableGuid
and gEfiMpsTableGuid will be no longer used.
https://bugzilla.tianocore.org/show_bug.cgi?id=1560

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c     | 10 ----------
 .../UefiShellDebug1CommandsLib.inf                     |  2 --
 2 files changed, 12 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
index a4c18c9b68..023806742d 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
@@ -17,9 +17,7 @@
 #include "UefiShellDebug1CommandsLib.h"
 #include <Protocol/PciRootBridgeIo.h>
 #include <Guid/Acpi.h>
-#include <Guid/Mps.h>
 #include <Guid/SmBios.h>
-#include <Guid/SalSystemTable.h>
 
 /**
   Make a printable character.
@@ -186,10 +184,6 @@ ShellCommandRunDmem (
               AcpiTableAddress = (UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
               continue;
             }
-            if (CompareGuid(&gST->ConfigurationTable[TableWalker].VendorGuid, &gEfiSalSystemTableGuid)) {
-              SalTableAddress = (UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
-              continue;
-            }
             if (CompareGuid(&gST->ConfigurationTable[TableWalker].VendorGuid, &gEfiSmbiosTableGuid)) {
               SmbiosTableAddress = (UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
               continue;
@@ -198,10 +192,6 @@ ShellCommandRunDmem (
               SmbiosTableAddress = (UINT64) (UINTN) gST->ConfigurationTable[TableWalker].VendorTable;
               continue;
             }
-            if (CompareGuid(&gST->ConfigurationTable[TableWalker].VendorGuid, &gEfiMpsTableGuid)) {
-              MpsTableAddress = (UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
-              continue;
-            }
           }
 
           ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_DMEM_SYSTEM_TABLE), gShellDebug1HiiHandle,
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
index ec1f87ae19..f2666b7ff9 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
@@ -130,8 +130,6 @@
   gEfiGlobalVariableGuid          ## SOMETIMES_CONSUMES ## GUID
   gEfiSmbiosTableGuid             ## SOMETIMES_CONSUMES ## SystemTable
   gEfiSmbios3TableGuid            ## SOMETIMES_CONSUMES ## SystemTable
-  gEfiMpsTableGuid                ## SOMETIMES_CONSUMES ## SystemTable
-  gEfiSalSystemTableGuid          ## SOMETIMES_CONSUMES ## SystemTable
   gEfiAcpi10TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
   gEfiAcpi20TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
   gShellDebug1HiiGuid             ## SOMETIMES_CONSUMES ## HII
-- 
2.18.0.windows.1



  parent reply	other threads:[~2019-03-29  1:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29  1:41 [PATCH 0/4] Remove IPF and related code Shenglei Zhang
2019-03-29  1:41 ` [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h Shenglei Zhang
2019-04-01 12:10   ` Laszlo Ersek
2019-04-09  1:07   ` [edk2] " Zhang, Shenglei
2019-04-09  7:21     ` Laszlo Ersek
2019-03-29  1:41 ` Shenglei Zhang [this message]
2019-03-29  1:49   ` [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib Ni, Ray
2019-03-29  2:54     ` Carsey, Jaben
2019-03-29  1:41 ` [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids Shenglei Zhang
2019-03-29  1:49   ` Ni, Ray
2019-03-29  2:54     ` Carsey, Jaben
2019-03-29  1:41 ` [PATCH 4/4] MdePkg: Removed IPF related code Shenglei Zhang
2019-04-09  0:47   ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190329014126.20208-3-shenglei.zhang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox