public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Zailiang Sun <zailiang.sun@intel.com>
To: edk2-devel@lists.01.org
Cc: David Wei <david.wei@intel.com>, Yi Qian <yi.qian@intel.com>
Subject: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Fix issue with SOURCE_DEBUG_ENABLE
Date: Fri, 29 Mar 2019 15:13:27 +0800	[thread overview]
Message-ID: <20190329071327.19112-1-zailiang.sun@intel.com> (raw)

https://bugzilla.tianocore.org/show_bug.cgi?id=1671

Build fails when SOURCE_DEBUG_ENABLE is set to TRUE. This is due to
limited size of FV MAIN region. To work around the issue, we increase
size for the region by another 320KB provided that MINNOW2_FSP_BUILD
is set to FALSE.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun <zailiang.sun@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
---
 Vlv2TbltDevicePkg/PlatformPkg.fdf | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf b/Vlv2TbltDevicePkg/PlatformPkg.fdf
index 4c19f156ea..84e3014178 100644
--- a/Vlv2TbltDevicePkg/PlatformPkg.fdf
+++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf
@@ -47,8 +47,13 @@ DEFINE FLASH_REGION_AZALIABIN_BASE                            = 0xFFD08000
 
 !endif
 
+!if $(MINNOW2_FSP_BUILD) == TRUE
 DEFINE FLASH_REGION_FVMAIN_OFFSET                             = 0x00110000
 DEFINE FLASH_REGION_FVMAIN_SIZE                               = 0x00210000
+!else
+DEFINE FLASH_REGION_FVMAIN_OFFSET                             = 0x000C0000
+DEFINE FLASH_REGION_FVMAIN_SIZE                               = 0x00260000
+!endif
 
 DEFINE FLASH_REGION_FV_RECOVERY2_OFFSET                       = 0x00320000
 DEFINE FLASH_REGION_FV_RECOVERY2_SIZE                         = 0x00070000
-- 
2.19.1.windows.1



             reply	other threads:[~2019-03-29  7:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29  7:13 Zailiang Sun [this message]
2019-03-29  7:14 ` [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Fix issue with SOURCE_DEBUG_ENABLE Qian, Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190329071327.19112-1-zailiang.sun@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox