From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::643; helo=mail-pl1-x643.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A05CB2194EB7B for ; Sun, 31 Mar 2019 20:27:19 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id b3so769084plr.7 for ; Sun, 31 Mar 2019 20:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=dlvnClIoTZXu1yt9AXeZuztIWQkuYhLPcQjoM6F8Dpk=; b=B6TvjgdHWN8P8TRVCzbuEHa7QxWwcGon/OEijSLzk0uNTbyPY/Oc+KlVaezXyWfMSp 6dfdPF47c3h72KawHo5LwiSa+yuO92eLRwmlOFVgp66+miINuV75qMMYpTi3svxSRxhn gmNHIepNJzVhwaoK1zckyseKcypbUfvGFKgsWcMlZysQHXw6CMGTVnaV41o5N3VYpRzD S3+uTK97ba1RnOAwkAUQjROFPSYcjyCTTQ3PB2DEwkuBiCiUqm3Ol7EfyO61kDYLoWCE TR136+/aqHgxmwWUtWQtBuSrEHH8M0ykxr/+uawgYZ+wY5l+ltnNUQCBw4XMlVk3GFSB 3kKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dlvnClIoTZXu1yt9AXeZuztIWQkuYhLPcQjoM6F8Dpk=; b=cHmtO5xnB515+1a+anVWOEESpS9XWFDFQz7scvLYoXxl33g2/Md/0e7exO7NaUuV8V ratUHvG2tn87frkCY10uEcpr8Lob5FNzETxUV+Cgu9xtpk2nH3sdC7XfWJY5m1OFlIOW tLX/kvUF3V8ZT6+BqFLe0NvbjB98gtK1rmixFcqT1aJeAiz09wZQ97gPzScD6rwGhBJI e44S8owN8z+rjPctVH7p1l+TTM8TxvFUhCQCImYtunKathCWdh7ONxPkH52n6XzS95w6 7JnGTRF76Cwxoibtdm/b3Ab1kgRPQqmzQlLssXwaSTRsee75y344u9MoQZ3clCSCoo8s wdMA== X-Gm-Message-State: APjAAAXMcPysn+19Ga8ySM7x5OCdNYABKvzQZrCTsc1ZBz+P3mlicl2G F3ke8EMpH1sUupghCtq+BjRA7CNs2zHsQw== X-Google-Smtp-Source: APXvYqzGPjO8R1rq+HTIwuCYdUwUBvdxWzbbxiNGBmd5m+vpjSoRCrLFHWlyp6qT8erXHxuGpiRoFQ== X-Received: by 2002:a17:902:e393:: with SMTP id ch19mr8286771plb.117.1554089238200; Sun, 31 Mar 2019 20:27:18 -0700 (PDT) Received: from mba13.imgcgcw.net ([147.50.13.10]) by smtp.gmail.com with ESMTPSA id 16sm12758092pfz.106.2019.03.31.20.27.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Mar 2019 20:27:17 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Cc: Ard Biesheuvel , Vincent Zimmer , Brian Richardson , Michael D Kinney , Andrew Fish , Leif Lindholm , Star Zeng , Eric Dong , Ruiyu Ni , Liming Gao , Jaben Carsey , Steven Shi Date: Mon, 1 Apr 2019 10:27:02 +0700 Message-Id: <20190401032709.14787-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 Subject: [PATCH v4 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 03:27:19 -0000 Add the basic plumbing to DXE core, the PCI bus driver and the boot manager to allow PE/COFF images to be dispatched that target an architecture that is not native for the platform, but which is supported by one of potentially several available emulators. One implementation of such an emulator can be found here: https://github.com/ardbiesheuvel/X86EmulatorPkg/tree/upstream-v4 This also allows us to get rid of the special treatment of EBC images in core code. Instead, the EbcDxe driver is augmented with an implementation of the EDK2 PE/COFF image emulator protocol so that internal knowledge of how EBC is implemented (I-cache flushing, thunks) is removed from the DXE core. Changes since v3: - Simplify the handling of option ROMs and Driver#### images, by simply deferring to the LoadImage() boot service to decide whether an image can be supported or not - this removes some redundant checks from the BDS layer and the PCI bus driver. - Move the machine type supported by the emulator into the protocol struct, so we can optimize away calls into the emulator for each image loaded. Instead, the LoadImage() code will only invoke the IsSupported() method for images that are known to have a matching machine type. Note that I have considered, but ultimately dismissed the suggestion to register and unregister emulators via a new protocol. The main issue is that registering and unregistering struct containing sets of function pointers is awfully similar to managing a protocol database, and we already have the code to do that in EDK2. So instead, I have removed all the code that iterates over a handle buffer of emu protocols and invokes each one to see if it will support the image. Instead, this is all done by CoreLoadImage(). Changes since v2: - incorporate feedback from Andrew Fish (delivered in person): * pass a device path into the IsImageSupported() protocol method so that an implementation can blacklist or whitelist certain devices, or implement other policies that depend on the device where the driver originated * allow the emulator to supersede the native loading of the image - this permits things like X86 on X86 emulators for security sandboxing or debug Changes since v1: - subsume the EBC handling into the EDK2 emulator protocol and abstract away from EBC specifics in core code. - allow multiple emulator implementations to co-exist - incorporate Star's review feedback Cc: Vincent Zimmer Cc: Brian Richardson Cc: Michael D Kinney Cc: Andrew Fish Cc: Leif Lindholm Cc: Star Zeng Cc: Eric Dong Cc: Ruiyu Ni Cc: Liming Gao Cc: Jaben Carsey Cc: Steven Shi Ard Biesheuvel (7): MdeModulePkg: introduce PE/COFF image emulator protocol MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures MdeModulePkg/UefiBootManagerLib: allow foreign Driver#### images MdeModulePkg/EbcDxe: implement the PE/COFF emulator protocol MdePkg/UefiBaseType.h: treat EBC as a non-native machine type MdeModulePkg/DxeCore: remove explicit EBC handling .../Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 7 - MdeModulePkg/Core/Dxe/DxeMain.h | 6 +- MdeModulePkg/Core/Dxe/DxeMain.inf | 2 +- MdeModulePkg/Core/Dxe/Image/Image.c | 183 ++++++++++++------ .../Include/Protocol/PeCoffImageEmulator.h | 107 ++++++++++ .../Library/UefiBootManagerLib/BmLoadOption.c | 6 +- MdeModulePkg/MdeModulePkg.dec | 4 + MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 3 + MdeModulePkg/Universal/EbcDxe/EbcDxe.inf | 3 + MdeModulePkg/Universal/EbcDxe/EbcInt.c | 123 ++++++++++++ MdeModulePkg/Universal/EbcDxe/EbcInt.h | 3 + MdePkg/Include/Uefi/UefiBaseType.h | 6 +- 12 files changed, 381 insertions(+), 72 deletions(-) create mode 100644 MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h -- 2.17.1