From: Leif Lindholm <leif.lindholm@linaro.org>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laszlo Ersek <lersek@redhat.com>, Andrew Fish <afish@apple.com>
Subject: Re: [Patch 0/4] Normalize line endings to CRLF in ARM packages
Date: Thu, 4 Apr 2019 04:54:37 +0100 [thread overview]
Message-ID: <20190404035437.qcale3g5qekzb53d@bivouac.eciton.net> (raw)
In-Reply-To: <20190403220014.14468-1-michael.d.kinney@intel.com>
Hi Mike,
This looks fine. But I did have one thought:
If we're just about to touch pretty much every file in the tree anyway
- can we consider doing the full conversion to native line endings at
the same time?
(This doesn't help the 'git blame' problem, it just reminded me.)
/
Leif
On Wed, Apr 03, 2019 at 03:00:10PM -0700, Kinney, Michael D wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1659
>
> Normalize line endings to use CRLF to pass PatchCheck.py
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Kinney, Michael D (4):
> ArmPkg/ArmScmiDxe: Remove non-ASCII character in comment
> ArmPkg: Normalize line endings to CRLF
> ArmVirtPkg: Normalize line endings to CRLF
> ArmPlatformPkg: Normalize line endings to CRLF
>
> .../ArmScmiPerformanceProtocolPrivate.h | 2 +-
> ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c | 44 +-
> .../ArmSmcPsciResetSystemLib/AArch64/Reset.S | 60 +-
> .../AArch64/Reset.asm | 70 +-
> .../ArmSmcPsciResetSystemLib/Arm/Reset.S | 58 +-
> .../ArmSmcPsciResetSystemLib/Arm/Reset.asm | 68 +-
> ArmPkg/Library/CompilerIntrinsicsLib/memset.c | 124 ++--
> ArmPkg/Library/GccLto/liblto-aarch64.s | 54 +-
> ArmPkg/Library/GccLto/liblto-arm.s | 122 ++--
> ArmPlatformPkg/Scripts/Ds5/profile.py | 668 +++++++++---------
> ArmVirtPkg/Include/Platform/Hidden.h | 56 +-
> 11 files changed, 663 insertions(+), 663 deletions(-)
>
> --
> 2.21.0.windows.1
>
next prev parent reply other threads:[~2019-04-04 3:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 22:00 [Patch 0/4] Normalize line endings to CRLF in ARM packages Michael D Kinney
2019-04-03 22:00 ` [Patch 1/4] ArmPkg/ArmScmiDxe: Remove non-ASCII character in comment Michael D Kinney
2019-04-03 22:00 ` [Patch 2/4] ArmPkg: Normalize line endings to CRLF Michael D Kinney
2019-04-03 22:00 ` [Patch 3/4] ArmVirtPkg: " Michael D Kinney
2019-04-04 12:52 ` [edk2-devel] " Laszlo Ersek
2019-04-04 16:55 ` Michael D Kinney
2019-04-03 22:00 ` [Patch 4/4] ArmPlatformPkg: " Michael D Kinney
2019-04-04 3:54 ` Leif Lindholm [this message]
2019-04-04 10:39 ` [Patch 0/4] Normalize line endings to CRLF in ARM packages Laszlo Ersek
2019-04-04 17:00 ` Michael D Kinney
2019-04-04 17:17 ` [edk2-devel] " Kevin@Insyde
2019-04-05 3:24 ` Leif Lindholm
2019-04-05 18:11 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404035437.qcale3g5qekzb53d@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox