From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=bGJFgHGN; spf=pass (domain: linaro.org, ip: 209.85.221.51, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by groups.io with SMTP; Wed, 03 Apr 2019 20:54:41 -0700 Received: by mail-wr1-f51.google.com with SMTP id t17so1596379wrw.13 for ; Wed, 03 Apr 2019 20:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HRMkcIHoz3KVMqVsTgu0rKXP2n6awdNmlmlANrKwk1Y=; b=bGJFgHGNUwb+y/ogPsnnRwYk1kdBxyzbFeWj7g5S6KvCJIvfQWeNjveijMPE+/d5Fk nXELWFY2JSAslV3RRA7mQo56Y2O5ZZTwPl1vw/XxsbkvVKsWZ/ZWNIv1oC48itTYsz29 rUOhMxWk7O7CAFsQ9F7VwwdsIm6VbDbfKZN/ptXvlm9y4zdsTqj2AeyBVjcrn4C/N4qE xDnO80GoCUNozxzR1oqp0STvf0StzkFqA72lsUxhHPXsbFTnh3Iz96oIt2G5mYos2kT6 TUuCyYIvjbQohaUhCAEdaLIWvSoNs2ZePBq4eYj9HwWUlhWWb+OnoNh8eqGTJw/0vNx4 hROg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HRMkcIHoz3KVMqVsTgu0rKXP2n6awdNmlmlANrKwk1Y=; b=aFuNyLmi6rPydp7PyDQT8v0FE94gyE5hj5/oc/CaKWTxRSiMHzK7nX/c7b68GFuGKd XvINTPtXw0nzKmzyahjr210wB8FsnHdxPpICU9eB5ytYnbuama6t7hb+lCZcTiCpBKcU lfB5xKim7RgVRvXRIL584TBL9HD+8nxaszkmo5wJ8OtnLrJ+/dPPiVLpfLVaJsvUqRdp R2tTp+Rzi/G3N+BZCxpOVM60s3J/mGH/2isMmoIWNnkCDUqkEiwLkUW+zH9EBUVNp1pR XwWzyfzzrvTJsCy9vdNr/NKeAMGu0QKW7zhixGWev7G5MMNtwo9RIzKz550o+Wgar1H+ QWXA== X-Gm-Message-State: APjAAAWrkCeFzwQGC199zTEpFbed277ilXID6spWHFdxzYVmp3GM5XbI fE8Zp62wliulsOlPPhPQjT2X4w== X-Google-Smtp-Source: APXvYqzCoHOeNv0rVuGHg9dFH/fRJHCGi75moLz24lJlHE1VmD38UT9zADsmVPldlolZ4lLglBOKcA== X-Received: by 2002:adf:fc0b:: with SMTP id i11mr1966494wrr.145.1554350079438; Wed, 03 Apr 2019 20:54:39 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x5sm16037719wrt.72.2019.04.03.20.54.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 20:54:38 -0700 (PDT) Date: Thu, 4 Apr 2019 04:54:37 +0100 From: Leif Lindholm To: "Kinney, Michael D" Cc: devel@edk2.groups.io, Ard Biesheuvel , Laszlo Ersek , Andrew Fish Subject: Re: [Patch 0/4] Normalize line endings to CRLF in ARM packages Message-ID: <20190404035437.qcale3g5qekzb53d@bivouac.eciton.net> References: <20190403220014.14468-1-michael.d.kinney@intel.com> MIME-Version: 1.0 In-Reply-To: <20190403220014.14468-1-michael.d.kinney@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Mike, This looks fine. But I did have one thought: If we're just about to touch pretty much every file in the tree anyway - can we consider doing the full conversion to native line endings at the same time? (This doesn't help the 'git blame' problem, it just reminded me.) / Leif On Wed, Apr 03, 2019 at 03:00:10PM -0700, Kinney, Michael D wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1659 > > Normalize line endings to use CRLF to pass PatchCheck.py > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael D Kinney > > Kinney, Michael D (4): > ArmPkg/ArmScmiDxe: Remove non-ASCII character in comment > ArmPkg: Normalize line endings to CRLF > ArmVirtPkg: Normalize line endings to CRLF > ArmPlatformPkg: Normalize line endings to CRLF > > .../ArmScmiPerformanceProtocolPrivate.h | 2 +- > ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c | 44 +- > .../ArmSmcPsciResetSystemLib/AArch64/Reset.S | 60 +- > .../AArch64/Reset.asm | 70 +- > .../ArmSmcPsciResetSystemLib/Arm/Reset.S | 58 +- > .../ArmSmcPsciResetSystemLib/Arm/Reset.asm | 68 +- > ArmPkg/Library/CompilerIntrinsicsLib/memset.c | 124 ++-- > ArmPkg/Library/GccLto/liblto-aarch64.s | 54 +- > ArmPkg/Library/GccLto/liblto-arm.s | 122 ++-- > ArmPlatformPkg/Scripts/Ds5/profile.py | 668 +++++++++--------- > ArmVirtPkg/Include/Platform/Hidden.h | 56 +- > 11 files changed, 663 insertions(+), 663 deletions(-) > > -- > 2.21.0.windows.1 >