From: "Rebecca Cran" <rebecca@bluestop.org>
To: devel@edk2.groups.io, Liming Gao <liming.gao@intel.com>
Cc: Rebecca Cran <rebecca@bluestop.org>
Subject: [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output
Date: Thu, 4 Apr 2019 11:56:16 -0600 [thread overview]
Message-ID: <20190404175616.51393-1-rebecca@bluestop.org> (raw)
Fix a few typos in LegacyBiosBuildE820, and improve the debug output of
the E820 table to pad with zeros instead of spaces, remove extra hyphens
and display the memory type in decimal.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
---
.../Csm/LegacyBiosDxe/LegacyBootSupport.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
index a7b8e6a9a0..8c415cdfc6 100644
--- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
+++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
@@ -1711,9 +1711,9 @@ LegacyBiosBuildE820 (
do {
//
- // Use size returned back plus 1 descriptor for the AllocatePool.
+ // Use size returned for the AllocatePool.
// We don't just multiply by 2 since the "for" loop below terminates on
- // EfiMemoryMapEnd which is dependent upon EfiMemoryMapSize. Otherwize
+ // EfiMemoryMapEnd which is dependent upon EfiMemoryMapSize. Otherwise
// we process bogus entries and create bogus E820 entries.
//
EfiMemoryMap = (EFI_MEMORY_DESCRIPTOR *) AllocatePool (EfiMemoryMapSize);
@@ -1801,7 +1801,7 @@ LegacyBiosBuildE820 (
MemoryBlockLength = (UINT64) (LShiftU64 (EfiEntry->NumberOfPages, 12));
if ((EfiEntry->PhysicalStart + MemoryBlockLength) < 0x100000) {
//
- // Skip the memory block is under 1MB
+ // Skip the memory block if under 1MB
//
} else {
if (EfiEntry->PhysicalStart < 0x100000) {
@@ -1926,7 +1926,7 @@ LegacyBiosBuildE820 (
*Size = (UINTN) (Index * sizeof (EFI_E820_ENTRY64));
//
- // Determine OS usable memory above 1Mb
+ // Determine OS usable memory above 1MB
//
Private->IntThunk->EfiToLegacy16BootTable.OsMemoryAbove1Mb = 0x0000;
for (TempIndex = Above1MIndex; TempIndex < Index; TempIndex++) {
@@ -1948,7 +1948,7 @@ LegacyBiosBuildE820 (
// Print DEBUG information
//
for (TempIndex = 0; TempIndex < Index; TempIndex++) {
- DEBUG((EFI_D_INFO, "E820[%2d]: 0x%16lx ---- 0x%16lx, Type = 0x%x \n",
+ DEBUG((EFI_D_INFO, "E820[%2d]: 0x%016lx - 0x%016lx, Type = %d\n",
TempIndex,
E820Table[TempIndex].BaseAddr,
(E820Table[TempIndex].BaseAddr + E820Table[TempIndex].Length),
--
2.21.0
next reply other threads:[~2019-04-04 17:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 17:56 Rebecca Cran [this message]
2019-04-05 9:05 ` [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output Philippe Mathieu-Daudé
2019-04-08 13:15 ` Liming Gao
[not found] ` <1593821D7C44BA9C.31892@groups.io>
2019-04-11 0:32 ` Liming Gao
2019-04-11 10:59 ` Philippe Mathieu-Daudé
2019-04-11 13:52 ` Liming Gao
2019-04-11 14:32 ` Philippe Mathieu-Daudé
2019-04-11 17:35 ` Laszlo Ersek
2019-04-11 19:30 ` Rebecca Cran
[not found] ` <1594824AB9352AE7.21554@groups.io>
2019-04-11 19:53 ` rebecca
2019-04-11 19:59 ` Philippe Mathieu-Daudé
2019-04-12 7:50 ` Laszlo Ersek
2019-04-12 8:12 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404175616.51393-1-rebecca@bluestop.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox