From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: citrix.com, ip: 162.221.156.55, mailfrom: prvs=99536ed25=anthony.perard@citrix.com) Received: from SMTP03.CITRIX.COM (SMTP03.CITRIX.COM [162.221.156.55]) by groups.io with SMTP; Tue, 09 Apr 2019 03:50:31 -0700 X-IronPort-AV: E=Sophos;i="5.60,329,1549929600"; d="scan'208";a="83093726" Date: Tue, 9 Apr 2019 11:50:27 +0100 From: "Anthony PERARD" To: Laszlo Ersek CC: , Julien Grall , "Ard Biesheuvel" , Jordan Justen , , Leif Lindholm , edk2-devel-groups-io Subject: Re: [PATCH v2 00/31] Specific platform to run OVMF in Xen PVH and HVM guests Message-ID: <20190409105027.GC1435@perard.uk.xensource.com> References: <20190408142408.30419-1-anthony.perard@citrix.com> <6c00d5f5-e187-5fe2-8b3e-301ec51efb6b@redhat.com> MIME-Version: 1.0 In-Reply-To: <6c00d5f5-e187-5fe2-8b3e-301ec51efb6b@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Apr 08, 2019 at 05:50:57PM +0200, Laszlo Ersek wrote: > On 04/08/19 16:23, Anthony PERARD wrote: > > Question: > > > > Should we start moving these to a different *Pkg? Like it's done for > > ArmPkg and ArmVirtPkg? Maybe XenPkg. > > I'm pretty happy with the current package structure. ArmPkg is for both > physical and virtual hardware. ArmVirtPkg is virt-only, and we already > have separate platform DSCs/FDFs between Xen (ArmVirtXen) and QEMU/KVM > (ArmVirtQemu[Kernel]). Xen- and QEMU/KVM-specific drivers and library > instances peacefully coexist under ArmVirtPkg; the DSCs/FDFs include > them as appropriate. > > The same should map nicely to OvmfPkg. x86 stuff that targets both > physical and virtual hardware belongs under PcAtChipsetPkg and > UefiCpuPkg. Virt-only stuff should go under OvmfPkg; Xen-specific and > QEMU/KVM-specific modules can coexist under OvmfPkg. It's sufficient if > the platform DSCs cherry-pick them as appropriate. Thanks for the feedback, that sounds good. > > To build and boot: > > > > To build, simply run OvmfPkg/build.sh -p OvmfPkg/XenOvmf.dsc > > (1) To stick with the ArmVirt pattern, we should initially call this > platform OvmfXen. I'll rename it in v3. > (3) Please file a BZ at about this > feature, and assign it to yourself. The BZ should keep track of all > versions of the patch series (from the mailing list archive). Done: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 I'll add the links for the patch series once there is one for v2. > (5) The BZ should be referenced in all the commit messages. I'll do that in v3. > (6) The new edk2 development mailing list is at: :-( > https://edk2.groups.io/g/devel > > Please subscribe there, and resend this series to that address, i.e. > . I'm CC'ing the new address myself, for this > initial response, but I'd prefer the rest of my comments to go only to > the new list (without manually updating the CC list on every response). I'm about to do that. Thanks, -- Anthony PERARD