From: "Jordan Justen" <jordan.l.justen@intel.com>
To: devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v2 2/6] MdeModulePkg/Core/Pei: Add AARCH64 assembly for TemporaryRamMigration
Date: Wed, 10 Apr 2019 01:39:56 -0700 [thread overview]
Message-ID: <20190410084000.19660-3-jordan.l.justen@intel.com> (raw)
In-Reply-To: <20190410084000.19660-1-jordan.l.justen@intel.com>
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
.../AArch64/TemporaryRamMigration.S | 63 +++++++++++++++++++
.../AArch64/TemporaryRamMigration.asm | 63 +++++++++++++++++++
MdeModulePkg/Core/Pei/PeiMain.inf | 4 ++
3 files changed, 130 insertions(+)
create mode 100644 MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.S
create mode 100644 MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.asm
diff --git a/MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.S b/MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.S
new file mode 100644
index 0000000000..e73932daff
--- /dev/null
+++ b/MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.S
@@ -0,0 +1,63 @@
+#------------------------------------------------------------------------------
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+#------------------------------------------------------------------------------
+
+.text
+.align 5
+
+GCC_ASM_EXPORT(PeiTemporaryRamMigration)
+
+#------------------------------------------------------------------------------
+# VOID
+# EFIAPI
+# PeiTemporaryRamMigration (
+# IN PEI_CORE_TEMPORARY_RAM_TRANSITION *TempRamTransitionData
+# );
+#
+# @param[in] x0 Pointer to PEI_CORE_TEMPORARY_RAM_TRANSITION
+#
+# @return None This routine does not return
+#------------------------------------------------------------------------------
+ASM_PFX(PeiTemporaryRamMigration):
+
+ #
+ # We store the TempRamTransitionData pointer in x19. By the
+ # AArch64 calling convention we should normally save x19, but we
+ # won't be returning to the caller, so we don't need to save it.
+ # By the same rule, the TemporaryRamMigration PPI call should
+ # preserve x19 for us.
+ #
+ mov x19, x0
+
+ #
+ # Setup parameters and call TemporaryRamSupport->TemporaryRamMigration
+ # (rcx) PeiServices
+ # (rdx) TemporaryMemoryBase
+ # (r8) PermanentMemoryBase
+ # (r9) CopySize
+ #
+ ldp x0, x1, [x19, 0x08]
+ ldp x2, x3, [x19, 0x18]
+
+ #
+ # (x19) Pointer to PEI_CORE_TEMPORARY_RAM_TRANSITION on stack
+ #
+ # Adjusted based on stack change made during
+ # TemporaryRamSupport->TemporaryRamMigration call
+ #
+ ldr x4, [x19]
+ mov x5, sp
+ sub x19, x19, x5
+ blr x4
+ mov x5, sp
+ add x19, x19, x5
+
+ #
+ # Setup parameters and call PeiTemporaryRamMigrated
+ # (x0) Pointer to PEI_CORE_TEMPORARY_RAM_TRANSITION
+ #
+ mov x0, x19
+ bl ASM_PFX(PeiTemporaryRamMigrated)
diff --git a/MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.asm b/MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.asm
new file mode 100644
index 0000000000..fbffd16c52
--- /dev/null
+++ b/MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.asm
@@ -0,0 +1,63 @@
+;------------------------------------------------------------------------------
+;
+; Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+; SPDX-License-Identifier: BSD-2-Clause-Patent
+;
+;------------------------------------------------------------------------------
+
+ EXPORT PeiTemporaryRamMigration
+ AREA PeiCore_LowLevel, CODE, READONLY
+
+;------------------------------------------------------------------------------
+; VOID
+; EFIAPI
+; PeiTemporaryRamMigration (
+; IN PEI_CORE_TEMPORARY_RAM_TRANSITION *TempRamTransitionData
+; );
+;
+; @param[in] x0 Pointer to PEI_CORE_TEMPORARY_RAM_TRANSITION
+;
+; @return None This routine does not return
+;------------------------------------------------------------------------------
+PeiTemporaryRamMigration
+
+ ;
+ ; We store the TempRamTransitionData pointer in x19. By the
+ ; AArch64 calling convention we should normally save x19, but we
+ ; won't be returning to the caller, so we don't need to save it.
+ ; By the same rule, the TemporaryRamMigration PPI call should
+ ; preserve x19 for us.
+ ;
+ mov x19, x0
+
+ ;
+ ; Setup parameters and call TemporaryRamSupport->TemporaryRamMigration
+ ; (rcx) PeiServices
+ ; (rdx) TemporaryMemoryBase
+ ; (r8) PermanentMemoryBase
+ ; (r9) CopySize
+ ;
+ ldp x0, x1, [x19, 0x08]
+ ldp x2, x3, [x19, 0x18]
+
+ ;
+ ; (x19) Pointer to PEI_CORE_TEMPORARY_RAM_TRANSITION on stack
+ ;
+ ; Adjusted based on stack change made during
+ ; TemporaryRamSupport->TemporaryRamMigration call
+ ;
+ ldr x4, [x19]
+ mov x5, sp
+ sub x19, x19, x5
+ blr x4
+ mov x5, sp
+ add x19, x19, x5
+
+ ;
+ ; Setup parameters and call PeiTemporaryRamMigrated
+ ; (x0) Pointer to PEI_CORE_TEMPORARY_RAM_TRANSITION
+ ;
+ mov x0, x19
+ bl ASM_PFX(PeiTemporaryRamMigrated)
+
+ END
diff --git a/MdeModulePkg/Core/Pei/PeiMain.inf b/MdeModulePkg/Core/Pei/PeiMain.inf
index c8a6d5b80b..95ef7bb006 100644
--- a/MdeModulePkg/Core/Pei/PeiMain.inf
+++ b/MdeModulePkg/Core/Pei/PeiMain.inf
@@ -47,6 +47,10 @@
PciCfg2/PciCfg2.c
PeiMain.h
+[Sources.AARCH64]
+ Dispatcher/AArch64/TemporaryRamMigration.asm | MSFT
+ Dispatcher/AArch64/TemporaryRamMigration.S | GCC
+
[Packages]
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
--
2.20.1
next prev parent reply other threads:[~2019-04-10 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 8:39 [PATCH v2 0/6] Fix PEI Core issue during TemporaryRamMigration Jordan Justen
2019-04-10 8:39 ` [PATCH v2 1/6] MdeModulePkg/Core/Pei: Add interface for assembly based TemporaryRamSupport Jordan Justen
2019-04-10 8:39 ` Jordan Justen [this message]
2019-04-10 8:39 ` [PATCH v2 3/6] MdeModulePkg/Core/Pei: Add ARM assembly for TemporaryRamMigration Jordan Justen
2019-04-10 8:39 ` [PATCH v2 4/6] MdeModulePkg/Core/Pei: Add IA32 " Jordan Justen
2019-04-10 8:39 ` [PATCH v2 5/6] MdeModulePkg/Core/Pei: Add X64 " Jordan Justen
2019-04-10 8:40 ` [PATCH v2 6/6] MdeModulePkg/Core/Pei: Use code path for assembly based TemporaryRamSupport Jordan Justen
2019-04-10 16:41 ` [edk2-devel] [PATCH v2 0/6] Fix PEI Core issue during TemporaryRamMigration Ard Biesheuvel
2019-04-10 18:28 ` Laszlo Ersek
2019-04-10 18:31 ` Ard Biesheuvel
2019-04-10 18:54 ` Jordan Justen
2019-04-10 17:26 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410084000.19660-3-jordan.l.justen@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox