From: "Anthony PERARD" <anthony.perard@citrix.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: <edk2-devel@lists.01.org>, <jordan.l.justen@intel.com>,
<lersek@redhat.com>, <ard.biesheuvel@linaro.org>,
<julien.grall@arm.com>, <xen-devel@lists.xenproject.org>,
<devel@edk2.groups.io>
Subject: Re: [PATCH v2 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture
Date: Thu, 11 Apr 2019 14:07:32 +0100 [thread overview]
Message-ID: <20190411130732.GK1435@perard.uk.xensource.com> (raw)
In-Reply-To: <1554779560-26204-2-git-send-email-igor.druzhinin@citrix.com>
On Tue, Apr 09, 2019 at 04:12:38AM +0100, Igor Druzhinin wrote:
> This aperture doesn't exist in QEMU-XEN and hvmloader places BARs
> in arbitrary order disregarding prefetchable bit. This makes
> prefetchable and non-prefetchable BARs to follow each other that's
> quite likely with PCI passthrough devices. In that case, the existing
> code, that tries to work out aperture boundaries by reading hvmloader
> BAR placement, will report a bogus prefetchable aperture which overlaps
> with the regular one. It will eventually trigger an assertion in
> DXE PCI initialization code.
>
> Do the same thing as OVMF on QEMU-KVM and pass a non-existing aperture
> there. It's not necessary to pass additional allocation flags as we set
> ResourceAssigned flag on the root bridge which means they will be ignored.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> ---
> Changes in v2:
> * remove usage of prefetchable aperture entirely
> * explained rationale for the change in the description
> ---
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
prev parent reply other threads:[~2019-04-11 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1554779560-26204-1-git-send-email-igor.druzhinin@citrix.com>
2019-04-09 7:54 ` [PATCH v2 0/3] Xen PCI passthrough fixes Laszlo Ersek
[not found] ` <1554779560-26204-2-git-send-email-igor.druzhinin@citrix.com>
2019-04-11 13:07 ` Anthony PERARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411130732.GK1435@perard.uk.xensource.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox