[PATCH 00/10] patches for some warnings raised by "RH covscan"

["Laszlo Ersek" <lersek@redhat.com>]

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710
Repo:     https://github.com/lersek/edk2.git
Branch:   covscan_bz_1710

"covscan" is an internal service at Red Hat that lets associates run
static analysis tools on Fedora/RHEL packages. It drives a number of
static analyzers.

While covscan's existence is not "secret" (if you google it, you get a
bunch of hits in the Red Hat Bugzilla), I can *not* use or offer covscan
as a general upstream tool; for that the TianoCore community will have
to build its own service / environment.

Anyway, "covscan" happened to drop a bunch of reports on me for...
"reasons", and so I turned a short 10 hour workday into yet anoher
normal 15 hour workday (stealing some free time whence there was none)
in order to do something, up-stream, about the warnings that affected
OvmfPkg. No claim is made about the completeness of the scan's coverage.

Some of the patches seek to suppress warnings, some strive to remedy
valid-looking issues. We should not spend much time on this series.

Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>

Thanks
Laszlo

Laszlo Ersek (10):
  MdePkg/PiFirmwareFile: express IS_SECTION2 in terms of SECTION_SIZE
  MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE
  BaseTools/PiFirmwareFile: fix undefined behavior in SECTION_SIZE
  MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE
  OvmfPkg/Sec: fix out-of-bounds reads
  OvmfPkg/QemuVideoDxe: avoid arithmetic on null pointer
  OvmfPkg/AcpiPlatformDxe: suppress invalid "deref of undef pointer"
    warning
  OvmfPkg: suppress "Value stored to ... is never read" analyzer
    warnings
  OvmfPkg/AcpiPlatformDxe: catch theoretical nullptr deref in Xen code
  OvmfPkg/BasePciCapLib: suppress invalid "nullptr deref" warning

 BaseTools/Source/C/Include/Common/PiFirmwareFile.h            |  7 +++++-
 MdePkg/Include/Pi/PiFirmwareFile.h                            | 26 ++++++++++++++++----
 OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c                        |  7 ++++++
 OvmfPkg/AcpiPlatformDxe/Xen.c                                 | 14 ++++++++++-
 OvmfPkg/Library/BasePciCapLib/BasePciCapLib.c                 |  7 ++++++
 OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c           |  5 ++++
 OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.c |  4 +++
 OvmfPkg/Library/VirtioLib/VirtioLib.c                         |  5 ++++
 OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c       |  5 ++++
 OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c    |  5 ++++
 OvmfPkg/QemuVideoDxe/VbeShim.c                                |  2 +-
 OvmfPkg/SataControllerDxe/SataController.c                    |  5 ++++
 OvmfPkg/Sec/SecMain.c                                         |  6 ++---
 OvmfPkg/VirtioGpuDxe/Gop.c                                    |  6 +++++
 OvmfPkg/VirtioNetDxe/SnpReceive.c                             |  5 ++++
 15 files changed, 98 insertions(+), 11 deletions(-)

-- 
2.19.1.3.g30247aa5d201