From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=UazDOKSQ; spf=pass (domain: linaro.org, ip: 209.85.215.196, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by groups.io with SMTP; Sun, 14 Apr 2019 12:52:53 -0700 Received: by mail-pg1-f196.google.com with SMTP id k3so7531577pga.6 for ; Sun, 14 Apr 2019 12:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=l6SCJAnjRE21X3yttCv4oiwT+CgjASTDqRMAtNI0cqU=; b=UazDOKSQ3sbhQSfCbGyCi3f6nLU4IXiRMmKoJlJM1CRfYizN2XCdz/GRRdun4gB4RM crqSpgsSAIX/TUWwyGReEPcAw9+RucwF7oLCvArp8oXKlIjxxQAtjE3XaXG+Xh6p5I4T AZbfoh01CJqp+nCgYAbhAw0r65NVYEoFehcwL8VrvAt7urgVjKo+K7EP55y1+l6XFrcA y5joBmpUCQ1eY6HDx2BHnGsDBYcBSLK0Cm7hDlzM/WPVo7WMH1tSJKc8sXnfmZL1QJ/c XkDztzeVSpZT5fc2lP7G9gKEij/tlDNfjqo0FBt/n0FxTDxKHjX0VBRE/JRHnzdEaFPx w/Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=l6SCJAnjRE21X3yttCv4oiwT+CgjASTDqRMAtNI0cqU=; b=pm7BzDZxDNK76cUhAjJqjlyOwXRyscQBXWKcdtjW/kBhO7uSMZZX/4xh/zqagJSXqk NMoMSOkO1XTKLVJsXM43nfLZYGAs+us8EQYt/6TRSsSC7hlgitYggvtYgZ8DBc2MKNhf De+GDGQ+QM9s68xDFEKJDy0e3SUvUn+5Hx7fb4ob29Fg6PaAyZBvmbeR+gNa1zldQ6Yf dbYP9RFDNiZGhUkpINmLlEOcZ6rKY88MNRTKY+ltbkpUxGvpMU4gitJJtcXZPs1iSKo5 Ou49AFQmKzI+JuB3Uk7NpEjLHzXWKKxEzr3l/7E53Ho4MAKcHm9iCQnYMQxwXG7Kobr8 YIsA== X-Gm-Message-State: APjAAAXfNvFNnArQbTsmSm4ycYFlo1JIyHwdmMbfAHNLLPldgzT3yl7E OoBNpDfUi84UWaO4X/r60V79yedb0nOhARTH X-Google-Smtp-Source: APXvYqyOw+NZw8nn2uiKsAe/e+Q4PJT2rZ7xhKHP4P/GChSfyc1GiWOleZGA1ABVsEoqN2uGjRmlxA== X-Received: by 2002:a62:be13:: with SMTP id l19mr70354449pff.137.1555271572056; Sun, 14 Apr 2019 12:52:52 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([50.236.184.206]) by smtp.gmail.com with ESMTPSA id j16sm62388977pfi.58.2019.04.14.12.52.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Apr 2019 12:52:50 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Michael D Kinney , Andrew Fish , Leif Lindholm , Star Zeng , Eric Dong , Ruiyu Ni , Liming Gao , Jaben Carsey , Steven Shi , Jian J Wang , Hao Wu Subject: [PATCH v6 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images Date: Sun, 14 Apr 2019 12:52:26 -0700 Message-Id: <20190414195233.30045-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 Add the basic plumbing to DXE core, the PCI bus driver and the boot manager to allow PE/COFF images to be dispatched that target an architecture that is not native for the platform, but which is supported by one of potentially several available emulators. One implementation of such an emulator can be found here: https://github.com/ardbiesheuvel/X86EmulatorPkg/tree/upstream-v4 This also allows us to get rid of the special treatment of EBC images in core code. Instead, the EbcDxe driver is augmented with an implementation of the EDK2 PE/COFF image emulator protocol so that internal knowledge of how EBC is implemented (I-cache flushing, thunks) is removed from the DXE core. Changes since v5: - Fix build issues reported by Mike Kinney (#2, #5) - Fix CheckPatch.py issue regarding the use of EFI_D_ERROR (#2) [This is code that is only being moved around but I fixed it nonetheless] - Use InstallMultipleProtocolInterfaces() to install the EBC protocol and the PE/COFF emu protocol at the same time (to simplify/fix the error path) (#5) - Add Mike's Reviewed-by Changes since v4: - Fix an issue in the protocol notify handler pointed out by Mike Kinney (#2) Changes since v3: - Simplify the handling of option ROMs and Driver#### images, by simply deferring to the LoadImage() boot service to decide whether an image can be supported or not - this removes some redundant checks from the BDS layer and the PCI bus driver. - Move the machine type supported by the emulator into the protocol struct, so we can optimize away calls into the emulator for each image loaded. Instead, the LoadImage() code will only invoke the IsSupported() method for images that are known to have a matching machine type. Note that I have considered, but ultimately dismissed the suggestion to register and unregister emulators via a new protocol. The main issue is that registering and unregistering structs containing sets of function pointers is awfully similar to managing a protocol database, and we already have the code to do that in EDK2. So instead, I have removed all the code that iterates over a handle buffer of emu protocols and invokes each one to see if it will support the image. Instead, this is all done by CoreLoadImage(). Changes since v2: - incorporate feedback from Andrew Fish (delivered in person): * pass a device path into the IsImageSupported() protocol method so that an implementation can blacklist or whitelist certain devices, or implement other policies that depend on the device where the driver originated * allow the emulator to supersede the native loading of the image - this permits things like X86 on X86 emulators for security sandboxing or debug Changes since v1: - subsume the EBC handling into the EDK2 emulator protocol and abstract away from EBC specifics in core code. - allow multiple emulator implementations to co-exist - incorporate Star's review feedback Cc: Michael D Kinney Cc: Andrew Fish Cc: Leif Lindholm Cc: Star Zeng Cc: Eric Dong Cc: Ruiyu Ni Cc: Liming Gao Cc: Jaben Carsey Cc: Steven Shi Cc: Jian J Wang Cc: Hao Wu Ard Biesheuvel (7): MdeModulePkg: introduce PE/COFF image emulator protocol MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures MdeModulePkg/UefiBootManagerLib: allow foreign Driver#### images MdeModulePkg/EbcDxe: implement the PE/COFF emulator protocol MdePkg/UefiBaseType.h: treat EBC as a non-native machine type MdeModulePkg/DxeCore: remove explicit EBC handling .../Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 7 - MdeModulePkg/Core/Dxe/DxeMain.h | 6 +- MdeModulePkg/Core/Dxe/DxeMain.inf | 2 +- MdeModulePkg/Core/Dxe/Image/Image.c | 210 +++++++++++++----- .../Include/Protocol/PeCoffImageEmulator.h | 107 +++++++++ .../Library/UefiBootManagerLib/BmLoadOption.c | 6 +- MdeModulePkg/MdeModulePkg.dec | 4 + MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 3 + MdeModulePkg/Universal/EbcDxe/EbcDxe.inf | 3 + MdeModulePkg/Universal/EbcDxe/EbcInt.c | 121 +++++++++- MdeModulePkg/Universal/EbcDxe/EbcInt.h | 3 + MdePkg/Include/Uefi/UefiBaseType.h | 6 +- 12 files changed, 402 insertions(+), 76 deletions(-) create mode 100644 MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h -- 2.17.1