* [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype
@ 2019-04-15 3:05 Gao, Zhichao
2019-04-15 3:05 ` [PATCH 01/25] MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM Gao, Zhichao
` (27 more replies)
0 siblings, 28 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Michael D Kinney, Liming Gao, Chao Zhang, Jiewen Yao, Jian J Wang,
Hao Wu, Ray Ni, Star Zeng, Leif Lindholm, Ard Biesheuvel,
Jordan Justen, Laszlo Ersek, Kelly Steele, Zailiang Sun, Yi Qian,
Sean Brogan, Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Add a new API ResetSystem to ResetSystemLib instances. The new driver may
consume this new API and then it may cause a link error. For these library
instances, the new API only has a basic function. If the consumers want
the full function of this API, they should use the instance in the MdeModulePkg
and make sure the depex driver is dispatched.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1458
Add a new API ResetSystemWithSubtype to ResetUtilityLib
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Bret Barkelew (2):
MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
Zhichao Gao (23):
MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM
MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM
MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2
MdePkg/PeiServicesLib.c: Change comments of PeiServicesResetSystem2
SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset
MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem
MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem
MdeModulePkg/BaseResetSystemLibNull.c: Change comments of ResetSystem
MdeModulePkg/RuntimeResetSystemLib.c: Change comments
MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem
MdeModulePkg/ResetSystemRuntimeDxe: Change comments
MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2
MdeModulePkg/PeiMain: Change comments of PeiResetSystem2
MdeModulePkg/NvmExpressHci.c: Change comments
BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem
CorebootPayloadPkg/ResetSystemLib: Add new API ResetSystem
Nt32Pkg/ResetSystemLib: Add new API ResetSystem
OvmfPkg/ResetSystemLib: Add new API ResetSystem
PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem
QuarkSocPkg/ResetSystemLib: Add new API ResetSystem
Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem
ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem
ArmVirtPkg/ArmVirtPsciResetSystemLib: Add a new API ResetSystem
.../ArmSmcPsciResetSystemLib.c | 43 +++++++++++++++++++
.../ArmVirtPsciResetSystemLib.c | 43 +++++++++++++++++++
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
.../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 5 +--
MdeModulePkg/Core/Pei/PeiMain.h | 4 +-
MdeModulePkg/Core/Pei/Reset/Reset.c | 4 +-
MdeModulePkg/Include/Library/ResetSystemLib.h | 4 +-
.../Include/Library/ResetUtilityLib.h | 22 ++++++++++
.../BaseResetSystemLibNull.c | 4 +-
.../DxeResetSystemLib/DxeResetSystemLib.c | 4 +-
.../PeiResetSystemLib/PeiResetSystemLib.c | 4 +-
.../Library/ResetUtilityLib/ResetUtility.c | 36 +++++++++++++---
.../RuntimeResetSystemLib.c | 4 +-
.../Universal/ResetSystemPei/ResetSystem.c | 5 +--
.../Universal/ResetSystemPei/ResetSystem.h | 5 +--
.../ResetSystemRuntimeDxe/ResetSystem.c | 5 +--
.../ResetSystemRuntimeDxe/ResetSystem.h | 5 +--
MdePkg/Include/Library/PeiServicesLib.h | 4 +-
MdePkg/Include/Pi/PiPeiCis.h | 4 +-
MdePkg/Include/Uefi/UefiSpec.h | 5 +--
.../Library/PeiServicesLib/PeiServicesLib.c | 4 +-
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 5 +--
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
28 files changed, 456 insertions(+), 64 deletions(-)
--
2.21.0.windows.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 01/25] MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 02/25] MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM Gao, Zhichao
` (26 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Michael D Kinney, Liming Gao, Sean Brogan, Michael Turner,
Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdePkg/Include/Uefi/UefiSpec.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h
index fca8df6751..631dc933b4 100644
--- a/MdePkg/Include/Uefi/UefiSpec.h
+++ b/MdePkg/Include/Uefi/UefiSpec.h
@@ -1014,10 +1014,7 @@ EFI_STATUS
EfiResetShutdown the data buffer starts with a Null-terminated
string, optionally followed by additional binary data.
The string is a description that the caller may use to further
- indicate the reason for the system reset. ResetData is only
- valid if ResetStatus is something other than EFI_SUCCESS
- unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ indicate the reason for the system reset.
For a ResetType of EfiResetPlatformSpecific the data buffer
also starts with a Null-terminated string that is followed
by an EFI_GUID that describes the specific type of reset to perform.
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 02/25] MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
2019-04-15 3:05 ` [PATCH 01/25] MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 03/25] MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2 Gao, Zhichao
` (25 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Michael D Kinney, Liming Gao, Sean Brogan, Michael Turner,
Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdePkg/Include/Pi/PiPeiCis.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MdePkg/Include/Pi/PiPeiCis.h b/MdePkg/Include/Pi/PiPeiCis.h
index ea2455ab1f..ecaa69c5c0 100644
--- a/MdePkg/Include/Pi/PiPeiCis.h
+++ b/MdePkg/Include/Pi/PiPeiCis.h
@@ -614,9 +614,7 @@ EFI_STATUS
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
typedef
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 03/25] MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
2019-04-15 3:05 ` [PATCH 01/25] MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM Gao, Zhichao
2019-04-15 3:05 ` [PATCH 02/25] MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 04/25] MdePkg/PeiServicesLib.c: " Gao, Zhichao
` (24 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Michael D Kinney, Liming Gao, Sean Brogan, Michael Turner,
Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdePkg/Include/Library/PeiServicesLib.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MdePkg/Include/Library/PeiServicesLib.h b/MdePkg/Include/Library/PeiServicesLib.h
index d32347493b..9ea5f3608b 100644
--- a/MdePkg/Include/Library/PeiServicesLib.h
+++ b/MdePkg/Include/Library/PeiServicesLib.h
@@ -544,9 +544,7 @@ PeiServicesInstallFvInfo2Ppi (
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
VOID
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 04/25] MdePkg/PeiServicesLib.c: Change comments of PeiServicesResetSystem2
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (2 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 03/25] MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2 Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset Gao, Zhichao
` (23 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Michael D Kinney, Liming Gao, Sean Brogan, Michael Turner,
Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdePkg/Library/PeiServicesLib/PeiServicesLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MdePkg/Library/PeiServicesLib/PeiServicesLib.c b/MdePkg/Library/PeiServicesLib/PeiServicesLib.c
index 35d03fed62..62ac45340e 100644
--- a/MdePkg/Library/PeiServicesLib/PeiServicesLib.c
+++ b/MdePkg/Library/PeiServicesLib/PeiServicesLib.c
@@ -793,9 +793,7 @@ PeiServicesInstallFvInfo2Ppi (
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
VOID
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (3 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 04/25] MdePkg/PeiServicesLib.c: " Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 06/25] MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem Gao, Zhichao
` (22 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Chao Zhang, Jiewen Yao, Liming Gao, Sean Brogan, Michael Turner,
Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
index b3e21f0947..186289bdc4 100644
--- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
+++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
@@ -2419,10 +2419,7 @@ OnExitBootServicesFailed (
EfiResetShutdown the data buffer starts with a Null-terminated
string, optionally followed by additional binary data.
The string is a description that the caller may use to further
- indicate the reason for the system reset. ResetData is only
- valid if ResetStatus is something other than EFI_SUCCESS
- unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ indicate the reason for the system reset.
For a ResetType of EfiResetPlatformSpecific the data buffer
also starts with a Null-terminated string that is followed
by an EFI_GUID that describes the specific type of reset to perform.
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 06/25] MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (4 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 07/25] MdeModulePkg/DxeResetSystemLib.c: " Gao, Zhichao
` (21 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao, Sean Brogan,
Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdeModulePkg/Include/Library/ResetSystemLib.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MdeModulePkg/Include/Library/ResetSystemLib.h b/MdeModulePkg/Include/Library/ResetSystemLib.h
index 8fd875f2e9..3b2a098a60 100644
--- a/MdeModulePkg/Include/Library/ResetSystemLib.h
+++ b/MdeModulePkg/Include/Library/ResetSystemLib.h
@@ -90,9 +90,7 @@ ResetPlatformSpecific (
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
VOID
EFIAPI
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 07/25] MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (5 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 06/25] MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 08/25] MdeModulePkg/BaseResetSystemLibNull.c: " Gao, Zhichao
` (20 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao, Sean Brogan,
Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c
index 5ca2fd4c11..a85b6cd9a6 100644
--- a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c
+++ b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c
@@ -101,9 +101,7 @@ ResetPlatformSpecific (
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
VOID
EFIAPI
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 08/25] MdeModulePkg/BaseResetSystemLibNull.c: Change comments of ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (6 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 07/25] MdeModulePkg/DxeResetSystemLib.c: " Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 09/25] MdeModulePkg/RuntimeResetSystemLib.c: Change comments Gao, Zhichao
` (19 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao, Sean Brogan,
Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c
index 10c682afb8..6ef225551b 100644
--- a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c
+++ b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c
@@ -103,9 +103,7 @@ ResetPlatformSpecific (
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
VOID
EFIAPI
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 09/25] MdeModulePkg/RuntimeResetSystemLib.c: Change comments
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (7 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 08/25] MdeModulePkg/BaseResetSystemLibNull.c: " Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 10/25] MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem Gao, Zhichao
` (18 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao, Sean Brogan,
Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not. So change the comments of ResetSystem.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c b/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c
index 7074f595b7..29b3f7ebd8 100644
--- a/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c
+++ b/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c
@@ -106,9 +106,7 @@ ResetPlatformSpecific (
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
VOID
EFIAPI
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 10/25] MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (8 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 09/25] MdeModulePkg/RuntimeResetSystemLib.c: Change comments Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 11/25] MdeModulePkg/ResetSystemRuntimeDxe: Change comments Gao, Zhichao
` (17 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao, Sean Brogan,
Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c
index be5dc08c7a..50297129b7 100644
--- a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c
+++ b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c
@@ -101,9 +101,7 @@ ResetPlatformSpecific (
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
VOID
EFIAPI
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 11/25] MdeModulePkg/ResetSystemRuntimeDxe: Change comments
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (9 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 10/25] MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 12/25] MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2 Gao, Zhichao
` (16 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao, Sean Brogan,
Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not. So change the comments of RuntimeServiceResetSystem.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 5 +----
MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h | 5 +----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
index 399104ca8e..77aedcba6e 100644
--- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
+++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
@@ -210,10 +210,7 @@ InitializeResetSystem (
EfiResetShutdown the data buffer starts with a Null-terminated
string, optionally followed by additional binary data.
The string is a description that the caller may use to further
- indicate the reason for the system reset. ResetData is only
- valid if ResetStatus is something other than EFI_SUCCESS
- unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ indicate the reason for the system reset.
For a ResetType of EfiResetPlatformSpecific the data buffer
also starts with a Null-terminated string that is followed
by an EFI_GUID that describes the specific type of reset to perform.
diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h
index 25ae5dac27..87d9c572aa 100644
--- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h
+++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h
@@ -80,10 +80,7 @@ InitializeResetSystem (
EfiResetShutdown the data buffer starts with a Null-terminated
string, optionally followed by additional binary data.
The string is a description that the caller may use to further
- indicate the reason for the system reset. ResetData is only
- valid if ResetStatus is something other than EFI_SUCCESS
- unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ indicate the reason for the system reset.
For a ResetType of EfiResetPlatformSpecific the data buffer
also starts with a Null-terminated string that is followed
by an EFI_GUID that describes the specific type of reset to perform.
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 12/25] MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (10 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 11/25] MdeModulePkg/ResetSystemRuntimeDxe: Change comments Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:05 ` [PATCH 13/25] MdeModulePkg/PeiMain: Change comments of PeiResetSystem2 Gao, Zhichao
` (15 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao, Sean Brogan,
Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdeModulePkg/Universal/ResetSystemPei/ResetSystem.c | 5 +----
MdeModulePkg/Universal/ResetSystemPei/ResetSystem.h | 5 +----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.c
index 068e4e1130..0a60387373 100644
--- a/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.c
+++ b/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.c
@@ -265,10 +265,7 @@ InitializeResetSystem (
EfiResetShutdown the data buffer starts with a Null-terminated
string, optionally followed by additional binary data.
The string is a description that the caller may use to further
- indicate the reason for the system reset. ResetData is only
- valid if ResetStatus is something other than EFI_SUCCESS
- unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ indicate the reason for the system reset.
For a ResetType of EfiResetPlatformSpecific the data buffer
also starts with a Null-terminated string that is followed
by an EFI_GUID that describes the specific type of reset to perform.
diff --git a/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.h b/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.h
index 6c96ddaa84..4d49a308af 100644
--- a/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.h
+++ b/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.h
@@ -58,10 +58,7 @@ typedef struct {
EfiResetShutdown the data buffer starts with a Null-terminated
string, optionally followed by additional binary data.
The string is a description that the caller may use to further
- indicate the reason for the system reset. ResetData is only
- valid if ResetStatus is something other than EFI_SUCCESS
- unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ indicate the reason for the system reset.
For a ResetType of EfiResetPlatformSpecific the data buffer
also starts with a Null-terminated string that is followed
by an EFI_GUID that describes the specific type of reset to perform.
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 13/25] MdeModulePkg/PeiMain: Change comments of PeiResetSystem2
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (11 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 12/25] MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2 Gao, Zhichao
@ 2019-04-15 3:05 ` Gao, Zhichao
2019-04-15 3:06 ` [PATCH 14/25] MdeModulePkg/NvmExpressHci.c: Change comments Gao, Zhichao
` (14 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:05 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao, Sean Brogan,
Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdeModulePkg/Core/Pei/PeiMain.h | 4 +---
MdeModulePkg/Core/Pei/Reset/Reset.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h
index 0aed4f4685..f2aa97c664 100644
--- a/MdeModulePkg/Core/Pei/PeiMain.h
+++ b/MdeModulePkg/Core/Pei/PeiMain.h
@@ -1097,9 +1097,7 @@ PeiResetSystem (
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
VOID
diff --git a/MdeModulePkg/Core/Pei/Reset/Reset.c b/MdeModulePkg/Core/Pei/Reset/Reset.c
index 263eace239..830c581108 100644
--- a/MdeModulePkg/Core/Pei/Reset/Reset.c
+++ b/MdeModulePkg/Core/Pei/Reset/Reset.c
@@ -72,9 +72,7 @@ PeiResetSystem (
the data buffer starts with a Null-terminated string, optionally
followed by additional binary data. The string is a description
that the caller may use to further indicate the reason for the
- system reset. ResetData is only valid if ResetStatus is something
- other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ system reset.
**/
VOID
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 14/25] MdeModulePkg/NvmExpressHci.c: Change comments
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (12 preceding siblings ...)
2019-04-15 3:05 ` [PATCH 13/25] MdeModulePkg/PeiMain: Change comments of PeiResetSystem2 Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-15 3:06 ` [PATCH 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem Gao, Zhichao
` (13 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao, Sean Brogan,
Michael Turner, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not. So change the comments of NvmeShutdownAllControllers.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
index d1b106ef61..95f8b18bc4 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
+++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
@@ -966,10 +966,7 @@ NvmeControllerInit (
EfiResetShutdown the data buffer starts with a Null-terminated
string, optionally followed by additional binary data.
The string is a description that the caller may use to further
- indicate the reason for the system reset. ResetData is only
- valid if ResetStatus is something other than EFI_SUCCESS
- unless the ResetType is EfiResetPlatformSpecific
- where a minimum amount of ResetData is always required.
+ indicate the reason for the system reset.
For a ResetType of EfiResetPlatformSpecific the data buffer
also starts with a Null-terminated string that is followed
by an EFI_GUID that describes the specific type of reset to perform.
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (13 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 14/25] MdeModulePkg/NvmExpressHci.c: Change comments Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-15 9:51 ` [edk2-devel] " Leif Lindholm
2019-04-15 3:06 ` [PATCH 16/25] CorebootPayloadPkg/ResetSystemLib: " Gao, Zhichao
` (12 subsequent siblings)
27 siblings, 1 reply; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem to this ResetSystemLib instance.
It only adds the basic functions from ResetSystemRuntimeDxe.
Lacking of this interface may cause link error, if some drivers
use this new API and link to this library instance.
Notes:
This library API only provide a basic function of reset. Full
function should use the instance in the MdeModulePkg and make
sure the depex driver is dispatched.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c b/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c
index 9fc572957f..e2a9d2469c 100644
--- a/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c
+++ b/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c
@@ -103,3 +103,46 @@ ResetPlatformSpecific (
{
ResetCold ();
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ switch (ResetType) {
+ case EfiResetWarm:
+ ResetWarm ();
+ break;
+
+ case EfiResetCold:
+ ResetCold ();
+ break;
+
+ case EfiResetShutdown:
+ ResetShutdown ();
+ return ;
+
+ case EfiResetPlatformSpecific:
+ ResetPlatformSpecific (DataSize, ResetData);
+ return;
+
+ default:
+ return ;
+ }
+}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 16/25] CorebootPayloadPkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (14 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-15 3:06 ` [PATCH 17/25] Nt32Pkg/ResetSystemLib: " Gao, Zhichao
` (11 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem to this ResetSystemLib instance.
It only adds the basic functions from ResetSystemRuntimeDxe.
Lacking of this interface may cause link error, if some drivers
use this new API and link to this library instance.
Notes:
This library API only provide a basic function of reset. Full
function should use the instance in the MdeModulePkg and make
sure the depex driver is dispatched.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c b/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
index 1fb9142408..13a65e9fdf 100644
--- a/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
+++ b/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
@@ -176,3 +176,46 @@ ResetPlatformSpecific (
{
ResetCold ();
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ switch (ResetType) {
+ case EfiResetWarm:
+ ResetWarm ();
+ break;
+
+ case EfiResetCold:
+ ResetCold ();
+ break;
+
+ case EfiResetShutdown:
+ ResetShutdown ();
+ return ;
+
+ case EfiResetPlatformSpecific:
+ ResetPlatformSpecific (DataSize, ResetData);
+ return;
+
+ default:
+ return ;
+ }
+}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 17/25] Nt32Pkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (15 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 16/25] CorebootPayloadPkg/ResetSystemLib: " Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-17 3:15 ` [edk2-devel] " Wu, Hao A
2019-04-15 3:06 ` [PATCH 18/25] OvmfPkg/ResetSystemLib: " Gao, Zhichao
` (10 subsequent siblings)
27 siblings, 1 reply; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem to this ResetSystemLib instance.
It only adds the basic functions from ResetSystemRuntimeDxe.
Lacking of this interface may cause link error, if some drivers
use this new API and link to this library instance.
Notes:
This library API only provide a basic function of reset. Full
function should use the instance in the MdeModulePkg and make
sure the depex driver is dispatched.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c b/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c
index ed4129d46b..02fa30169d 100644
--- a/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c
+++ b/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c
@@ -90,3 +90,46 @@ ResetPlatformSpecific (
{
ResetCold ();
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ switch (ResetType) {
+ case EfiResetWarm:
+ ResetWarm ();
+ break;
+
+ case EfiResetCold:
+ ResetCold ();
+ break;
+
+ case EfiResetShutdown:
+ ResetShutdown ();
+ return ;
+
+ case EfiResetPlatformSpecific:
+ ResetPlatformSpecific (DataSize, ResetData);
+ return;
+
+ default:
+ return ;
+ }
+}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 18/25] OvmfPkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (16 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 17/25] Nt32Pkg/ResetSystemLib: " Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-15 16:38 ` Laszlo Ersek
2019-04-15 3:06 ` [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: " Gao, Zhichao
` (9 subsequent siblings)
27 siblings, 1 reply; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel; +Cc: Jordan Justen, Laszlo Ersek, Ard Biesheuvel, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem to this ResetSystemLib instance.
It only adds the basic functions from ResetSystemRuntimeDxe.
Lacking of this interface may cause link error, if some drivers
use this new API and link to this library instance.
Notes:
This library API only provide a basic function of reset. Full
function should use the instance in the MdeModulePkg and make
sure the depex driver is dispatched.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
index c2c7736aa8..c05a87ad51 100644
--- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
+++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
@@ -140,3 +140,46 @@ ResetPlatformSpecific (
{
ResetCold ();
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ switch (ResetType) {
+ case EfiResetWarm:
+ ResetWarm ();
+ break;
+
+ case EfiResetCold:
+ ResetCold ();
+ break;
+
+ case EfiResetShutdown:
+ ResetShutdown ();
+ return ;
+
+ case EfiResetPlatformSpecific:
+ ResetPlatformSpecific (DataSize, ResetData);
+ return;
+
+ default:
+ return ;
+ }
+}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (17 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 18/25] OvmfPkg/ResetSystemLib: " Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-15 3:06 ` [PATCH 20/25] QuarkSocPkg/ResetSystemLib: " Gao, Zhichao
` (8 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem to this ResetSystemLib instance.
It only adds the basic functions from ResetSystemRuntimeDxe.
Lacking of this interface may cause link error, if some drivers
use this new API and link to this library instance.
Notes:
This library API only provide a basic function of reset. Full
function should use the instance in the MdeModulePkg and make
sure the depex driver is dispatched.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
index eccef89ebe..b215ebed61 100644
--- a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
+++ b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
@@ -99,3 +99,46 @@ ResetPlatformSpecific (
{
ResetCold ();
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ switch (ResetType) {
+ case EfiResetWarm:
+ ResetWarm ();
+ break;
+
+ case EfiResetCold:
+ ResetCold ();
+ break;
+
+ case EfiResetShutdown:
+ ResetShutdown ();
+ return ;
+
+ case EfiResetPlatformSpecific:
+ ResetPlatformSpecific (DataSize, ResetData);
+ return;
+
+ default:
+ return ;
+ }
+}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 20/25] QuarkSocPkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (18 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: " Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-15 3:06 ` [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: " Gao, Zhichao
` (7 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Kelly Steele, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem to this ResetSystemLib instance.
It only adds the basic functions from ResetSystemRuntimeDxe.
Lacking of this interface may cause link error, if some drivers
use this new API and link to this library instance.
Notes:
This library API only provide a basic function of reset. Full
function should use the instance in the MdeModulePkg and make
sure the depex driver is dispatched.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c b/QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c
index ea95f89059..58773ff24f 100644
--- a/QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c
+++ b/QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c
@@ -334,3 +334,46 @@ ResetPlatformSpecific (
{
ResetCold ();
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ switch (ResetType) {
+ case EfiResetWarm:
+ ResetWarm ();
+ break;
+
+ case EfiResetCold:
+ ResetCold ();
+ break;
+
+ case EfiResetShutdown:
+ ResetShutdown ();
+ return ;
+
+ case EfiResetPlatformSpecific:
+ ResetPlatformSpecific (DataSize, ResetData);
+ return;
+
+ default:
+ return ;
+ }
+}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (19 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 20/25] QuarkSocPkg/ResetSystemLib: " Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-15 3:20 ` [edk2-devel] " Sun, Zailiang
2019-04-15 3:06 ` [PATCH 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a " Gao, Zhichao
` (6 subsequent siblings)
27 siblings, 1 reply; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel; +Cc: Zailiang Sun, Yi Qian, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem to this ResetSystemLib instance.
It only adds the basic functions from ResetSystemRuntimeDxe.
Lacking of this interface may cause link error, if some drivers
use this new API and link to this library instance.
Notes:
This library API only provide a basic function of reset. Full
function should use the instance in the MdeModulePkg and make
sure the depex driver is dispatched.
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c b/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
index 1cd6f80891..02457352e9 100644
--- a/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
+++ b/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
@@ -190,3 +190,46 @@ ResetPlatformSpecific (
{
ResetCold ();
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ switch (ResetType) {
+ case EfiResetWarm:
+ ResetWarm ();
+ break;
+
+ case EfiResetCold:
+ ResetCold ();
+ break;
+
+ case EfiResetShutdown:
+ ResetShutdown ();
+ return ;
+
+ case EfiResetPlatformSpecific:
+ ResetPlatformSpecific (DataSize, ResetData);
+ return;
+
+ default:
+ return ;
+ }
+}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (20 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: " Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-15 9:52 ` Leif Lindholm
2019-04-15 3:06 ` [PATCH 23/25] ArmVirtPkg/ArmVirtPsciResetSystemLib: " Gao, Zhichao
` (5 subsequent siblings)
27 siblings, 1 reply; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem to this ResetSystemLib instance.
It only adds the basic functions from ResetSystemRuntimeDxe.
Lacking of this interface may cause link error, if some drivers
use this new API and link to this library instance.
Notes:
This library API only provide a basic function of reset. Full
function should use the instance in the MdeModulePkg and make
sure the depex driver is dispatched.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../ArmSmcPsciResetSystemLib.c | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c
index 87c1ea0ed0..a9b5ac9274 100644
--- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c
+++ b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c
@@ -169,3 +169,46 @@ ResetPlatformSpecific (
// Map the platform specific reset as reboot
ResetCold ();
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ switch (ResetType) {
+ case EfiResetWarm:
+ ResetWarm ();
+ break;
+
+ case EfiResetCold:
+ ResetCold ();
+ break;
+
+ case EfiResetShutdown:
+ ResetShutdown ();
+ return ;
+
+ case EfiResetPlatformSpecific:
+ ResetPlatformSpecific (DataSize, ResetData);
+ return;
+
+ default:
+ return ;
+ }
+}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 23/25] ArmVirtPkg/ArmVirtPsciResetSystemLib: Add a new API ResetSystem
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (21 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a " Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-15 3:06 ` [PATCH 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype Gao, Zhichao
` (4 subsequent siblings)
27 siblings, 0 replies; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel; +Cc: Laszlo Ersek, Ard Biesheuvel, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
Add a new API ResetSystem to this ResetSystemLib instance.
It only adds the basic functions from ResetSystemRuntimeDxe.
Lacking of this interface may cause link error, if some drivers
use this new API and link to this library instance.
Notes:
This library API only provide a basic function of reset. Full
function should use the instance in the MdeModulePkg and make
sure the depex driver is dispatched.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../ArmVirtPsciResetSystemLib.c | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.c b/ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.c
index 79a5456c49..c9f96f87ce 100644
--- a/ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.c
+++ b/ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.c
@@ -179,3 +179,46 @@ ResetPlatformSpecific (
// Map the platform specific reset as reboot
ResetCold ();
}
+
+/**
+ The ResetSystem function resets the entire platform.
+
+ @param[in] ResetType The type of reset to perform.
+ @param[in] ResetStatus The status code for the reset.
+ @param[in] DataSize The size, in bytes, of ResetData.
+ @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
+ the data buffer starts with a Null-terminated string, optionally
+ followed by additional binary data. The string is a description
+ that the caller may use to further indicate the reason for the
+ system reset.
+**/
+VOID
+EFIAPI
+ResetSystem (
+ IN EFI_RESET_TYPE ResetType,
+ IN EFI_STATUS ResetStatus,
+ IN UINTN DataSize,
+ IN VOID *ResetData OPTIONAL
+ )
+{
+ switch (ResetType) {
+ case EfiResetWarm:
+ ResetWarm ();
+ break;
+
+ case EfiResetCold:
+ ResetCold ();
+ break;
+
+ case EfiResetShutdown:
+ ResetShutdown ();
+ return ;
+
+ case EfiResetPlatformSpecific:
+ ResetPlatformSpecific (DataSize, ResetData);
+ return;
+
+ default:
+ return ;
+ }
+}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (22 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 23/25] ArmVirtPkg/ArmVirtPsciResetSystemLib: " Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-17 5:24 ` Wu, Hao A
2019-04-15 3:06 ` [PATCH 25/25] " Gao, Zhichao
` (3 subsequent siblings)
27 siblings, 1 reply; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel
Cc: Bret Barkelew, Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao,
Sean Brogan, Michael Turner
From: Bret Barkelew <Bret.Barkelew@microsoft.com>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1458
Add a new API ResetSystemWithSubtype's prototype declaration in
header file. Also add the required data type header file.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Include/Library/ResetUtilityLib.h | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/MdeModulePkg/Include/Library/ResetUtilityLib.h b/MdeModulePkg/Include/Library/ResetUtilityLib.h
index ca310cdb01..9bb4adc1ad 100644
--- a/MdeModulePkg/Include/Library/ResetUtilityLib.h
+++ b/MdeModulePkg/Include/Library/ResetUtilityLib.h
@@ -10,6 +10,28 @@
#ifndef _RESET_UTILITY_LIB_H_
#define _RESET_UTILITY_LIB_H_
+#include <Uefi/UefiMultiPhase.h>
+
+/**
+ This is a shorthand helper function to reset with a subtype so that
+ the caller doesn't have to bother with a function that has half a dozen
+ parameters.
+
+ This will generate a reset with status EFI_SUCCESS, a NULL string, and
+ no custom data. The subtype will be formatted in such a way that it can be
+ picked up by notification registrations and custom handlers.
+
+ @param[in] ResetType The default EFI_RESET_TYPE of the reset.
+ @param[in] ResetSubtype GUID pointer for the reset subtype to be used.
+
+**/
+VOID
+EFIAPI
+ResetSystemWithSubtype (
+ IN EFI_RESET_TYPE ResetType,
+ IN CONST GUID *ResetSubtype
+ );
+
/**
This is a shorthand helper function to reset with a subtype so that
the caller doesn't have to bother with a function that has half a dozen
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 25/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (23 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype Gao, Zhichao
@ 2019-04-15 3:06 ` Gao, Zhichao
2019-04-17 5:47 ` [edk2-devel] " Wu, Hao A
2019-04-17 1:19 ` [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Liming Gao
` (2 subsequent siblings)
27 siblings, 1 reply; 36+ messages in thread
From: Gao, Zhichao @ 2019-04-15 3:06 UTC (permalink / raw)
To: devel
Cc: Bret Barkelew, Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao,
Sean Brogan, Michael Turner
From: Bret Barkelew <Bret.Barkelew@microsoft.com>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1458
Implement the new API ResetSystemWithSubtype. Depend on Uefi Spec
2.8 chapter 8.5.1, the ResetData is valid while the ResetStatus
is EFI_SUCCESS regardless of the ResetType. Also change the function
ResetPlatofrmSpecificGuid to directly call ResetSystemWithSubtype
to reduce the duplicated code.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/ResetUtilityLib/ResetUtility.c | 36 +++++++++++++++----
1 file changed, 30 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c b/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c
index 59f14edadc..45dbd2a952 100644
--- a/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c
+++ b/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c
@@ -31,16 +31,14 @@ VERIFY_SIZE_OF (RESET_UTILITY_GUID_SPECIFIC_RESET_DATA, 18);
no custom data. The subtype will be formatted in such a way that it can be
picked up by notification registrations and custom handlers.
- NOTE: This call will fail if the architectural ResetSystem underpinnings
- are not initialized. For DXE, you can add gEfiResetArchProtocolGuid
- to your DEPEX.
-
+ @param[in] ResetType The default EFI_RESET_TYPE of the reset.
@param[in] ResetSubtype GUID pointer for the reset subtype to be used.
**/
VOID
EFIAPI
-ResetPlatformSpecificGuid (
+ResetSystemWithSubtype (
+ IN EFI_RESET_TYPE ResetType,
IN CONST GUID *ResetSubtype
)
{
@@ -51,7 +49,33 @@ ResetPlatformSpecificGuid (
(GUID *)((UINT8 *)&ResetData + OFFSET_OF (RESET_UTILITY_GUID_SPECIFIC_RESET_DATA, ResetSubtype)),
ResetSubtype
);
- ResetPlatformSpecific (sizeof (ResetData), &ResetData);
+
+ ResetSystem (ResetType, EFI_SUCCESS, sizeof (ResetData), &ResetData);
+}
+
+/**
+ This is a shorthand helper function to reset with a subtype so that
+ the caller doesn't have to bother with a function that has half a dozen
+ parameters.
+
+ This will generate a reset with status EFI_SUCCESS, a NULL string, and
+ no custom data. The subtype will be formatted in such a way that it can be
+ picked up by notification registrations and custom handlers.
+
+ NOTE: This call will fail if the architectural ResetSystem underpinnings
+ are not initialized. For DXE, you can add gEfiResetArchProtocolGuid
+ to your DEPEX.
+
+ @param[in] ResetSubtype GUID pointer for the reset subtype to be used.
+
+**/
+VOID
+EFIAPI
+ResetPlatformSpecificGuid (
+ IN CONST GUID *ResetSubtype
+ )
+{
+ ResetSystemWithSubtype (EfiResetPlatformSpecific, ResetSubtype);
}
/**
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* Re: [edk2-devel] [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:06 ` [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: " Gao, Zhichao
@ 2019-04-15 3:20 ` Sun, Zailiang
0 siblings, 0 replies; 36+ messages in thread
From: Sun, Zailiang @ 2019-04-15 3:20 UTC (permalink / raw)
To: devel@edk2.groups.io, Gao, Zhichao; +Cc: Qian, Yi, Gao, Liming
Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Monday, April 15, 2019 11:06 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>; Gao,
> Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib:
> Add new API ResetSystem
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic functions from ResetSystemRuntimeDxe.
> Lacking of this interface may cause link error, if some drivers use this new API
> and link to this library instance.
> Notes:
> This library API only provide a basic function of reset. Full function should use
> the instance in the MdeModulePkg and make sure the depex driver is
> dispatched.
>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
> b/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
> index 1cd6f80891..02457352e9 100644
> --- a/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -190,3 +190,46 @@ ResetPlatformSpecific ( {
> ResetCold ();
> }
> +
> +/**
> + The ResetSystem function resets the entire platform.
> +
> + @param[in] ResetType The type of reset to perform.
> + @param[in] ResetStatus The status code for the reset.
> + @param[in] DataSize The size, in bytes, of ResetData.
> + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm,
> or EfiResetShutdown
> + the data buffer starts with a Null-terminated string, optionally
> + followed by additional binary data. The string is a description
> + that the caller may use to further indicate the reason for the
> + system reset.
> +**/
> +VOID
> +EFIAPI
> +ResetSystem (
> + IN EFI_RESET_TYPE ResetType,
> + IN EFI_STATUS ResetStatus,
> + IN UINTN DataSize,
> + IN VOID *ResetData OPTIONAL
> + )
> +{
> + switch (ResetType) {
> + case EfiResetWarm:
> + ResetWarm ();
> + break;
> +
> + case EfiResetCold:
> + ResetCold ();
> + break;
> +
> + case EfiResetShutdown:
> + ResetShutdown ();
> + return ;
> +
> + case EfiResetPlatformSpecific:
> + ResetPlatformSpecific (DataSize, ResetData);
> + return;
> +
> + default:
> + return ;
> + }
> +}
> --
> 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [edk2-devel] [PATCH 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:06 ` [PATCH 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem Gao, Zhichao
@ 2019-04-15 9:51 ` Leif Lindholm
0 siblings, 0 replies; 36+ messages in thread
From: Leif Lindholm @ 2019-04-15 9:51 UTC (permalink / raw)
To: devel, zhichao.gao; +Cc: Ard Biesheuvel, Liming Gao
Hi Zhichao,
Thanks for this.
On Mon, Apr 15, 2019 at 11:06:01AM +0800, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic functions from ResetSystemRuntimeDxe.
> Lacking of this interface may cause link error, if some drivers
> use this new API and link to this library instance.
> Notes:
> This library API only provide a basic function of reset. Full
> function should use the instance in the MdeModulePkg and make
> sure the depex driver is dispatched.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c b/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c
> index 9fc572957f..e2a9d2469c 100644
> --- a/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -103,3 +103,46 @@ ResetPlatformSpecific (
> {
> ResetCold ();
> }
> +
> +/**
> + The ResetSystem function resets the entire platform.
> +
> + @param[in] ResetType The type of reset to perform.
> + @param[in] ResetStatus The status code for the reset.
> + @param[in] DataSize The size, in bytes, of ResetData.
> + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
> + the data buffer starts with a Null-terminated string, optionally
> + followed by additional binary data. The string is a description
> + that the caller may use to further indicate the reason for the
> + system reset.
> +**/
> +VOID
> +EFIAPI
> +ResetSystem (
> + IN EFI_RESET_TYPE ResetType,
> + IN EFI_STATUS ResetStatus,
> + IN UINTN DataSize,
> + IN VOID *ResetData OPTIONAL
> + )
> +{
> + switch (ResetType) {
> + case EfiResetWarm:
> + ResetWarm ();
> + break;
> +
> + case EfiResetCold:
> + ResetCold ();
> + break;
> +
> + case EfiResetShutdown:
> + ResetShutdown ();
> + return ;
Please drop the spurious space before ;
> +
> + case EfiResetPlatformSpecific:
> + ResetPlatformSpecific (DataSize, ResetData);
> + return;
> +
> + default:
> + return ;
Please drop the spurious space before ;
(Unfortunately, this snippet has been copied around many places in
many of the patches in this series - they should all be updated.)
With that done:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> + }
> +}
> --
> 2.21.0.windows.1
>
>
>
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem
2019-04-15 3:06 ` [PATCH 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a " Gao, Zhichao
@ 2019-04-15 9:52 ` Leif Lindholm
0 siblings, 0 replies; 36+ messages in thread
From: Leif Lindholm @ 2019-04-15 9:52 UTC (permalink / raw)
To: Zhichao Gao; +Cc: devel, Ard Biesheuvel, Liming Gao
Same as previous patch - if you drop the space before ;,
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
On Mon, Apr 15, 2019 at 11:06:08AM +0800, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic functions from ResetSystemRuntimeDxe.
> Lacking of this interface may cause link error, if some drivers
> use this new API and link to this library instance.
> Notes:
> This library API only provide a basic function of reset. Full
> function should use the instance in the MdeModulePkg and make
> sure the depex driver is dispatched.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../ArmSmcPsciResetSystemLib.c | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c
> index 87c1ea0ed0..a9b5ac9274 100644
> --- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c
> +++ b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c
> @@ -169,3 +169,46 @@ ResetPlatformSpecific (
> // Map the platform specific reset as reboot
> ResetCold ();
> }
> +
> +/**
> + The ResetSystem function resets the entire platform.
> +
> + @param[in] ResetType The type of reset to perform.
> + @param[in] ResetStatus The status code for the reset.
> + @param[in] DataSize The size, in bytes, of ResetData.
> + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
> + the data buffer starts with a Null-terminated string, optionally
> + followed by additional binary data. The string is a description
> + that the caller may use to further indicate the reason for the
> + system reset.
> +**/
> +VOID
> +EFIAPI
> +ResetSystem (
> + IN EFI_RESET_TYPE ResetType,
> + IN EFI_STATUS ResetStatus,
> + IN UINTN DataSize,
> + IN VOID *ResetData OPTIONAL
> + )
> +{
> + switch (ResetType) {
> + case EfiResetWarm:
> + ResetWarm ();
> + break;
> +
> + case EfiResetCold:
> + ResetCold ();
> + break;
> +
> + case EfiResetShutdown:
> + ResetShutdown ();
> + return ;
> +
> + case EfiResetPlatformSpecific:
> + ResetPlatformSpecific (DataSize, ResetData);
> + return;
> +
> + default:
> + return ;
> + }
> +}
> --
> 2.21.0.windows.1
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 18/25] OvmfPkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:06 ` [PATCH 18/25] OvmfPkg/ResetSystemLib: " Gao, Zhichao
@ 2019-04-15 16:38 ` Laszlo Ersek
0 siblings, 0 replies; 36+ messages in thread
From: Laszlo Ersek @ 2019-04-15 16:38 UTC (permalink / raw)
To: Zhichao Gao, devel; +Cc: Jordan Justen, Ard Biesheuvel, Liming Gao
On 04/15/19 05:06, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic functions from ResetSystemRuntimeDxe.
> Lacking of this interface may cause link error, if some drivers
> use this new API and link to this library instance.
> Notes:
> This library API only provide a basic function of reset. Full
> function should use the instance in the MdeModulePkg and make
> sure the depex driver is dispatched.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> index c2c7736aa8..c05a87ad51 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -140,3 +140,46 @@ ResetPlatformSpecific (
> {
> ResetCold ();
> }
> +
> +/**
> + The ResetSystem function resets the entire platform.
> +
> + @param[in] ResetType The type of reset to perform.
> + @param[in] ResetStatus The status code for the reset.
> + @param[in] DataSize The size, in bytes, of ResetData.
> + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
> + the data buffer starts with a Null-terminated string, optionally
> + followed by additional binary data. The string is a description
> + that the caller may use to further indicate the reason for the
> + system reset.
> +**/
> +VOID
> +EFIAPI
> +ResetSystem (
> + IN EFI_RESET_TYPE ResetType,
> + IN EFI_STATUS ResetStatus,
> + IN UINTN DataSize,
> + IN VOID *ResetData OPTIONAL
> + )
> +{
> + switch (ResetType) {
> + case EfiResetWarm:
> + ResetWarm ();
> + break;
> +
> + case EfiResetCold:
> + ResetCold ();
> + break;
> +
> + case EfiResetShutdown:
> + ResetShutdown ();
> + return ;
> +
> + case EfiResetPlatformSpecific:
> + ResetPlatformSpecific (DataSize, ResetData);
> + return;
> +
> + default:
> + return ;
> + }
> +}
>
For patches 18/25 and 23/25]:
- please replace
return ;
with
return;
(there are two instances in both patches)
- with that update, for both patches:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (24 preceding siblings ...)
2019-04-15 3:06 ` [PATCH 25/25] " Gao, Zhichao
@ 2019-04-17 1:19 ` Liming Gao
2019-04-17 2:45 ` Wu, Hao A
[not found] ` <159586F2D3C4CEE3.6441@groups.io>
27 siblings, 0 replies; 36+ messages in thread
From: Liming Gao @ 2019-04-17 1:19 UTC (permalink / raw)
To: devel@edk2.groups.io, Gao, Zhichao
Cc: Kinney, Michael D, Zhang, Chao B, Yao, Jiewen, Wang, Jian J,
Wu, Hao A, Ni, Ray, Zeng, Star, Leif Lindholm, Ard Biesheuvel,
Justen, Jordan L, Laszlo Ersek, Steele, Kelly, Sun, Zailiang,
Qian, Yi, Sean Brogan, Michael Turner, Bret Barkelew
Zhichao:
The change in MdePkg is good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Gao, Zhichao
>Sent: Monday, April 15, 2019 11:06 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao,
>Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu,
>Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Zeng, Star
><star.zeng@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Ard
>Biesheuvel <ard.biesheuvel@linaro.org>; Justen, Jordan L
><jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Steele,
>Kelly <kelly.steele@intel.com>; Sun, Zailiang <zailiang.sun@intel.com>; Qian,
>Yi <yi.qian@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Michael
>Turner <Michael.Turner@microsoft.com>; Bret Barkelew
><Bret.Barkelew@microsoft.com>
>Subject: [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and
>ResetSystemWithSubtype
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
>is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
>or not.
>Add a new API ResetSystem to ResetSystemLib instances. The new driver may
>consume this new API and then it may cause a link error. For these library
>instances, the new API only has a basic function. If the consumers want
>the full function of this API, they should use the instance in the
>MdeModulePkg
>and make sure the depex driver is dispatched.
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1458
>Add a new API ResetSystemWithSubtype to ResetUtilityLib
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Chao Zhang <chao.b.zhang@intel.com>
>Cc: Jiewen Yao <jiewen.yao@intel.com>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Hao Wu <hao.a.wu@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Cc: Jordan Justen <jordan.l.justen@intel.com>
>Cc: Laszlo Ersek <lersek@redhat.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Kelly Steele <kelly.steele@intel.com>
>Cc: Zailiang Sun <zailiang.sun@intel.com>
>Cc: Yi Qian <yi.qian@intel.com>
>Cc: Sean Brogan <sean.brogan@microsoft.com>
>Cc: Michael Turner <Michael.Turner@microsoft.com>
>Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
>Bret Barkelew (2):
> MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
> MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
>
>Zhichao Gao (23):
> MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM
> MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM
> MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2
> MdePkg/PeiServicesLib.c: Change comments of PeiServicesResetSystem2
> SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset
> MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem
> MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem
> MdeModulePkg/BaseResetSystemLibNull.c: Change comments of
>ResetSystem
> MdeModulePkg/RuntimeResetSystemLib.c: Change comments
> MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem
> MdeModulePkg/ResetSystemRuntimeDxe: Change comments
> MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2
> MdeModulePkg/PeiMain: Change comments of PeiResetSystem2
> MdeModulePkg/NvmExpressHci.c: Change comments
> BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem
> CorebootPayloadPkg/ResetSystemLib: Add new API ResetSystem
> Nt32Pkg/ResetSystemLib: Add new API ResetSystem
> OvmfPkg/ResetSystemLib: Add new API ResetSystem
> PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem
> QuarkSocPkg/ResetSystemLib: Add new API ResetSystem
> Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem
> ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem
> ArmVirtPkg/ArmVirtPsciResetSystemLib: Add a new API ResetSystem
>
> .../ArmSmcPsciResetSystemLib.c | 43 +++++++++++++++++++
> .../ArmVirtPsciResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 5 +--
> MdeModulePkg/Core/Pei/PeiMain.h | 4 +-
> MdeModulePkg/Core/Pei/Reset/Reset.c | 4 +-
> MdeModulePkg/Include/Library/ResetSystemLib.h | 4 +-
> .../Include/Library/ResetUtilityLib.h | 22 ++++++++++
> .../BaseResetSystemLibNull.c | 4 +-
> .../DxeResetSystemLib/DxeResetSystemLib.c | 4 +-
> .../PeiResetSystemLib/PeiResetSystemLib.c | 4 +-
> .../Library/ResetUtilityLib/ResetUtility.c | 36 +++++++++++++---
> .../RuntimeResetSystemLib.c | 4 +-
> .../Universal/ResetSystemPei/ResetSystem.c | 5 +--
> .../Universal/ResetSystemPei/ResetSystem.h | 5 +--
> .../ResetSystemRuntimeDxe/ResetSystem.c | 5 +--
> .../ResetSystemRuntimeDxe/ResetSystem.h | 5 +--
> MdePkg/Include/Library/PeiServicesLib.h | 4 +-
> MdePkg/Include/Pi/PiPeiCis.h | 4 +-
> MdePkg/Include/Uefi/UefiSpec.h | 5 +--
> .../Library/PeiServicesLib/PeiServicesLib.c | 4 +-
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 5 +--
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> 28 files changed, 456 insertions(+), 64 deletions(-)
>
>--
>2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
` (25 preceding siblings ...)
2019-04-17 1:19 ` [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Liming Gao
@ 2019-04-17 2:45 ` Wu, Hao A
[not found] ` <159586F2D3C4CEE3.6441@groups.io>
27 siblings, 0 replies; 36+ messages in thread
From: Wu, Hao A @ 2019-04-17 2:45 UTC (permalink / raw)
To: devel@edk2.groups.io, Gao, Zhichao
Cc: Kinney, Michael D, Gao, Liming, Zhang, Chao B, Yao, Jiewen,
Wang, Jian J, Ni, Ray, Zeng, Star, Leif Lindholm, Ard Biesheuvel,
Justen, Jordan L, Laszlo Ersek, Steele, Kelly, Sun, Zailiang,
Qian, Yi, Sean Brogan, Michael Turner, Bret Barkelew
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Monday, April 15, 2019 11:06 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D; Gao, Liming; Zhang, Chao B; Yao, Jiewen; Wang, Jian J;
> Wu, Hao A; Ni, Ray; Zeng, Star; Leif Lindholm; Ard Biesheuvel; Justen, Jordan L;
> Laszlo Ersek; Steele, Kelly; Sun, Zailiang; Qian, Yi; Sean Brogan; Michael Turner;
> Bret Barkelew
> Subject: [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and
> ResetSystemWithSubtype
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
> Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
> is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
> or not.
> Add a new API ResetSystem to ResetSystemLib instances. The new driver may
> consume this new API and then it may cause a link error. For these library
> instances, the new API only has a basic function. If the consumers want
> the full function of this API, they should use the instance in the MdeModulePkg
> and make sure the depex driver is dispatched.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1458
> Add a new API ResetSystemWithSubtype to ResetUtilityLib
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> Bret Barkelew (2):
> MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
> MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
>
> Zhichao Gao (23):
> MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM
> MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM
> MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2
> MdePkg/PeiServicesLib.c: Change comments of PeiServicesResetSystem2
> SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset
> MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem
> MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem
> MdeModulePkg/BaseResetSystemLibNull.c: Change comments of ResetSystem
> MdeModulePkg/RuntimeResetSystemLib.c: Change comments
> MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem
> MdeModulePkg/ResetSystemRuntimeDxe: Change comments
> MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2
> MdeModulePkg/PeiMain: Change comments of PeiResetSystem2
> MdeModulePkg/NvmExpressHci.c: Change comments
For the above 9 comments update patches (patch 6~14),
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem
> CorebootPayloadPkg/ResetSystemLib: Add new API ResetSystem
> Nt32Pkg/ResetSystemLib: Add new API ResetSystem
> OvmfPkg/ResetSystemLib: Add new API ResetSystem
> PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem
> QuarkSocPkg/ResetSystemLib: Add new API ResetSystem
> Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem
> ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem
> ArmVirtPkg/ArmVirtPsciResetSystemLib: Add a new API ResetSystem
>
> .../ArmSmcPsciResetSystemLib.c | 43 +++++++++++++++++++
> .../ArmVirtPsciResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 5 +--
> MdeModulePkg/Core/Pei/PeiMain.h | 4 +-
> MdeModulePkg/Core/Pei/Reset/Reset.c | 4 +-
> MdeModulePkg/Include/Library/ResetSystemLib.h | 4 +-
> .../Include/Library/ResetUtilityLib.h | 22 ++++++++++
> .../BaseResetSystemLibNull.c | 4 +-
> .../DxeResetSystemLib/DxeResetSystemLib.c | 4 +-
> .../PeiResetSystemLib/PeiResetSystemLib.c | 4 +-
> .../Library/ResetUtilityLib/ResetUtility.c | 36 +++++++++++++---
> .../RuntimeResetSystemLib.c | 4 +-
> .../Universal/ResetSystemPei/ResetSystem.c | 5 +--
> .../Universal/ResetSystemPei/ResetSystem.h | 5 +--
> .../ResetSystemRuntimeDxe/ResetSystem.c | 5 +--
> .../ResetSystemRuntimeDxe/ResetSystem.h | 5 +--
> MdePkg/Include/Library/PeiServicesLib.h | 4 +-
> MdePkg/Include/Pi/PiPeiCis.h | 4 +-
> MdePkg/Include/Uefi/UefiSpec.h | 5 +--
> .../Library/PeiServicesLib/PeiServicesLib.c | 4 +-
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 5 +--
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> 28 files changed, 456 insertions(+), 64 deletions(-)
>
> --
> 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [edk2-devel] [PATCH 17/25] Nt32Pkg/ResetSystemLib: Add new API ResetSystem
2019-04-15 3:06 ` [PATCH 17/25] Nt32Pkg/ResetSystemLib: " Gao, Zhichao
@ 2019-04-17 3:15 ` Wu, Hao A
0 siblings, 0 replies; 36+ messages in thread
From: Wu, Hao A @ 2019-04-17 3:15 UTC (permalink / raw)
To: devel@edk2.groups.io, Gao, Zhichao
Cc: Leif Lindholm, Ard Biesheuvel, Gao, Liming
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Monday, April 15, 2019 11:06 AM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm; Ard Biesheuvel; Gao, Liming
> Subject: [edk2-devel] [PATCH 17/25] Nt32Pkg/ResetSystemLib: Add new API
> ResetSystem
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic functions from ResetSystemRuntimeDxe.
> Lacking of this interface may cause link error, if some drivers
> use this new API and link to this library instance.
> Notes:
> This library API only provide a basic function of reset. Full
> function should use the instance in the MdeModulePkg and make
> sure the depex driver is dispatched.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c
> b/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c
> index ed4129d46b..02fa30169d 100644
> --- a/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -90,3 +90,46 @@ ResetPlatformSpecific (
> {
> ResetCold ();
> }
> +
> +/**
> + The ResetSystem function resets the entire platform.
> +
> + @param[in] ResetType The type of reset to perform.
> + @param[in] ResetStatus The status code for the reset.
> + @param[in] DataSize The size, in bytes, of ResetData.
> + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm,
> or EfiResetShutdown
> + the data buffer starts with a Null-terminated string,
> optionally
> + followed by additional binary data. The string is a description
> + that the caller may use to further indicate the reason for the
> + system reset.
> +**/
> +VOID
> +EFIAPI
> +ResetSystem (
> + IN EFI_RESET_TYPE ResetType,
> + IN EFI_STATUS ResetStatus,
> + IN UINTN DataSize,
> + IN VOID *ResetData OPTIONAL
> + )
> +{
> + switch (ResetType) {
> + case EfiResetWarm:
> + ResetWarm ();
> + break;
> +
> + case EfiResetCold:
> + ResetCold ();
> + break;
> +
> + case EfiResetShutdown:
> + ResetShutdown ();
> + return ;
> +
> + case EfiResetPlatformSpecific:
> + ResetPlatformSpecific (DataSize, ResetData);
> + return;
> +
> + default:
> + return ;
Please remove the extra space between 'return' & ';'.
With this addressed,
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> + }
> +}
> --
> 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
2019-04-15 3:06 ` [PATCH 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype Gao, Zhichao
@ 2019-04-17 5:24 ` Wu, Hao A
0 siblings, 0 replies; 36+ messages in thread
From: Wu, Hao A @ 2019-04-17 5:24 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io
Cc: Bret Barkelew, Wang, Jian J, Ni, Ray, Zeng, Star, Gao, Liming,
Sean Brogan, Michael Turner
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Monday, April 15, 2019 11:06 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming;
> Sean Brogan; Michael Turner
> Subject: [PATCH 24/25] MdeModulePkg/ResetUtilityLib: Add a new API
> ResetSystemWithSubtype
>
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1458
>
> Add a new API ResetSystemWithSubtype's prototype declaration in
> header file. Also add the required data type header file.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../Include/Library/ResetUtilityLib.h | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/MdeModulePkg/Include/Library/ResetUtilityLib.h
> b/MdeModulePkg/Include/Library/ResetUtilityLib.h
> index ca310cdb01..9bb4adc1ad 100644
> --- a/MdeModulePkg/Include/Library/ResetUtilityLib.h
> +++ b/MdeModulePkg/Include/Library/ResetUtilityLib.h
> @@ -10,6 +10,28 @@
> #ifndef _RESET_UTILITY_LIB_H_
> #define _RESET_UTILITY_LIB_H_
>
> +#include <Uefi/UefiMultiPhase.h>
> +
> +/**
> + This is a shorthand helper function to reset with a subtype so that
> + the caller doesn't have to bother with a function that has half a dozen
> + parameters.
> +
> + This will generate a reset with status EFI_SUCCESS, a NULL string, and
> + no custom data. The subtype will be formatted in such a way that it can be
> + picked up by notification registrations and custom handlers.
I found that the function description is almost the same with the
existing API 'ResetPlatformSpecificGuid' (except lacking the 3rd paragraph
starting with 'NOTE:', which I think should be applied to
'ResetSystemWithSubtype' as well).
Seems to me that 'ResetSystemWithSubtype' is more generic. Could you help
to refine one of their descriptions to reflect their difference?
Best Regards,
Hao Wu
> +
> + @param[in] ResetType The default EFI_RESET_TYPE of the reset.
> + @param[in] ResetSubtype GUID pointer for the reset subtype to be used.
> +
> +**/
> +VOID
> +EFIAPI
> +ResetSystemWithSubtype (
> + IN EFI_RESET_TYPE ResetType,
> + IN CONST GUID *ResetSubtype
> + );
> +
> /**
> This is a shorthand helper function to reset with a subtype so that
> the caller doesn't have to bother with a function that has half a dozen
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [edk2-devel] [PATCH 25/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
2019-04-15 3:06 ` [PATCH 25/25] " Gao, Zhichao
@ 2019-04-17 5:47 ` Wu, Hao A
0 siblings, 0 replies; 36+ messages in thread
From: Wu, Hao A @ 2019-04-17 5:47 UTC (permalink / raw)
To: devel@edk2.groups.io, Gao, Zhichao
Cc: Bret Barkelew, Wang, Jian J, Ni, Ray, Zeng, Star, Gao, Liming,
Sean Brogan, Michael Turner
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Monday, April 15, 2019 11:06 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming;
> Sean Brogan; Michael Turner
> Subject: [edk2-devel] [PATCH 25/25] MdeModulePkg/ResetUtilityLib: Add a new
> API ResetSystemWithSubtype
>
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1458
>
> Implement the new API ResetSystemWithSubtype. Depend on Uefi Spec
> 2.8 chapter 8.5.1, the ResetData is valid while the ResetStatus
> is EFI_SUCCESS regardless of the ResetType. Also change the function
> ResetPlatofrmSpecificGuid to directly call ResetSystemWithSubtype
> to reduce the duplicated code.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../Library/ResetUtilityLib/ResetUtility.c | 36 +++++++++++++++----
> 1 file changed, 30 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c
> b/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c
> index 59f14edadc..45dbd2a952 100644
> --- a/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c
> +++ b/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c
> @@ -31,16 +31,14 @@ VERIFY_SIZE_OF
> (RESET_UTILITY_GUID_SPECIFIC_RESET_DATA, 18);
> no custom data. The subtype will be formatted in such a way that it can be
> picked up by notification registrations and custom handlers.
>
> - NOTE: This call will fail if the architectural ResetSystem underpinnings
> - are not initialized. For DXE, you can add gEfiResetArchProtocolGuid
> - to your DEPEX.
> -
> + @param[in] ResetType The default EFI_RESET_TYPE of the reset.
> @param[in] ResetSubtype GUID pointer for the reset subtype to be used.
>
> **/
> VOID
> EFIAPI
> -ResetPlatformSpecificGuid (
> +ResetSystemWithSubtype (
> + IN EFI_RESET_TYPE ResetType,
> IN CONST GUID *ResetSubtype
> )
> {
> @@ -51,7 +49,33 @@ ResetPlatformSpecificGuid (
> (GUID *)((UINT8 *)&ResetData + OFFSET_OF
> (RESET_UTILITY_GUID_SPECIFIC_RESET_DATA, ResetSubtype)),
> ResetSubtype
> );
> - ResetPlatformSpecific (sizeof (ResetData), &ResetData);
> +
> + ResetSystem (ResetType, EFI_SUCCESS, sizeof (ResetData), &ResetData);
> +}
> +
> +/**
> + This is a shorthand helper function to reset with a subtype so that
> + the caller doesn't have to bother with a function that has half a dozen
> + parameters.
> +
> + This will generate a reset with status EFI_SUCCESS, a NULL string, and
> + no custom data. The subtype will be formatted in such a way that it can be
> + picked up by notification registrations and custom handlers.
> +
> + NOTE: This call will fail if the architectural ResetSystem underpinnings
> + are not initialized. For DXE, you can add gEfiResetArchProtocolGuid
> + to your DEPEX.
> +
> + @param[in] ResetSubtype GUID pointer for the reset subtype to be used.
> +
> +**/
> +VOID
> +EFIAPI
> +ResetPlatformSpecificGuid (
> + IN CONST GUID *ResetSubtype
> + )
> +{
> + ResetSystemWithSubtype (EfiResetPlatformSpecific, ResetSubtype);
> }
Apart from the API description comments mentioned in patch 24, the patch
seems good to me,
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> /**
> --
> 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [edk2-devel] [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem
[not found] ` <3CE959C139B4C44DBEA1810E3AA6F9000B7C400F@SHSMSX101.ccr.corp.intel.com>
@ 2019-04-25 6:22 ` Ni, Ray
0 siblings, 0 replies; 36+ messages in thread
From: Ni, Ray @ 2019-04-25 6:22 UTC (permalink / raw)
To: Gao, Zhichao; +Cc: devel@edk2.groups.io
Reviewed-by: Ray Ni <ray.ni@intel.com>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Gao, Zhichao
> > Sent: Monday, April 15, 2019 11:06 AM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>
> > Subject: [edk2-devel] [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: Add
> > new API ResetSystem
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
> >
> > Add a new API ResetSystem to this ResetSystemLib instance.
> > It only adds the basic functions from ResetSystemRuntimeDxe.
> > Lacking of this interface may cause link error, if some drivers use
> > this new API and link to this library instance.
> > Notes:
> > This library API only provide a basic function of reset. Full function
> > should use the instance in the MdeModulePkg and make sure the depex
> > driver is dispatched.
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> >
> > diff --git a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
> > b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
> > index eccef89ebe..b215ebed61 100644
> > --- a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
> > +++ b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
> > @@ -99,3 +99,46 @@ ResetPlatformSpecific ( {
> > ResetCold ();
> > }
> > +
> > +/**
> > + The ResetSystem function resets the entire platform.
> > +
> > + @param[in] ResetType The type of reset to perform.
> > + @param[in] ResetStatus The status code for the reset.
> > + @param[in] DataSize The size, in bytes, of ResetData.
> > + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm,
> > or EfiResetShutdown
> > + the data buffer starts with a Null-terminated string,
> optionally
> > + followed by additional binary data. The string is a
> description
> > + that the caller may use to further indicate the reason for
> the
> > + system reset.
> > +**/
> > +VOID
> > +EFIAPI
> > +ResetSystem (
> > + IN EFI_RESET_TYPE ResetType,
> > + IN EFI_STATUS ResetStatus,
> > + IN UINTN DataSize,
> > + IN VOID *ResetData OPTIONAL
> > + )
> > +{
> > + switch (ResetType) {
> > + case EfiResetWarm:
> > + ResetWarm ();
> > + break;
> > +
> > + case EfiResetCold:
> > + ResetCold ();
> > + break;
> > +
> > + case EfiResetShutdown:
> > + ResetShutdown ();
> > + return ;
> > +
> > + case EfiResetPlatformSpecific:
> > + ResetPlatformSpecific (DataSize, ResetData);
> > + return;
> > +
> > + default:
> > + return ;
> > + }
> > +}
> > --
> > 2.21.0.windows.1
> >
> >
> >
^ permalink raw reply [flat|nested] 36+ messages in thread
end of thread, other threads:[~2019-04-25 6:23 UTC | newest]
Thread overview: 36+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-15 3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
2019-04-15 3:05 ` [PATCH 01/25] MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM Gao, Zhichao
2019-04-15 3:05 ` [PATCH 02/25] MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM Gao, Zhichao
2019-04-15 3:05 ` [PATCH 03/25] MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2 Gao, Zhichao
2019-04-15 3:05 ` [PATCH 04/25] MdePkg/PeiServicesLib.c: " Gao, Zhichao
2019-04-15 3:05 ` [PATCH 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset Gao, Zhichao
2019-04-15 3:05 ` [PATCH 06/25] MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem Gao, Zhichao
2019-04-15 3:05 ` [PATCH 07/25] MdeModulePkg/DxeResetSystemLib.c: " Gao, Zhichao
2019-04-15 3:05 ` [PATCH 08/25] MdeModulePkg/BaseResetSystemLibNull.c: " Gao, Zhichao
2019-04-15 3:05 ` [PATCH 09/25] MdeModulePkg/RuntimeResetSystemLib.c: Change comments Gao, Zhichao
2019-04-15 3:05 ` [PATCH 10/25] MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem Gao, Zhichao
2019-04-15 3:05 ` [PATCH 11/25] MdeModulePkg/ResetSystemRuntimeDxe: Change comments Gao, Zhichao
2019-04-15 3:05 ` [PATCH 12/25] MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2 Gao, Zhichao
2019-04-15 3:05 ` [PATCH 13/25] MdeModulePkg/PeiMain: Change comments of PeiResetSystem2 Gao, Zhichao
2019-04-15 3:06 ` [PATCH 14/25] MdeModulePkg/NvmExpressHci.c: Change comments Gao, Zhichao
2019-04-15 3:06 ` [PATCH 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem Gao, Zhichao
2019-04-15 9:51 ` [edk2-devel] " Leif Lindholm
2019-04-15 3:06 ` [PATCH 16/25] CorebootPayloadPkg/ResetSystemLib: " Gao, Zhichao
2019-04-15 3:06 ` [PATCH 17/25] Nt32Pkg/ResetSystemLib: " Gao, Zhichao
2019-04-17 3:15 ` [edk2-devel] " Wu, Hao A
2019-04-15 3:06 ` [PATCH 18/25] OvmfPkg/ResetSystemLib: " Gao, Zhichao
2019-04-15 16:38 ` Laszlo Ersek
2019-04-15 3:06 ` [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: " Gao, Zhichao
2019-04-15 3:06 ` [PATCH 20/25] QuarkSocPkg/ResetSystemLib: " Gao, Zhichao
2019-04-15 3:06 ` [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: " Gao, Zhichao
2019-04-15 3:20 ` [edk2-devel] " Sun, Zailiang
2019-04-15 3:06 ` [PATCH 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a " Gao, Zhichao
2019-04-15 9:52 ` Leif Lindholm
2019-04-15 3:06 ` [PATCH 23/25] ArmVirtPkg/ArmVirtPsciResetSystemLib: " Gao, Zhichao
2019-04-15 3:06 ` [PATCH 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype Gao, Zhichao
2019-04-17 5:24 ` Wu, Hao A
2019-04-15 3:06 ` [PATCH 25/25] " Gao, Zhichao
2019-04-17 5:47 ` [edk2-devel] " Wu, Hao A
2019-04-17 1:19 ` [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Liming Gao
2019-04-17 2:45 ` Wu, Hao A
[not found] ` <159586F2D3C4CEE3.6441@groups.io>
[not found] ` <3CE959C139B4C44DBEA1810E3AA6F9000B7C400F@SHSMSX101.ccr.corp.intel.com>
2019-04-25 6:22 ` [edk2-devel] [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem Ni, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox