From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=EmIKYgWw;
 spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67])
 by groups.io with SMTP; Mon, 15 Apr 2019 02:02:33 -0700
Received: by mail-wm1-f67.google.com with SMTP id q16so19597825wmj.3
        for <devel@edk2.groups.io>; Mon, 15 Apr 2019 02:02:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=fJVCT4YaDMOWM5KTL24jE6C63fgShC4RUYqQ4zIAHTE=;
        b=EmIKYgWwPO9hpTJfUiBtoSKzP53vAgXUNGE3bp0/cVZOLrlencbavtvPAh6lCV/pzX
         chdSUiQ6qcWoQZtuJ7/6zB9aHKHxQhDA14UIl3JBaPoKF4tzVOpoBIYdgdlT7nb4saQv
         qfkEGtYO91ezxPcPwRublE9TSmd0vi5EqN7bod04uwpmg6nzhDkWajFc/qephmkRN/6q
         KuquJ/iJdxWcBu9jhz9K/6ket8Eje1JmQKD4HDFcOlQiTYH2oEeINw0gq2xawOr6fq/b
         C4W/Y+pNQhA0HNHAl1KJYYOGex2r5tCS2Ih/tyZqHfmmfh//jLjljoHDjRNWUB2NgQrc
         11rw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=fJVCT4YaDMOWM5KTL24jE6C63fgShC4RUYqQ4zIAHTE=;
        b=r0PJA1vB1YQAua4pONZhUz1qQkxORHscshZNuRh8g5nnRoNOrwze6EzxSpR35rlcQr
         9dTe6sM1nmlx9gckGLwk87E6BxSVhuLWd8+2+fmg8IiGxQfONNZxiImfHygKCdjVVFXr
         7IY5uAAUgDyIt8TbIsSM3WporFYU7RjkB3FqGalJSrYc7A7BH883x+eNwpXtfMILmXL4
         YsM+cVNz4mPd0gsO7+XfXNFlzt1iZlJdPkJh0dx6CLc8GNS2vcrDC615CzigzgIasoG+
         CYgUez4x/PkSxLtaEszO9vDeH5aZ2G6wYqn98E0xO4IbJ4tkVnEyIrkUT5pYWybPW3/Y
         l7ZQ==
X-Gm-Message-State: APjAAAWbTBKKlr9nJJVFDC4IAZ1WJ//ZSJvGIlbWyX7FYVy1GM6XbRqv
	wvh87+OPAPrRLuizDxy4LbDwvw==
X-Google-Smtp-Source: APXvYqw3vo8lzqi5bs39z7SFfMPBSnkzP192YH5alnI9JQvDd3BUPhIPysAa+8aPBdy7lpYq5CnrKQ==
X-Received: by 2002:a1c:1d4:: with SMTP id 203mr22206361wmb.101.1555318951956;
        Mon, 15 Apr 2019 02:02:31 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id 4sm15582911wmi.14.2019.04.15.02.02.30
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Mon, 15 Apr 2019 02:02:31 -0700 (PDT)
Date: Mon, 15 Apr 2019 10:02:29 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Wu, Hao A" <hao.a.wu@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Andrew Fish <afish@apple.com>, "Zeng, Star" <star.zeng@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>,
	"Shi, Steven" <steven.shi@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol
Message-ID: <20190415090229.biz2hxcuvo35ieyr@bivouac.eciton.net>
References: <20190414195233.30045-1-ard.biesheuvel@linaro.org>
 <20190414195233.30045-2-ard.biesheuvel@linaro.org>
 <B80AF82E9BFB8E4FBD8C89DA810C6A093C8BEA6F@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8BEA6F@SHSMSX104.ccr.corp.intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 15, 2019 at 01:23:11AM +0000, Wu, Hao A wrote:
> > +  This program and the accompanying materials are licensed and made
> > available
> > +  under the terms and conditions of the BSD License which accompanies this
> > +  distribution.  The full text of the license may be found at
> > +  http://opensource.org/licenses/bsd-license.php
> > +
> > +  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> > BASIS,
> > +  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> > EXPRESS OR IMPLIED.
> > +
> > +**/
> > +
> > +#ifndef PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H
> > +#define PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H
> 
> Hello Ard,
> 
> Sorry for the delayed response.
> 
> Could you help to use:
> _PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H_
> 
> here to please the Ecc checker when you push the series?

Hmm...

Not a major issue, but I'll mention it anyway (which I mentioned to
Andrew/Mike at Linaro Connect in Vancouver last year):
clang has a warning, enabled by -Wreserved-id-macro, which complains
about this.

The Coding Style matches this, suggesting
MACROS_SHOULD_BE_WRITTEN_THUS_. So do we need to fix Ecc?

Regards,

Leif