public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: devel@edk2.groups.io, Andrew Fish <afish@apple.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator
Date: Mon, 15 Apr 2019 10:17:05 +0100	[thread overview]
Message-ID: <20190415091705.l4divyfw4jxjougd@bivouac.eciton.net> (raw)
In-Reply-To: <20190415024156.9101-1-ard.biesheuvel@linaro.org>

Some bikeshedding below:

On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote:
> Repo:   http://github.com/ardbiesheuvel/X86EmulatorPkg.git
> Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97

Does this permit execution of both IA32 and X64 code? If so, the name
makes sense (but the README.md in the above repo suggests otherwise,
and the readme here says nothing on the topic).

> Repo:   http://github.com/tiancore/edk2.git
> Commit: 2e21e8c4b89656897797019a9c56bc5ccbf12df1
> 
> Note that the X86EmulatorPkg project's license is _L_GPL not GPL,
> and so it could arguably be incorporated into edk2-non-osi in source
> form. However, the emulator is a rather sizable chunk of code, and
> providing a known working binary is preferred over having each
> platform build it from scratch, so providing just the binary should
> be sufficient for the time being.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> Note that this patch is against the edk2-non-osi repository, not EDK2
> itself.
> 
> Binaries are omitted from this patch. The complete patch can be found here:
> https://git.linaro.org/leg/noupstream/edk2-non-osi.git/commit/?h=upstream
> 
>  Emulator/X86EmulatorDxe/LICENSE              | 504 ++++++++++++++++++++
>  Emulator/X86EmulatorDxe/README               |   9 +

Could this be Readme.md?

>  Emulator/X86EmulatorDxe/X86EmulatorDxe.depex | Bin 0 -> 54 bytes
>  Emulator/X86EmulatorDxe/X86EmulatorDxe.efi   | Bin 0 -> 913408 bytes
>  Emulator/X86EmulatorDxe/X86EmulatorDxe.inf   |  21 +
>  5 files changed, 534 insertions(+)

/
    Leif

  reply	other threads:[~2019-04-15  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15  2:41 [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator Ard Biesheuvel
2019-04-15  9:17 ` Leif Lindholm [this message]
2019-04-15 17:57   ` Ard Biesheuvel
2019-04-15 18:06     ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190415091705.l4divyfw4jxjougd@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox