From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=bMpHs5Uy; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Mon, 15 Apr 2019 11:06:58 -0700 Received: by mail-wr1-f68.google.com with SMTP id g3so23130727wrx.9 for ; Mon, 15 Apr 2019 11:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kg7HDGp/aMKe2Egb4lenRifvGjqahFn+jtp1//X6Uxg=; b=bMpHs5Uy++kX0nsP8Urm5GsV4/e30CkOOjzv6aYEhY3Fe79AC76v4kHJpvywjbPmGG ND5Dz0bzctJ/ryrrkfmZ0P9aEs+2Kw3czqzIFPQhEo96DISiYfrHUnbyo6UnVO2LimSB nHrRydI+u1R5VroQfmTvGqauNWNvY5zaPwxs0pAddIVQoQfSaBZHI6TgN4S9J8F6Ie+c E+1TxVf/jhE+UOPtgoSZXu6RHRlbG23a23e1xGelHiJYTdu5YlcQG9WHY9RZ74TvGPvQ uO3vheHp/mUgihYQ/yQbLCQMZ9NDwIVZuGuG0wK5iUP5h8fIWAV4JiaI/NWfjZbhGnix PiiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kg7HDGp/aMKe2Egb4lenRifvGjqahFn+jtp1//X6Uxg=; b=aWe05TXWUlQBOiwct8YrZYb0jP5lrhU5ESRZnw5RnHvMRdODAZnnVAat07vn/kSA/z VfLzCM6o9VkxBRVhqBmNFxy+q8Q/OJnN4Vk0dsSk7zcyvF4KhSYxJN82/RWaBJlRjFMy tBRnErCqpi4JoIgDP0IIfcFGeoErR5THbn+bDuaYOFMUqrNQFTrHN2/JTcvj2Dwx+B7y bg77sLu9xHKKxhGW8XYvWaW75l0gt/nEbDsXPsbh35kEFt3ez1pa6XAdYpl4wJpjDtoT JZXQ0PM+PkE77QCJl/3Or38Ho3xMA8RYfkFamBGV4pQMUqpKaTrihK5YBS7ApLrF/SQz BZuQ== X-Gm-Message-State: APjAAAV6fX11BAGO1d2es51kgh36SVFEA9Q9K22Q5RtakaM0q2s3rC8m P+rCgu3nEnNmNhsVzk32OSATXw== X-Google-Smtp-Source: APXvYqwu0WHDOsdl8lfvTYTDJtAmshlFqe0J+n1X8cuIT5QPU0QkQgOkZEewZJxRCw86y/w/Ab+irw== X-Received: by 2002:adf:de07:: with SMTP id b7mr20345380wrm.196.1555351616837; Mon, 15 Apr 2019 11:06:56 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id i17sm54410969wrs.44.2019.04.15.11.06.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Apr 2019 11:06:56 -0700 (PDT) Date: Mon, 15 Apr 2019 19:06:54 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: edk2-devel-groups-io , Andrew Fish , Laszlo Ersek , Michael D Kinney Subject: Re: [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator Message-ID: <20190415180654.rvtyye44wqkyomze@bivouac.eciton.net> References: <20190415024156.9101-1-ard.biesheuvel@linaro.org> <20190415091705.l4divyfw4jxjougd@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 15, 2019 at 10:57:53AM -0700, Ard Biesheuvel wrote: > On Mon, 15 Apr 2019 at 02:17, Leif Lindholm wrote: > > > > Some bikeshedding below: > > > > On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote: > > > Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git > > > Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97 > > > > Does this permit execution of both IA32 and X64 code? If so, the name > > makes sense (but the README.md in the above repo suggests otherwise, > > and the readme here says nothing on the topic). > > > > I don't know whether the emulator itself supports IA32 execution, but > the driver definitely only registers itself for the X64 machine type. > > But since the naming of the upstream repo is not really under review > here, I will add a mention that only X64 is supported. Thanks. (Yes, what I meant was that since the name is ambiguous, more detail may be required in the commit message.) > > > Repo: http://github.com/tiancore/edk2.git > > > Commit: 2e21e8c4b89656897797019a9c56bc5ccbf12df1 > > > > > > Note that the X86EmulatorPkg project's license is _L_GPL not GPL, > > > and so it could arguably be incorporated into edk2-non-osi in source > > > form. However, the emulator is a rather sizable chunk of code, and > > > providing a known working binary is preferred over having each > > > platform build it from scratch, so providing just the binary should > > > be sufficient for the time being. > > > > > > Cc: Andrew Fish > > > Cc: Laszlo Ersek > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Signed-off-by: Ard Biesheuvel > > > --- > > > Note that this patch is against the edk2-non-osi repository, not EDK2 > > > itself. > > > > > > Binaries are omitted from this patch. The complete patch can be found here: > > > https://git.linaro.org/leg/noupstream/edk2-non-osi.git/commit/?h=upstream > > > > > > Emulator/X86EmulatorDxe/LICENSE | 504 ++++++++++++++++++++ > > > Emulator/X86EmulatorDxe/README | 9 + > > > > Could this be Readme.md? > > > > Of course. What does the .md stand for actually? MarkDown (I.e. https://en.wikipedia.org/wiki/Markdown) Doesn't make a difference for this version, but could for future ones. Also means you get it auto-displayed on the github page. / Leif > > > Emulator/X86EmulatorDxe/X86EmulatorDxe.depex | Bin 0 -> 54 bytes > > > Emulator/X86EmulatorDxe/X86EmulatorDxe.efi | Bin 0 -> 913408 bytes > > > Emulator/X86EmulatorDxe/X86EmulatorDxe.inf | 21 + > > > 5 files changed, 534 insertions(+) > > > > / > > Leif