From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Subject: Re: [PATCH edk2-platforms] Silicon/AMD: drop unused/orphaned Styx ResetSystemLib
Date: Tue, 16 Apr 2019 10:42:26 +0100 [thread overview]
Message-ID: <20190416094226.3o4ro64soyp7npox@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu9sd5M_2EJ9i_MPFXOgqzPfL2+3gjDUzdkdyJ4xAEtQzQ@mail.gmail.com>
On Mon, Apr 15, 2019 at 12:00:38PM -0700, Ard Biesheuvel wrote:
> On Mon, 15 Apr 2019 at 03:15, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > All Styx platforms in the tree (and the world) use
> > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> > these days, but somehow this orphaned .inf was left around - drop it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks. Pushed as a8cf8edf74.
/
Leif
> > ---
> > Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf | 44 ----------------
> > 1 file changed, 44 deletions(-)
> >
> > diff --git a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf b/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
> > deleted file mode 100644
> > index d9faf3abb0..0000000000
> > --- a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
> > +++ /dev/null
> > @@ -1,44 +0,0 @@
> > -#/** @file
> > -# Reset System lib using PSCI hypervisor or secure monitor calls
> > -#
> > -# Copyright (c) 2008, Apple Inc. All rights reserved.<BR>
> > -# Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
> > -# Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
> > -# Copyright (c) 2014 - 2016, AMD Inc. All rights reserved.<BR>
> > -#
> > -# This program and the accompanying materials
> > -# are licensed and made available under the terms and conditions of the BSD License
> > -# which accompanies this distribution. The full text of the license may be found at
> > -# http://opensource.org/licenses/bsd-license.php
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -#
> > -#**/
> > -#/**
> > -# Derived from:
> > -# ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf
> > -#
> > -#**/
> > -
> > -[Defines]
> > - INF_VERSION = 0x00010005
> > - BASE_NAME = AmdStyxResetSystemLib
> > - FILE_GUID = 624f6cc6-c38f-4897-b3b7-8a601701291b
> > - MODULE_TYPE = BASE
> > - VERSION_STRING = 1.0
> > - LIBRARY_CLASS = EfiResetSystemLib
> > -
> > -[Sources.common]
> > - ResetSystemLib.c
> > -
> > -[Packages]
> > - ArmPkg/ArmPkg.dec
> > - MdePkg/MdePkg.dec
> > - EmbeddedPkg/EmbeddedPkg.dec
> > - Silicon/AMD/Styx/AmdModulePkg/AmdModulePkg.dec
> > - Silicon/AMD/Styx/AmdStyx.dec
> > -
> > -[LibraryClasses]
> > - PcdLib
> > - BaseLib
> > - ArmSmcLib
> > --
> > 2.11.0
> >
prev parent reply other threads:[~2019-04-16 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 10:15 [PATCH edk2-platforms] Silicon/AMD: drop unused/orphaned Styx ResetSystemLib Leif Lindholm
2019-04-15 19:00 ` Ard Biesheuvel
2019-04-16 9:42 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416094226.3o4ro64soyp7npox@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox