From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: zhichao.gao@intel.com) Received: from mga12.intel.com (mga12.intel.com []) by groups.io with SMTP; Tue, 16 Apr 2019 23:28:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 23:28:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,360,1549958400"; d="scan'208";a="162306262" Received: from fieedk001.ccr.corp.intel.com ([10.239.33.119]) by fmsmga002.fm.intel.com with ESMTP; 16 Apr 2019 23:28:14 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jian J Wang , Hao Wu , Ray Ni , Star Zeng , Liming Gao , Sean Brogan , Michael Turner , Bret Barkelew Subject: [PATCH V2 13/25] MdeModulePkg/PeiMain: Change comments of PeiResetSystem2 Date: Wed, 17 Apr 2019 14:27:10 +0800 Message-Id: <20190417062722.8568-14-zhichao.gao@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20190417062722.8568-1-zhichao.gao@intel.com> References: <20190417062722.8568-1-zhichao.gao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao Reviewed-by: Hao Wu --- MdeModulePkg/Core/Pei/PeiMain.h | 4 +--- MdeModulePkg/Core/Pei/Reset/Reset.c | 6 ++---- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h index 0aed4f4685..f2aa97c664 100644 --- a/MdeModulePkg/Core/Pei/PeiMain.h +++ b/MdeModulePkg/Core/Pei/PeiMain.h @@ -1097,9 +1097,7 @@ PeiResetSystem ( the data buffer starts with a Null-terminated string, optionally followed by additional binary data. The string is a description that the caller may use to further indicate the reason for the - system reset. ResetData is only valid if ResetStatus is something - other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific - where a minimum amount of ResetData is always required. + system reset. **/ VOID diff --git a/MdeModulePkg/Core/Pei/Reset/Reset.c b/MdeModulePkg/Core/Pei/Reset/Reset.c index 263eace239..0c3cfad035 100644 --- a/MdeModulePkg/Core/Pei/Reset/Reset.c +++ b/MdeModulePkg/Core/Pei/Reset/Reset.c @@ -1,7 +1,7 @@ /** @file Pei Core Reset System Support -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -72,9 +72,7 @@ PeiResetSystem ( the data buffer starts with a Null-terminated string, optionally followed by additional binary data. The string is a description that the caller may use to further indicate the reason for the - system reset. ResetData is only valid if ResetStatus is something - other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific - where a minimum amount of ResetData is always required. + system reset. **/ VOID -- 2.21.0.windows.1