public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>, Hao Wu <hao.a.wu@intel.com>,
	Ray Ni <ray.ni@intel.com>, Star Zeng <star.zeng@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Michael Turner <Michael.Turner@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [PATCH V2 14/25] MdeModulePkg/NvmExpressHci.c: Change comments
Date: Wed, 17 Apr 2019 14:27:11 +0800	[thread overview]
Message-ID: <20190417062722.8568-15-zhichao.gao@intel.com> (raw)
In-Reply-To: <20190417062722.8568-1-zhichao.gao@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460

Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
or not. So change the comments of NvmeShutdownAllControllers.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
---
 MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
index d1b106ef61..95f8b18bc4 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
+++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
@@ -966,10 +966,7 @@ NvmeControllerInit (
                                 EfiResetShutdown the data buffer starts with a Null-terminated
                                 string, optionally followed by additional binary data.
                                 The string is a description that the caller may use to further
-                                indicate the reason for the system reset. ResetData is only
-                                valid if ResetStatus is something other than EFI_SUCCESS
-                                unless the ResetType is EfiResetPlatformSpecific
-                                where a minimum amount of ResetData is always required.
+                                indicate the reason for the system reset.
                                 For a ResetType of EfiResetPlatformSpecific the data buffer
                                 also starts with a Null-terminated string that is followed
                                 by an EFI_GUID that describes the specific type of reset to perform.
-- 
2.21.0.windows.1


  parent reply	other threads:[~2019-04-17  6:28 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  6:26 [PATCH V2 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
2019-04-17  6:26 ` [PATCH V2 01/25] MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM Gao, Zhichao
2019-04-17  6:26 ` [PATCH V2 02/25] MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 03/25] MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2 Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 04/25] MdePkg/PeiServicesLib.c: " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset Gao, Zhichao
2019-04-18  3:30   ` Zhang, Chao B
2019-04-17  6:27 ` [PATCH V2 06/25] MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 07/25] MdeModulePkg/DxeResetSystemLib.c: " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 08/25] MdeModulePkg/BaseResetSystemLibNull.c: " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 09/25] MdeModulePkg/RuntimeResetSystemLib.c: Change comments Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 10/25] MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 11/25] MdeModulePkg/ResetSystemRuntimeDxe: Change comments Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 12/25] MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2 Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 13/25] MdeModulePkg/PeiMain: Change comments of PeiResetSystem2 Gao, Zhichao
2019-04-17  6:27 ` Gao, Zhichao [this message]
2019-04-17  6:27 ` [PATCH V2 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 16/25] CorebootPayloadPkg/ResetSystemLib: " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 17/25] Nt32Pkg/ResetSystemLib: " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 18/25] OvmfPkg/ResetSystemLib: " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 19/25] PcAtChipsetPkg/ResetSystemLib: " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 20/25] QuarkSocPkg/ResetSystemLib: " Gao, Zhichao
2019-04-25 17:09   ` [edk2-devel] " Michael D Kinney
2019-04-17  6:27 ` [PATCH V2 21/25] Vlv2TbltdevicePkg/ResetSystemLib: " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 23/25] ArmVirtPkg/ArmVirtPsciResetSystemLib: " Gao, Zhichao
2019-04-17  6:27 ` [PATCH V2 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype Gao, Zhichao
2019-04-17  6:36   ` Wu, Hao A
2019-04-17  6:27 ` [PATCH V2 25/25] " Gao, Zhichao
2019-04-17  6:37   ` [edk2-devel] " Wu, Hao A
2019-04-25 16:46 ` [PATCH V2 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Steele, Kelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417062722.8568-15-zhichao.gao@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox