public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: devel@edk2.groups.io
Cc: David Wei <david.wei@intel.com>, Yi Qian <yi.qian@intel.com>
Subject: [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration
Date: Thu, 18 Apr 2019 12:53:23 +0800	[thread overview]
Message-ID: <20190418045323.2684-1-zailiang.sun@intel.com> (raw)

Use MdeModulePkg declaration of ResetSystem function, comment the one
in platform source code.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun <zailiang.sun@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Reviewed-by: Yi Qian <yi.qian@intel.com>
---
 Vlv2TbltDevicePkg/PlatformPei/Platform.c |  1 -
 Vlv2TbltDevicePkg/PlatformPei/Platform.h | 12 +++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.c b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
index cf47a56a52..eba1dfff30 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.c
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
@@ -18,7 +18,6 @@ Module Name:
 #include "PlatformBaseAddresses.h"
 #include "PchAccess.h"
 #include <Guid/PlatformInfo.h>
-#include "Platform.h"
 #include "PchCommonDefinitions.h"
 #include <Ppi/MfgMemoryTest.h>
 #include <Guid/SetupVariable.h>
diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.h b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
index 4158dd4cf5..e1817b28c6 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.h
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
@@ -47,16 +47,18 @@ UpdateBootMode (
 /**
   This function reset the entire platform, including all processor and devices, and
   reboots the system.
+  
+  Declaration of this function goes to MdeModulePkg/Include/Library/ResetSystemLib.h
 
   @param  PeiServices General purpose services available to every PEIM.
 
   @retval EFI_SUCCESS if it completed successfully.
 **/
-EFI_STATUS
-EFIAPI
-ResetSystem (
-  IN CONST EFI_PEI_SERVICES          **PeiServices
-  );
+// EFI_STATUS
+// EFIAPI
+// ResetSystem (
+  // IN CONST EFI_PEI_SERVICES          **PeiServices
+  // );
 
 /**
   This function will be called when MRC is done.
-- 
2.19.1.windows.1


             reply	other threads:[~2019-04-18  4:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18  4:53 Sun, Zailiang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-04-17  9:21 [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration Sun, Zailiang
2019-04-18  2:11 ` Qian, Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190418045323.2684-1-zailiang.sun@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox