public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration
@ 2019-04-17  9:21 Sun, Zailiang
  2019-04-18  2:11 ` Qian, Yi
  0 siblings, 1 reply; 3+ messages in thread
From: Sun, Zailiang @ 2019-04-17  9:21 UTC (permalink / raw)
  To: devel; +Cc: David Wei, Yi Qian

Use MdeModulePkg declaration of ResetSystem function, comment the one
in platform source code.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun <zailiang.sun@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
---
 Vlv2TbltDevicePkg/PlatformPei/Platform.c |  1 -
 Vlv2TbltDevicePkg/PlatformPei/Platform.h | 12 +++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.c b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
index cf47a56a52..eba1dfff30 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.c
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
@@ -18,7 +18,6 @@ Module Name:
 #include "PlatformBaseAddresses.h"
 #include "PchAccess.h"
 #include <Guid/PlatformInfo.h>
-#include "Platform.h"
 #include "PchCommonDefinitions.h"
 #include <Ppi/MfgMemoryTest.h>
 #include <Guid/SetupVariable.h>
diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.h b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
index 4158dd4cf5..e1817b28c6 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.h
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
@@ -47,16 +47,18 @@ UpdateBootMode (
 /**
   This function reset the entire platform, including all processor and devices, and
   reboots the system.
+  
+  Declaration of this function goes to MdeModulePkg/Include/Library/ResetSystemLib.h
 
   @param  PeiServices General purpose services available to every PEIM.
 
   @retval EFI_SUCCESS if it completed successfully.
 **/
-EFI_STATUS
-EFIAPI
-ResetSystem (
-  IN CONST EFI_PEI_SERVICES          **PeiServices
-  );
+// EFI_STATUS
+// EFIAPI
+// ResetSystem (
+  // IN CONST EFI_PEI_SERVICES          **PeiServices
+  // );
 
 /**
   This function will be called when MRC is done.
-- 
2.19.1.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration
  2019-04-17  9:21 Sun, Zailiang
@ 2019-04-18  2:11 ` Qian, Yi
  0 siblings, 0 replies; 3+ messages in thread
From: Qian, Yi @ 2019-04-18  2:11 UTC (permalink / raw)
  To: Sun, Zailiang, devel@edk2.groups.io; +Cc: Wei, David

Reviewed by Qian, Yi<yi.qian@intel.com>

Thanks
Qian Yi

-----Original Message-----
From: Sun, Zailiang 
Sent: Wednesday, April 17, 2019 5:21 PM
To: devel@edk2.groups.io
Cc: Wei, David <david.wei@intel.com>; Qian, Yi <yi.qian@intel.com>
Subject: [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration

Use MdeModulePkg declaration of ResetSystem function, comment the one in platform source code.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun <zailiang.sun@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
---
 Vlv2TbltDevicePkg/PlatformPei/Platform.c |  1 -  Vlv2TbltDevicePkg/PlatformPei/Platform.h | 12 +++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.c b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
index cf47a56a52..eba1dfff30 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.c
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
@@ -18,7 +18,6 @@ Module Name:
 #include "PlatformBaseAddresses.h"
 #include "PchAccess.h"
 #include <Guid/PlatformInfo.h>
-#include "Platform.h"
 #include "PchCommonDefinitions.h"
 #include <Ppi/MfgMemoryTest.h>
 #include <Guid/SetupVariable.h>
diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.h b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
index 4158dd4cf5..e1817b28c6 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.h
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
@@ -47,16 +47,18 @@ UpdateBootMode (
 /**
   This function reset the entire platform, including all processor and devices, and
   reboots the system.
+
+  Declaration of this function goes to 
+ MdeModulePkg/Include/Library/ResetSystemLib.h
 
   @param  PeiServices General purpose services available to every PEIM.
 
   @retval EFI_SUCCESS if it completed successfully.
 **/
-EFI_STATUS
-EFIAPI
-ResetSystem (
-  IN CONST EFI_PEI_SERVICES          **PeiServices
-  );
+// EFI_STATUS
+// EFIAPI
+// ResetSystem (
+  // IN CONST EFI_PEI_SERVICES          **PeiServices
+  // );
 
 /**
   This function will be called when MRC is done.
--
2.19.1.windows.1



-- 
Qian Yi

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration
@ 2019-04-18  4:53 Sun, Zailiang
  0 siblings, 0 replies; 3+ messages in thread
From: Sun, Zailiang @ 2019-04-18  4:53 UTC (permalink / raw)
  To: devel; +Cc: David Wei, Yi Qian

Use MdeModulePkg declaration of ResetSystem function, comment the one
in platform source code.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun <zailiang.sun@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Reviewed-by: Yi Qian <yi.qian@intel.com>
---
 Vlv2TbltDevicePkg/PlatformPei/Platform.c |  1 -
 Vlv2TbltDevicePkg/PlatformPei/Platform.h | 12 +++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.c b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
index cf47a56a52..eba1dfff30 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.c
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
@@ -18,7 +18,6 @@ Module Name:
 #include "PlatformBaseAddresses.h"
 #include "PchAccess.h"
 #include <Guid/PlatformInfo.h>
-#include "Platform.h"
 #include "PchCommonDefinitions.h"
 #include <Ppi/MfgMemoryTest.h>
 #include <Guid/SetupVariable.h>
diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.h b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
index 4158dd4cf5..e1817b28c6 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.h
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
@@ -47,16 +47,18 @@ UpdateBootMode (
 /**
   This function reset the entire platform, including all processor and devices, and
   reboots the system.
+  
+  Declaration of this function goes to MdeModulePkg/Include/Library/ResetSystemLib.h
 
   @param  PeiServices General purpose services available to every PEIM.
 
   @retval EFI_SUCCESS if it completed successfully.
 **/
-EFI_STATUS
-EFIAPI
-ResetSystem (
-  IN CONST EFI_PEI_SERVICES          **PeiServices
-  );
+// EFI_STATUS
+// EFIAPI
+// ResetSystem (
+  // IN CONST EFI_PEI_SERVICES          **PeiServices
+  // );
 
 /**
   This function will be called when MRC is done.
-- 
2.19.1.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-18  4:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-18  4:53 [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration Sun, Zailiang
  -- strict thread matches above, loose matches on Subject: below --
2019-04-17  9:21 Sun, Zailiang
2019-04-18  2:11 ` Qian, Yi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox