[PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[rebecca]

When building OpenSSL, the OpenBSD/FreeBSD/DFBSD code in crypto/uid.c
calls issetugid(). Add the declaration of this function to
CrtLibSupport.h to avoid the need to patch the openssl code on these
platforms.

Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
---
 CryptoPkg/Library/Include/CrtLibSupport.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h
index a241fb96fb..b05c5d908c 100644
--- a/CryptoPkg/Library/Include/CrtLibSupport.h
+++ b/CryptoPkg/Library/Include/CrtLibSupport.h
@@ -155,6 +155,7 @@ uid_t          getuid      (void);
 uid_t          geteuid     (void);
 gid_t          getgid      (void);
 gid_t          getegid     (void);
+int            issetugid   (void);
 void           qsort       (void *, size_t, size_t, int (*)(const void *, const void *));
 char           *getenv     (const char *);
 char           *secure_getenv (const char *);
-- 
2.21.0

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[Ard Biesheuvel]

On Sat, 20 Apr 2019 at 00:38, rebecca via Groups.Io
<rebecca=bluestop.org@groups.io> wrote:
>
> When building OpenSSL, the OpenBSD/FreeBSD/DFBSD code in crypto/uid.c
> calls issetugid(). Add the declaration of this function to
> CrtLibSupport.h to avoid the need to patch the openssl code on these
> platforms.
>
> Signed-off-by: Rebecca Cran <rebecca@bluestop.org>

This is slightly odd. The host architecture shouldn't really matter,
and so if we end up calling different code in UEFI when built on *BSD,
there is differently something wrong. Or am I missing something?

> ---
>  CryptoPkg/Library/Include/CrtLibSupport.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h
> index a241fb96fb..b05c5d908c 100644
> --- a/CryptoPkg/Library/Include/CrtLibSupport.h
> +++ b/CryptoPkg/Library/Include/CrtLibSupport.h
> @@ -155,6 +155,7 @@ uid_t          getuid      (void);
>  uid_t          geteuid     (void);
>  gid_t          getgid      (void);
>  gid_t          getegid     (void);
> +int            issetugid   (void);
>  void           qsort       (void *, size_t, size_t, int (*)(const void *, const void *));
>  char           *getenv     (const char *);
>  char           *secure_getenv (const char *);
> --
> 2.21.0
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#39338): https://edk2.groups.io/g/devel/message/39338
> Mute This Topic: https://groups.io/mt/31250604/1761188
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [ard.biesheuvel@linaro.org]
> ------------
>

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[Ard Biesheuvel]

On Sat, 20 Apr 2019 at 13:28, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Sat, 20 Apr 2019 at 00:38, rebecca via Groups.Io
> <rebecca=bluestop.org@groups.io> wrote:
> >
> > When building OpenSSL, the OpenBSD/FreeBSD/DFBSD code in crypto/uid.c
> > calls issetugid(). Add the declaration of this function to
> > CrtLibSupport.h to avoid the need to patch the openssl code on these
> > platforms.
> >
> > Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
>
> This is slightly odd. The host architecture shouldn't really matter,
> and so if we end up calling different code in UEFI when built on *BSD,
> there is differently something wrong. Or am I missing something?
>

*definitely

> > ---
> >  CryptoPkg/Library/Include/CrtLibSupport.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h
> > index a241fb96fb..b05c5d908c 100644
> > --- a/CryptoPkg/Library/Include/CrtLibSupport.h
> > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h
> > @@ -155,6 +155,7 @@ uid_t          getuid      (void);
> >  uid_t          geteuid     (void);
> >  gid_t          getgid      (void);
> >  gid_t          getegid     (void);
> > +int            issetugid   (void);
> >  void           qsort       (void *, size_t, size_t, int (*)(const void *, const void *));
> >  char           *getenv     (const char *);
> >  char           *secure_getenv (const char *);
> > --
> > 2.21.0
> >
> >
> > ------------
> > Groups.io Links: You receive all messages sent to this group.
> >
> > View/Reply Online (#39338): https://edk2.groups.io/g/devel/message/39338
> > Mute This Topic: https://groups.io/mt/31250604/1761188
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub  [ard.biesheuvel@linaro.org]
> > ------------
> >

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[rebecca]

On 2019-04-20 05:28, Ard Biesheuvel wrote:
>
> This is slightly odd. The host architecture shouldn't really matter,
> and so if we end up calling different code in UEFI when built on *BSD,
> there is differently something wrong. Or am I missing something?


No, that's a good point. I guess it's something we don't ever call.

In fact, OVMF continues to build after removing crypto/uid.c (which
contains the OPENSSL_issetugid definition) from
CryptoPkg/Library/OpensslLib/OpensslLib.inf and
CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf .


-- 

Rebecca Cran

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[Wang, Jian J]

crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep it in inf.
That means we need this patch for build on FreeBSD.

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Jian

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> rebecca via Groups.Io
> Sent: Sunday, April 21, 2019 1:18 AM
> To: devel@edk2.groups.io; ard.biesheuvel@linaro.org
> Cc: Ye, Ting <ting.ye@intel.com>; Gang Wei <gang.wei@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix
> openssl build on FreeBSD
> 
> On 2019-04-20 05:28, Ard Biesheuvel wrote:
> >
> > This is slightly odd. The host architecture shouldn't really matter,
> > and so if we end up calling different code in UEFI when built on *BSD,
> > there is differently something wrong. Or am I missing something?
> 
> 
> No, that's a good point. I guess it's something we don't ever call.
> 
> In fact, OVMF continues to build after removing crypto/uid.c (which
> contains the OPENSSL_issetugid definition) from
> CryptoPkg/Library/OpensslLib/OpensslLib.inf and
> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf .
> 
> 
> --
> 
> Rebecca Cran
> 
> 
> 

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[Philippe Mathieu-Daudé]

On 4/22/19 3:46 PM, Wang, Jian J wrote:
> crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep it in inf.
> That means we need this patch for build on FreeBSD.
> 
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Commit 1a734ed85fda71630c795832e6d24ea560caf739 has weird authorship
again: rebecca via Groups.Io <rebecca=bluestop.org@groups.io>

> Jian
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> rebecca via Groups.Io
>> Sent: Sunday, April 21, 2019 1:18 AM
>> To: devel@edk2.groups.io; ard.biesheuvel@linaro.org
>> Cc: Ye, Ting <ting.ye@intel.com>; Gang Wei <gang.wei@intel.com>; Wang, Jian
>> J <jian.j.wang@intel.com>
>> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix
>> openssl build on FreeBSD
>>
>> On 2019-04-20 05:28, Ard Biesheuvel wrote:
>>>
>>> This is slightly odd. The host architecture shouldn't really matter,
>>> and so if we end up calling different code in UEFI when built on *BSD,
>>> there is differently something wrong. Or am I missing something?
>>
>>
>> No, that's a good point. I guess it's something we don't ever call.
>>
>> In fact, OVMF continues to build after removing crypto/uid.c (which
>> contains the OPENSSL_issetugid definition) from
>> CryptoPkg/Library/OpensslLib/OpensslLib.inf and
>> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf .
>>
>>
>> --
>>
>> Rebecca Cran

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[Laszlo Ersek]

+Stephano

On 04/24/19 11:25, Philippe Mathieu-Daudé wrote:
> On 4/22/19 3:46 PM, Wang, Jian J wrote:
>> crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep it in inf.
>> That means we need this patch for build on FreeBSD.
>>
>> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> 
> Commit 1a734ed85fda71630c795832e6d24ea560caf739 has weird authorship
> again: rebecca via Groups.Io <rebecca=bluestop.org@groups.io>

And, again, that's exactly how the sender is displayed to me by
Thunderbird, in my list folder only:

  From: Rebecca via Groups.Io <rebecca=bluestop.org@groups.io>

Again, in email that I get directly from Rebecca, the From field looks
just fine.

So I don't think there's anything to fix for package maintainers here.
It seems that groups.io rewrites the sender address for Rebecca. I don't
know why groups.io performs this rewrite, and why only for Rebecca.

Stephano -- can you please ask groups.io why it keeps changing the From
header on messages sent by "Rebecca Cran <rebecca@bluestop.org>"?

Thanks
Laszlo

> 
>> Jian
>>
>>> -----Original Message-----
>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>>> rebecca via Groups.Io
>>> Sent: Sunday, April 21, 2019 1:18 AM
>>> To: devel@edk2.groups.io; ard.biesheuvel@linaro.org
>>> Cc: Ye, Ting <ting.ye@intel.com>; Gang Wei <gang.wei@intel.com>; Wang, Jian
>>> J <jian.j.wang@intel.com>
>>> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix
>>> openssl build on FreeBSD
>>>
>>> On 2019-04-20 05:28, Ard Biesheuvel wrote:
>>>>
>>>> This is slightly odd. The host architecture shouldn't really matter,
>>>> and so if we end up calling different code in UEFI when built on *BSD,
>>>> there is differently something wrong. Or am I missing something?
>>>
>>>
>>> No, that's a good point. I guess it's something we don't ever call.
>>>
>>> In fact, OVMF continues to build after removing crypto/uid.c (which
>>> contains the OPENSSL_issetugid definition) from
>>> CryptoPkg/Library/OpensslLib/OpensslLib.inf and
>>> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf .
>>>
>>>
>>> --
>>>
>>> Rebecca Cran
> 
> 
> 

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[rebecca]

On 2019-04-24 13:17, Laszlo Ersek wrote:
>
> Again, in email that I get directly from Rebecca, the From field looks
> just fine.
>
> So I don't think there's anything to fix for package maintainers here.
> It seems that groups.io rewrites the sender address for Rebecca. I don't
> know why groups.io performs this rewrite, and why only for Rebecca.
>
> Stephano -- can you please ask groups.io why it keeps changing the From
> header on messages sent by "Rebecca Cran <rebecca@bluestop.org>"?



I think it'll be because I'm still sending email with DKIM signatures: I
thought I'd disabled it for edk2.groups.io but I'll go investigate why
it's still being added.


-- 
Rebecca Cran

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[rebecca]

On 2019-04-24 13:17, Laszlo Ersek wrote:
>
> So I don't think there's anything to fix for package maintainers here.
> It seems that groups.io rewrites the sender address for Rebecca. I don't
> know why groups.io performs this rewrite, and why only for Rebecca.
>
> Stephano -- can you please ask groups.io why it keeps changing the From
> header on messages sent by "Rebecca Cran <rebecca@bluestop.org>"?



Trying again, now that I've disabled DKIM.


-- 
Rebecca Cran

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[Wang, Jian J]

Looks normal now.

Regards,
Jian

> -----Original Message-----
> From: Rebecca Cran [mailto:rebecca@bluestop.org]
> Sent: Thursday, April 25, 2019 3:37 AM
> To: devel@edk2.groups.io; lersek@redhat.com; philmd@redhat.com; Wang,
> Jian J <jian.j.wang@intel.com>; ard.biesheuvel@linaro.org
> Cc: Ye, Ting <ting.ye@intel.com>; Cetola, Stephano
> <stephano.cetola@intel.com>
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix
> openssl build on FreeBSD
> 
> On 2019-04-24 13:17, Laszlo Ersek wrote:
> >
> > So I don't think there's anything to fix for package maintainers here.
> > It seems that groups.io rewrites the sender address for Rebecca. I don't
> > know why groups.io performs this rewrite, and why only for Rebecca.
> >
> > Stephano -- can you please ask groups.io why it keeps changing the From
> > header on messages sent by "Rebecca Cran <rebecca@bluestop.org>"?
> 
> 
> 
> Trying again, now that I've disabled DKIM.
> 
> 
> --
> Rebecca Cran

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[rebecca]

On 2019-04-24 13:17, Laszlo Ersek wrote:
>
> And, again, that's exactly how the sender is displayed to me by
> Thunderbird, in my list folder only:
>
>   From: Rebecca via Groups.Io <rebecca=bluestop.org@groups.io>
>
> Again, in email that I get directly from Rebecca, the From field looks
> just fine.
>
> So I don't think there's anything to fix for package maintainers here.
> It seems that groups.io rewrites the sender address for Rebecca. I don't
> know why groups.io performs this rewrite, and why only for Rebecca.
>
> Stephano -- can you please ask groups.io why it keeps changing the From
> header on messages sent by "Rebecca Cran <rebecca@bluestop.org>"?



Okay, let's try one more time now that I've also removed the DKIM
entries from DNS.


-- 
Rebecca Cran

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[Andrew Fish]

> On Apr 26, 2019, at 6:55 AM, rebecca@bluestop.org wrote:
> 
> On 2019-04-24 13:17, Laszlo Ersek wrote:
>> 
>> And, again, that's exactly how the sender is displayed to me by
>> Thunderbird, in my list folder only:
>> 
>>  From: Rebecca via Groups.Io <rebecca=bluestop.org@groups.io>
>> 
>> Again, in email that I get directly from Rebecca, the From field looks
>> just fine.
>> 
>> So I don't think there's anything to fix for package maintainers here.
>> It seems that groups.io rewrites the sender address for Rebecca. I don't
>> know why groups.io performs this rewrite, and why only for Rebecca.
>> 
>> Stephano -- can you please ask groups.io why it keeps changing the From
>> header on messages sent by "Rebecca Cran <rebecca@bluestop.org>"?
> 
> 
> 
> Okay, let's try one more time now that I've also removed the DKIM
> entries from DNS.
> 

Rebecca,

That one seemed to work!

Thanks,

Andrew Fish

> 
> -- 
> Rebecca Cran
> 
> 
> 
> 

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[rebecca]

On 2019-04-26 07:56, Andrew Fish via Groups.Io wrote:
> That one seemed to work!


Great! Though it looks like you're going to have a problem: I see "From:
Andrew Fish via Groups.Io <afish=apple.com@groups.io>"


-- 
Rebecca Cran

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[Laszlo Ersek]

On 04/26/19 15:55, rebecca@bluestop.org wrote:
> On 2019-04-24 13:17, Laszlo Ersek wrote:
>>
>> And, again, that's exactly how the sender is displayed to me by
>> Thunderbird, in my list folder only:
>>
>>   From: Rebecca via Groups.Io <rebecca=bluestop.org@groups.io>
>>
>> Again, in email that I get directly from Rebecca, the From field looks
>> just fine.
>>
>> So I don't think there's anything to fix for package maintainers here.
>> It seems that groups.io rewrites the sender address for Rebecca. I don't
>> know why groups.io performs this rewrite, and why only for Rebecca.
>>
>> Stephano -- can you please ask groups.io why it keeps changing the From
>> header on messages sent by "Rebecca Cran <rebecca@bluestop.org>"?
> 
> 
> 
> Okay, let's try one more time now that I've also removed the DKIM
> entries from DNS.
> 
> 

This one looks good -- the From address has changed from

  rebecca via Groups.Io <rebecca=bluestop.org@groups.io>

to

  rebecca@bluestop.org

Thanks!
Laszlo

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

[rebecca]

On 2019-04-26 14:19, Laszlo Ersek wrote:
>
> This one looks good -- the From address has changed from
>
>   rebecca via Groups.Io <rebecca=bluestop.org@groups.io>
>
> to
>
>   rebecca@bluestop.org


Oh, it's in their FAQ! :D

https://groups.io/static/help#dmarc


      Why Are Emails From Some People Changed To Be 'via Groups.io'?

The reason that some email addresses are changed to be 'via Groups.io'
is because of something called DMARC. Some email services, like Yahoo
and AOL, have set up their DMARC profiles so that we have to change all
their users' email addresses to this form, otherwise the messages would
bounce. This is not limited to Groups.io, all email groups services have
to do this.


-- 
Rebecca Cran