* [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings
@ 2019-04-25 18:58 Michael D Kinney
2019-04-25 21:38 ` Steele, Kelly
0 siblings, 1 reply; 2+ messages in thread
From: Michael D Kinney @ 2019-04-25 18:58 UTC (permalink / raw)
To: devel; +Cc: Kelly Steele
Resolve a few warnings from the latest iASL compilers.
Cc: Kelly Steele <kelly.steele@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi | 4 ++--
QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
index 979e5b58b1..9a5812d068 100644
--- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
+++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
@@ -1,7 +1,7 @@
/** @file
Expose GPIO resources to usermode through client driver.
-Copyright (c) 2013-2015 Intel Corporation.
+Copyright (c) 2013-2019 Intel Corporation.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -11,7 +11,7 @@ Device(GPOT)
{
Name(_HID, "INT349A")
Name(_CID, "INT349A")
- Method(_CRS, 0x0, NotSerialized)
+ Method(_CRS, 0x0, Serialized)
{
Name(RBUF, ResourceTemplate()
{
diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
index 53633dfbe4..35bae8248a 100644
--- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
+++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
@@ -1,7 +1,7 @@
/** @file
Contains root level name space objects for the platform
-Copyright (c) 2013-2015 Intel Corporation.
+Copyright (c) 2013-2019 Intel Corporation.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -50,7 +50,7 @@ DefinitionBlock (
"DSDT",
1,
"INTEL ",
- "QuarkNcSocId",
+ "QuarkNcS",
3)
{
//
@@ -275,7 +275,7 @@ DefinitionBlock (
Method (_INI)
{
Store(LINUX, OSTP) // Set the default os is Linux
- If (CondRefOf (_OSI, local0))
+ If (CondRefOf (_OSI))
{
//
//_OSI is supported, so it is WinXp or Win2003Server
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings
2019-04-25 18:58 [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings Michael D Kinney
@ 2019-04-25 21:38 ` Steele, Kelly
0 siblings, 0 replies; 2+ messages in thread
From: Steele, Kelly @ 2019-04-25 21:38 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Reviewed-by: Kelly Steele <kelly.steele@intel.com>
> -----Original Message-----
> From: Kinney, Michael D
> Sent: April 25, 2019 11:59
> To: devel@edk2.groups.io
> Cc: Steele, Kelly <kelly.steele@intel.com>
> Subject: [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings
>
> Resolve a few warnings from the latest iASL compilers.
>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi | 4 ++--
> QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
> b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
> index 979e5b58b1..9a5812d068 100644
> --- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
> +++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi
> @@ -1,7 +1,7 @@
> /** @file
> Expose GPIO resources to usermode through client driver.
>
> -Copyright (c) 2013-2015 Intel Corporation.
> +Copyright (c) 2013-2019 Intel Corporation.
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -11,7 +11,7 @@ Device(GPOT)
> {
> Name(_HID, "INT349A")
> Name(_CID, "INT349A")
> - Method(_CRS, 0x0, NotSerialized)
> + Method(_CRS, 0x0, Serialized)
> {
> Name(RBUF, ResourceTemplate()
> {
> diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
> b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
> index 53633dfbe4..35bae8248a 100644
> --- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
> +++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl
> @@ -1,7 +1,7 @@
> /** @file
> Contains root level name space objects for the platform
>
> -Copyright (c) 2013-2015 Intel Corporation.
> +Copyright (c) 2013-2019 Intel Corporation.
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -50,7 +50,7 @@ DefinitionBlock (
> "DSDT",
> 1,
> "INTEL ",
> - "QuarkNcSocId",
> + "QuarkNcS",
> 3)
> {
> //
> @@ -275,7 +275,7 @@ DefinitionBlock (
> Method (_INI)
> {
> Store(LINUX, OSTP) // Set the default os is Linux
> - If (CondRefOf (_OSI, local0))
> + If (CondRefOf (_OSI))
> {
> //
> //_OSI is supported, so it is WinXp or Win2003Server
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-25 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-25 18:58 [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings Michael D Kinney
2019-04-25 21:38 ` Steele, Kelly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox